You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/09/08 15:29:30 UTC
[GitHub] [storm] Ethanlm opened a new pull request #3331: [STORM-3635] Add Locality Awareness documentation
Ethanlm opened a new pull request #3331:
URL: https://github.com/apache/storm/pull/3331
## What is the purpose of the change
Rework https://github.com/apache/storm/pull/3268
Add doc for locality awareness
## How was the change tested
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] agresch commented on a change in pull request #3331: [STORM-3635] Add Locality Awareness documentation
Posted by GitBox <gi...@apache.org>.
agresch commented on a change in pull request #3331:
URL: https://github.com/apache/storm/pull/3331#discussion_r487141946
##########
File path: docs/LocalityAwareness.md
##########
@@ -0,0 +1,84 @@
+---
+title: Locality Awareness In LoadAwareShuffleGrouping
+layout: documentation
+documentation: true
+---
+
+# Locality Awareness In LoadAwareShuffleGrouping
+
+### Motivation
+
+Apache Storm 2.0 introduced locality awareness to LoadAwareShuffleGrouping based on Bang-Bang control theory.
Review comment:
I would prefer to change to "Storm has introduced" or something instead? As time goes by, this version becomes irrelevant. I think it's understood that not all features are available in older Storm versions. I'm ok with it if you think it's necessary though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] agresch commented on a change in pull request #3331: [STORM-3635] Add Locality Awareness documentation
Posted by GitBox <gi...@apache.org>.
agresch commented on a change in pull request #3331:
URL: https://github.com/apache/storm/pull/3331#discussion_r487141946
##########
File path: docs/LocalityAwareness.md
##########
@@ -0,0 +1,84 @@
+---
+title: Locality Awareness In LoadAwareShuffleGrouping
+layout: documentation
+documentation: true
+---
+
+# Locality Awareness In LoadAwareShuffleGrouping
+
+### Motivation
+
+Apache Storm 2.0 introduced locality awareness to LoadAwareShuffleGrouping based on Bang-Bang control theory.
Review comment:
I would prefer to change to "Storm has introduced" or something instead? As time goes by, this version becomes irrelevant. I think it's understood that not all features are available in older Storm versions. I'm ok with it if you think it's necessary though.
##########
File path: docs/LocalityAwareness.md
##########
@@ -0,0 +1,84 @@
+---
+title: Locality Awareness In LoadAwareShuffleGrouping
+layout: documentation
+documentation: true
+---
+
+# Locality Awareness In LoadAwareShuffleGrouping
+
+### Motivation
+
+Apache Storm 2.0 introduced locality awareness to LoadAwareShuffleGrouping based on Bang-Bang control theory.
Review comment:
I would prefer to change to "Storm has introduced" or something instead? As time goes by, this version becomes irrelevant. I think it's understood that not all features are available in older Storm versions. I'm ok with it if you think it's necessary though.
##########
File path: docs/LocalityAwareness.md
##########
@@ -0,0 +1,84 @@
+---
+title: Locality Awareness In LoadAwareShuffleGrouping
+layout: documentation
+documentation: true
+---
+
+# Locality Awareness In LoadAwareShuffleGrouping
+
+### Motivation
+
+Apache Storm 2.0 introduced locality awareness to LoadAwareShuffleGrouping based on Bang-Bang control theory.
Review comment:
I would prefer to change to "Storm has introduced" or something instead? As time goes by, this version becomes irrelevant. I think it's understood that not all features are available in older Storm versions. I'm ok with it if you think it's necessary though.
##########
File path: docs/LocalityAwareness.md
##########
@@ -0,0 +1,84 @@
+---
+title: Locality Awareness In LoadAwareShuffleGrouping
+layout: documentation
+documentation: true
+---
+
+# Locality Awareness In LoadAwareShuffleGrouping
+
+### Motivation
+
+Apache Storm 2.0 introduced locality awareness to LoadAwareShuffleGrouping based on Bang-Bang control theory.
Review comment:
I would prefer to change to "Storm has introduced" or something instead? As time goes by, this version becomes irrelevant. I think it's understood that not all features are available in older Storm versions. I'm ok with it if you think it's necessary though.
##########
File path: docs/LocalityAwareness.md
##########
@@ -0,0 +1,84 @@
+---
+title: Locality Awareness In LoadAwareShuffleGrouping
+layout: documentation
+documentation: true
+---
+
+# Locality Awareness In LoadAwareShuffleGrouping
+
+### Motivation
+
+Apache Storm 2.0 introduced locality awareness to LoadAwareShuffleGrouping based on Bang-Bang control theory.
Review comment:
I would prefer to change to "Storm has introduced" or something instead? As time goes by, this version becomes irrelevant. I think it's understood that not all features are available in older Storm versions. I'm ok with it if you think it's necessary though.
##########
File path: docs/LocalityAwareness.md
##########
@@ -0,0 +1,84 @@
+---
+title: Locality Awareness In LoadAwareShuffleGrouping
+layout: documentation
+documentation: true
+---
+
+# Locality Awareness In LoadAwareShuffleGrouping
+
+### Motivation
+
+Apache Storm 2.0 introduced locality awareness to LoadAwareShuffleGrouping based on Bang-Bang control theory.
Review comment:
I would prefer to change to "Storm has introduced" or something instead? As time goes by, this version becomes irrelevant. I think it's understood that not all features are available in older Storm versions. I'm ok with it if you think it's necessary though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm merged pull request #3331: [STORM-3635] Add Locality Awareness documentation
Posted by GitBox <gi...@apache.org>.
Ethanlm merged pull request #3331:
URL: https://github.com/apache/storm/pull/3331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] agresch commented on a change in pull request #3331: [STORM-3635] Add Locality Awareness documentation
Posted by GitBox <gi...@apache.org>.
agresch commented on a change in pull request #3331:
URL: https://github.com/apache/storm/pull/3331#discussion_r487141946
##########
File path: docs/LocalityAwareness.md
##########
@@ -0,0 +1,84 @@
+---
+title: Locality Awareness In LoadAwareShuffleGrouping
+layout: documentation
+documentation: true
+---
+
+# Locality Awareness In LoadAwareShuffleGrouping
+
+### Motivation
+
+Apache Storm 2.0 introduced locality awareness to LoadAwareShuffleGrouping based on Bang-Bang control theory.
Review comment:
I would prefer to change to "Storm has introduced" or something instead? As time goes by, this version becomes irrelevant. I think it's understood that not all features are available in older Storm versions. I'm ok with it if you think it's necessary though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] agresch commented on a change in pull request #3331: [STORM-3635] Add Locality Awareness documentation
Posted by GitBox <gi...@apache.org>.
agresch commented on a change in pull request #3331:
URL: https://github.com/apache/storm/pull/3331#discussion_r487141946
##########
File path: docs/LocalityAwareness.md
##########
@@ -0,0 +1,84 @@
+---
+title: Locality Awareness In LoadAwareShuffleGrouping
+layout: documentation
+documentation: true
+---
+
+# Locality Awareness In LoadAwareShuffleGrouping
+
+### Motivation
+
+Apache Storm 2.0 introduced locality awareness to LoadAwareShuffleGrouping based on Bang-Bang control theory.
Review comment:
I would prefer to change to "Storm has introduced" or something instead? As time goes by, this version becomes irrelevant. I think it's understood that not all features are available in older Storm versions. I'm ok with it if you think it's necessary though.
##########
File path: docs/LocalityAwareness.md
##########
@@ -0,0 +1,84 @@
+---
+title: Locality Awareness In LoadAwareShuffleGrouping
+layout: documentation
+documentation: true
+---
+
+# Locality Awareness In LoadAwareShuffleGrouping
+
+### Motivation
+
+Apache Storm 2.0 introduced locality awareness to LoadAwareShuffleGrouping based on Bang-Bang control theory.
Review comment:
I would prefer to change to "Storm has introduced" or something instead? As time goes by, this version becomes irrelevant. I think it's understood that not all features are available in older Storm versions. I'm ok with it if you think it's necessary though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org