[jira] [Commented] (MESOS-79) Python external test doesn't actually test that framework finished cleanly

["jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149013#comment-13149013 ] 

jiraposter@reviews.apache.org commented on MESOS-79:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2816/
-----------------------------------------------------------

Review request for mesos.


Summary
-------

Calls sys.exit() with the result of SchedulerDriver.run() rather than ignoring the return value. Relies on 0 being the 'OK' status code.


This addresses bug MESOS-79.
    https://issues.apache.org/jira/browse/MESOS-79


Diffs
-----

  src/examples/python/test_framework.py 0e4b14c 

Diff: https://reviews.apache.org/r/2816/diff


Testing
-------


Thanks,

Charles


                
> Python external test doesn't actually test that framework finished cleanly
> --------------------------------------------------------------------------
>
>                 Key: MESOS-79
>                 URL: https://issues.apache.org/jira/browse/MESOS-79
>             Project: Mesos
>          Issue Type: Bug
>          Components: python-api, test
>            Reporter: Charles Reiss
>            Priority: Trivial
>              Labels: python
>
> The Python example framework doesn't check the status returned by SchedulerDriver.run(), so if, for example, the framework is aborted, it will exit normally. The PythonFramework external test will interpret this normal exit as success when it should be a failure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira