You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/23 09:57:58 UTC

[GitHub] dawidwys opened a new pull request #7566: [FLINK-11328][core] Migrate NFAStateSerializer to new TypeSerializer interface

dawidwys opened a new pull request #7566: [FLINK-11328][core] Migrate NFAStateSerializer to new TypeSerializer interface
URL: https://github.com/apache/flink/pull/7566
 
 
   ## What is the purpose of the change
   
   This PR adds `NFAStateSerializerSnapshot` corresponding to `NFAStateSerializer`. 
   
   
   ## Brief change log
   
     - fa99e09 - this is a small fix that closes nfa in `CepOperator` only if it was not null, this can happen only in a case of failure, this effectively improves error message, which is not overwritten by NPE
     - a3c6b6f - no functional changes. Just splits methods in `NFAStateSerializer` into smaller ones
     - ae1f04b - introduces `NFAStateSerializerSnapshot`
   
   
   ## Verifying this change
   
   - test in `CepMigrationTest` should still pass
   - added test specification in `org.apache.flink.cep.NFASerializerSnapshotsMigrationTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (**yes** / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes **/ no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services