You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/11 06:32:21 UTC
[GitHub] [spark] packyan opened a new pull request, #39021: Last metrics system report should have a timeout, avoid to lead shutd…
packyan opened a new pull request, #39021:
URL: https://github.com/apache/spark/pull/39021
…own hook timeout.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In the stop method of SparkContext, a timeout limit is added to metricsSystem#report. When it is not completed for more than 1s, continue with the subsequent steps.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When the user does not explicitly call the stop method of SparkContext, the stop will be executed by ShutdownHook, and the Hadoop shutdown hookmanager used by Spark needs to complete the hook entry within 10s, so when the metricsSystem takes a long time to complete the report (for example, the sink occurs time out), other hooks may be blocked and cannot be executed successfully.
For example, the unregister operation in ApplicationMaster may fail to execute because the metrics report costs too much time, so the Spark job has been successfully completed, but Yarn still considers it a failed job.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
test manually, due to the difficulty of constructing the timeout execution of metrics#report. Unit test want help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a diff in pull request #39021: [SPARK-41483][CORE] Last metrics system report should have a timeout, avoid to lead shutdown hook timeout
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on code in PR #39021:
URL: https://github.com/apache/spark/pull/39021#discussion_r1045564398
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2136,7 +2138,10 @@ class SparkContext(config: SparkConf) extends Logging {
}
if (env != null) {
Utils.tryLogNonFatalError {
- env.metricsSystem.report()
+ val metricsReportFuture = Future {
+ env.metricsSystem.report()
+ } (SparkContext.executionContext)
+ ThreadUtils.awaitResult(metricsReportFuture, Duration.create("1s"))
Review Comment:
1s seems to be a bit aggressive. How long would it take normally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39021: Last metrics system report should have a timeout, avoid to lead shutdown hook timeout
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39021:
URL: https://github.com/apache/spark/pull/39021#issuecomment-1345751613
@packyan mind creating a JIRA and linking it to PR title? See also https://spark.apache.org/contributing.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] packyan commented on a diff in pull request #39021: [SPARK-41483][CORE] Last metrics system report should have a timeout, avoid to lead shutdown hook timeout
Posted by GitBox <gi...@apache.org>.
packyan commented on code in PR #39021:
URL: https://github.com/apache/spark/pull/39021#discussion_r1045598309
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2136,7 +2138,10 @@ class SparkContext(config: SparkConf) extends Logging {
}
if (env != null) {
Utils.tryLogNonFatalError {
- env.metricsSystem.report()
+ val metricsReportFuture = Future {
+ env.metricsSystem.report()
+ } (SparkContext.executionContext)
+ ThreadUtils.awaitResult(metricsReportFuture, Duration.create("1s"))
Review Comment:
I think 1 to 2 seconds is reasonable. The last metrics report is not necessary, we must reserve enough time for the application master hook to unregister and clean up temporary files.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #39021: [SPARK-41483][CORE] Last metrics system report should have a timeout, avoid to lead shutdown hook timeout
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #39021:
URL: https://github.com/apache/spark/pull/39021#issuecomment-1346863575
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] packyan commented on pull request #39021: [SPARK-41483] Last metrics system report should have a timeout, avoid to lead shutdown hook timeout
Posted by GitBox <gi...@apache.org>.
packyan commented on PR #39021:
URL: https://github.com/apache/spark/pull/39021#issuecomment-1345823687
> @packyan mind creating a JIRA and linking it to PR title? See also https://spark.apache.org/contributing.html
Sorry, I will do it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #39021: [SPARK-41483][CORE] Last metrics system report should have a timeout, avoid to lead shutdown hook timeout
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #39021: [SPARK-41483][CORE] Last metrics system report should have a timeout, avoid to lead shutdown hook timeout
URL: https://github.com/apache/spark/pull/39021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] packyan commented on pull request #39021: [SPARK-41483][CORE] Last metrics system report should have a timeout, avoid to lead shutdown hook timeout
Posted by GitBox <gi...@apache.org>.
packyan commented on PR #39021:
URL: https://github.com/apache/spark/pull/39021#issuecomment-1366356581
Any one can give me some suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #39021: [SPARK-41483][CORE] Last metrics system report should have a timeout, avoid to lead shutdown hook timeout
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39021:
URL: https://github.com/apache/spark/pull/39021#issuecomment-1500737503
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org