You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/27 04:32:38 UTC
[GitHub] [spark] beliefer opened a new pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Support ANSI SQL intervals by the aggregate function avg
beliefer opened a new pull request #32358:
URL: https://github.com/apache/spark/pull/32358
### What changes were proposed in this pull request?
https://github.com/apache/spark/pull/32229 support ANSI SQL intervals by the aggregate function `avg`.
But have not treat that the input zero rows. so this will lead to:
```
Caused by: java.lang.ArithmeticException: / by zero
at com.google.common.math.LongMath.divide(LongMath.java:367)
at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage2.processNext(Unknown Source)
at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:759)
at scala.collection.Iterator$$anon$10.hasNext(Iterator.scala:458)
at scala.collection.Iterator$$anon$10.hasNext(Iterator.scala:458)
at org.apache.spark.util.Utils$.getIteratorSize(Utils.scala:1864)
at org.apache.spark.rdd.RDD.$anonfun$count$1(RDD.scala:1253)
at org.apache.spark.rdd.RDD.$anonfun$count$1$adapted(RDD.scala:1253)
at org.apache.spark.SparkContext.$anonfun$runJob$5(SparkContext.scala:2248)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
at org.apache.spark.scheduler.Task.run(Task.scala:131)
at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:498)
at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1437)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:501)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
### Why are the changes needed?
Fix a bug.
### Does this PR introduce _any_ user-facing change?
No. Just new feature.
### How was this patch tested?
new tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Fix division by zero in the avg function over ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32358:
URL: https://github.com/apache/spark/pull/32358#issuecomment-827497986
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137983/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Fix division by zero in the avg function over ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32358:
URL: https://github.com/apache/spark/pull/32358#issuecomment-827348069
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42503/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Support ANSI SQL intervals by the aggregate function avg
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32358:
URL: https://github.com/apache/spark/pull/32358#issuecomment-827306180
**[Test build #137983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137983/testReport)** for PR 32358 at commit [`02d8282`](https://github.com/apache/spark/commit/02d82823f86117ff6c8399a1d653283a669482ea).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Fix division by zero in the avg function over ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #32358:
URL: https://github.com/apache/spark/pull/32358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Fix division by zero in the avg function over ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32358:
URL: https://github.com/apache/spark/pull/32358#issuecomment-827306180
**[Test build #137983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137983/testReport)** for PR 32358 at commit [`02d8282`](https://github.com/apache/spark/commit/02d82823f86117ff6c8399a1d653283a669482ea).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Fix division by zero in the avg function over ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32358:
URL: https://github.com/apache/spark/pull/32358#issuecomment-827333068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Fix division by zero in the avg function over ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32358:
URL: https://github.com/apache/spark/pull/32358#issuecomment-827483821
**[Test build #137983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137983/testReport)** for PR 32358 at commit [`02d8282`](https://github.com/apache/spark/commit/02d82823f86117ff6c8399a1d653283a669482ea).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Fix division by zero in the avg function over ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32358:
URL: https://github.com/apache/spark/pull/32358#issuecomment-827497986
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137983/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Fix division by zero in the avg function over ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32358:
URL: https://github.com/apache/spark/pull/32358#issuecomment-827395997
+1, LGTM. Merging to master.
Thank you, @beliefer .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Fix division by zero in the avg function over ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32358:
URL: https://github.com/apache/spark/pull/32358#issuecomment-827348069
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42503/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #32358: [SPARK-34837][SQL][FOLLOWUP] Fix division by zero in the avg function over ANSI intervals
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #32358:
URL: https://github.com/apache/spark/pull/32358#issuecomment-827485444
@MaxGekk Thanks for you review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org