[GitHub] [qpid-proton] pjfawcett commented on a change in pull request #293: PROTON-2330-cpp-link-properties

[GitBox <gi...@apache.org>]

pjfawcett commented on a change in pull request #293:
URL: https://github.com/apache/qpid-proton/pull/293#discussion_r573738559



##########
File path: cpp/src/link_test.cpp
##########
@@ -45,8 +55,107 @@ int test_link_name()
     return 0;
 }
 
+/*
+ * Want to test remote properties so need to run a container and make loopback links.
+ * Basing these classes on those used in container_test.cpp but reducing the checks on
+ * container logic as that is not the subject of these tests.
+ */

Review comment:
       @astitcher are you happy with the updated tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org