You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kamesh Jayachandran <ka...@collab.net> on 2009/10/09 14:13:05 UTC
[PATCH] Provide meaningful message when svn update is run against
an out of date mirror.
Hi All,
In Web dav write through proxy setups following situation is common.
1. svn co http://mirror/svn/repo/trunk
2. cd trunk
3. modify test.c(assuming one such file exists)
4. svn ci -m "log message"
5. svn up #This has a very high chance of triggering the vague error of
some working copy item having a rev > HEAD of mirror
The attached patch fixes it.
If there are no objections I will commit the same in a day or two.
With regards
Kamesh Jayachandran
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405550
RE: [PATCH] Provide meaningful message when svn update is run
against an out of date mirror.
Posted by Kamesh Jayachandran <ka...@collab.net>.
>I'm not fond at all of the idea of having code that is completely ignorant
>of the fact that a proxy is or isn't in place (like mod_dav_svn's update
>logic) generating errors that refer to mirrors.
I agree with you may be it can refer for the existence of the SVNMasterURI directive and and trigger this error?
What do you think?
>A more appropriate approach would be for the mirror.c code (which is the
>only code that really knows that some proxying is going on) to detect the
>generic error and replace it with a more specific one in the returned
>stream. That's probably quite a bit more work to achieve, but I believe it
>is far more correct that what you are proposing.
IIUC 'svn update' does not exercise the mirror code!
With regards
Kamesh Jayachandran
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405638
Re: [PATCH] Provide meaningful message when svn update is run
against an out of date mirror.
Posted by "C. Michael Pilato" <cm...@collab.net>.
Kamesh Jayachandran wrote:
> Hi All,
>
> In Web dav write through proxy setups following situation is common.
>
> 1. svn co http://mirror/svn/repo/trunk
> 2. cd trunk
> 3. modify test.c(assuming one such file exists)
> 4. svn ci -m "log message"
> 5. svn up #This has a very high chance of triggering the vague error of
> some working copy item having a rev > HEAD of mirror
>
> The attached patch fixes it.
>
> If there are no objections I will commit the same in a day or two.
I'm not fond at all of the idea of having code that is completely ignorant
of the fact that a proxy is or isn't in place (like mod_dav_svn's update
logic) generating errors that refer to mirrors.
A more appropriate approach would be for the mirror.c code (which is the
only code that really knows that some proxying is going on) to detect the
generic error and replace it with a more specific one in the returned
stream. That's probably quite a bit more work to achieve, but I believe it
is far more correct that what you are proposing.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405610