You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/24 21:24:41 UTC
[jira] [Commented] (ARTEMIS-1069) AMQP: Thread unsafe proton usage
found
[ https://issues.apache.org/jira/browse/ARTEMIS-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941162#comment-15941162 ]
ASF GitHub Bot commented on ARTEMIS-1069:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1132
ARTEMIS-1069 Fix some thread unsafe usages of proton
Unsafe modification of proton resources outside the connection lock
could lead to corruption in the transport work list and other internal
state data.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1069
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1132
----
commit 498b5df5ba22ccfbd556817c0e52ce29d6deb90e
Author: Timothy Bish <ta...@gmail.com>
Date: 2017-03-24T21:22:14Z
ARTEMIS-1069 Fix some thread unsafe usages of proton
Unsafe modification of proton resources outside the connection lock
could lead to corruption in the transport work list and other internal
state data.
----
> AMQP: Thread unsafe proton usage found
> --------------------------------------
>
> Key: ARTEMIS-1069
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1069
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.0.0
> Reporter: Timothy Bish
> Fix For: 2.next
>
>
> Found a few cases in the AMQP handlers where proton objects are used outside the connection lock where the usage can cause updates to the Transport work list which if happens concurrently can break the state of the work list.
> Also found one case where a the code if offering credit to a sender which is not necessary as the sender credit is determined by the remote receiver flowing credit to it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)