You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/11 01:51:48 UTC

[GitHub] [netbeans] lkishalmi opened a new pull request #2672: [NETBEANS-4693] new nb-javac with records in maven projects fix

lkishalmi opened a new pull request #2672:
URL: https://github.com/apache/netbeans/pull/2672


   I'm a bit unsure in this. Theoretically NB 12.0 comes with Java 14 Support, so it'd make sense.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #2672: [NETBEANS-4693] new nb-javac with records in maven projects fix

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #2672:
URL: https://github.com/apache/netbeans/pull/2672#issuecomment-1020811946


   are update releases for NB 12 still going to happen? If not we can probably close this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #2672: [NETBEANS-4693] new nb-javac with records in maven projects fix

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #2672:
URL: https://github.com/apache/netbeans/pull/2672#issuecomment-1020811946


   are update releases for NB 12 still going to happen? If not we can probably close this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] geertjanw commented on pull request #2672: [NETBEANS-4693] new nb-javac with records in maven projects fix

Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2672:
URL: https://github.com/apache/netbeans/pull/2672#issuecomment-757631724


   Yes, this would be good for the reason Laszlo mentions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] geertjanw commented on pull request #2672: [NETBEANS-4693] new nb-javac with records in maven projects fix

Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2672:
URL: https://github.com/apache/netbeans/pull/2672#issuecomment-758157561


   I would revert my support for this one then in light of @matthiasblaesing's comment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on pull request #2672: [NETBEANS-4693] new nb-javac with records in maven projects fix

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2672:
URL: https://github.com/apache/netbeans/pull/2672#issuecomment-758126984


   If I remember nb-javac introduced regressions (Exception in normal operation, syntax requirements for Java 14 applied to older code), so I'm reluctant to cheer this in.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi commented on pull request #2672: [NETBEANS-4693] new nb-javac with records in maven projects fix

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2672:
URL: https://github.com/apache/netbeans/pull/2672#issuecomment-757669705


   Something is still missing from this PR. If it should be in 12.0-u2 Then I need help!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi commented on pull request #2672: [NETBEANS-4693] new nb-javac with records in maven projects fix

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2672:
URL: https://github.com/apache/netbeans/pull/2672#issuecomment-762587874


   Well, I've tested this PR. Seems to be right, though it needs some work on the specification versions. Finally I've decided not to include it into the 12.0-u2 rather add for u3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists