You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/05/12 22:43:08 UTC
Review Request 59248: Fixed a fd-related build on Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59248/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Joseph Wu.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/check_tests.cpp f8bb1d3e971e91e7c3de49e86dc6ed6b2b63edc4
Diff: https://reviews.apache.org/r/59248/diff/1/
Testing
-------
Thanks,
Alexander Rukletsov
Re: Review Request 59248: Fixed a fd-related build on Windows.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On May 12, 2017, 11:10 p.m., Jeff Coffler wrote:
> > src/tests/check_tests.cpp
> > Line 1890 (original), 1890 (patched)
> > <https://reviews.apache.org/r/59248/diff/1/?file=1717211#file1717211line1890>
> >
> > You need a similar change on line 1893. Other than that, this works fine.
Thanks. Fixed while committing.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59248/#review174865
-----------------------------------------------------------
On May 12, 2017, 10:43 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59248/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 10:43 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/check_tests.cpp f8bb1d3e971e91e7c3de49e86dc6ed6b2b63edc4
>
>
> Diff: https://reviews.apache.org/r/59248/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59248: Fixed a fd-related build on Windows.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59248/#review174865
-----------------------------------------------------------
src/tests/check_tests.cpp
Line 1890 (original), 1890 (patched)
<https://reviews.apache.org/r/59248/#comment248081>
You need a similar change on line 1893. Other than that, this works fine.
- Jeff Coffler
On May 12, 2017, 10:43 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59248/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 10:43 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/check_tests.cpp f8bb1d3e971e91e7c3de49e86dc6ed6b2b63edc4
>
>
> Diff: https://reviews.apache.org/r/59248/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59248: Fixed a fd-related build on Windows.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59248/
-----------------------------------------------------------
(Updated May 12, 2017, 11:13 p.m.)
Review request for mesos, Gastón Kleiman and Joseph Wu.
Bugs: MESOS-7502
https://issues.apache.org/jira/browse/MESOS-7502
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/check_tests.cpp f8bb1d3e971e91e7c3de49e86dc6ed6b2b63edc4
Diff: https://reviews.apache.org/r/59248/diff/1/
Testing (updated)
-------
Build on Windows.
Thanks,
Alexander Rukletsov