You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Steven Phillips <sp...@maprtech.com> on 2015/02/02 20:38:08 UTC
Re: Review Request 30305: Add IO wait time stats for Parquet and Json
input files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30305/#review70608
-----------------------------------------------------------
Ship it!
Ship It!
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
<https://reviews.apache.org/r/30305/#comment115829>
remove
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
<https://reviews.apache.org/r/30305/#comment115831>
remove
- Steven Phillips
On Jan. 27, 2015, 4:06 a.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30305/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 4:06 a.m.)
>
>
> Review request for drill, Jacques Nadeau and Steven Phillips.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> See DRILL-2080 for details.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillFile.java 009cd00
> exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillUtil.java 63b22e9
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java d68a5b5
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFileHandler.java ff3542d
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/BasicFormatMatcher.java 2ba2910
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/DrillFSDataInputStream.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/DrillFileSystem.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java cf8937f
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java db6c0c7
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FormatCreator.java e5c0487
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FormatPlugin.java 27f83f0
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java 7b9d52c
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java 9cc1808
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java b505535
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/shim/DrillFileSystem.java d3f9134
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/shim/DrillInputStream.java 8c3b5ae
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/shim/DrillOutputStream.java 8e56232
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/shim/FileSystemCreator.java a5ad257
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/shim/fallback/FallbackFileSystem.java 959529a
> exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java d41243d
> exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java 0070d18
> exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java b64a032
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java 109033a
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java 8ddf5fd
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java dc1d892
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java 25f383f
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/local/FilePStore.java 40f25e7
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/local/LocalPStoreProvider.java ac53a61
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/zk/ZkPStore.java a597381
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/zk/ZkPStoreProvider.java f8fa2bc
> exec/java-exec/src/test/java/org/apache/drill/exec/store/dfs/TestDrillFileSystem.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30305/diff/
>
>
> Testing
> -------
>
> Added a unittest for DrillFileSystem. Need to add couple of tests that involve querying actual JSON/Parquet files. Will add those in next patch.
>
>
> Thanks,
>
> Venki Korukanti
>
>