You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/22 07:58:07 UTC

[GitHub] [spark] sigmod commented on a change in pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats

sigmod commented on a change in pull request #32290:
URL: https://github.com/apache/spark/pull/32290#discussion_r618169819



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -506,6 +506,18 @@ class ExplainSuite extends ExplainSuiteHelper with DisableAdaptiveExecutionSuite
       checkKeywordsExistsInExplain(df2, keywords = "[key1=value1, KEY2=VALUE2]")
     }
   }
+
+  test("SPARK-35183: CombineConcats should call transformAllExpressions") {

Review comment:
       Done. Reverted. 
   
   (The explain test was copied and modified from another [one](https://github.com/apache/spark/blob/f208d808819dae38739fa9acda9510a4b9763dde/sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala#L151-L159) testing the original rule.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org