You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2012/02/09 09:42:55 UTC
svn commit: r1242237 - in
/commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java
MeasurementModel.java ProcessModel.java
Author: tn
Date: Thu Feb 9 08:42:54 2012
New Revision: 1242237
URL: http://svn.apache.org/viewvc?rev=1242237&view=rev
Log:
Added missing svn:keywords prop for filter package.
Modified:
commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultMeasurementModel.java (props changed)
commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java (props changed)
commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java (props changed)
commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java (props changed)
commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java (props changed)
Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultMeasurementModel.java
------------------------------------------------------------------------------
svn:keywords = Id
Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java
------------------------------------------------------------------------------
svn:keywords = Id
Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java
------------------------------------------------------------------------------
svn:keywords = Id
Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java
------------------------------------------------------------------------------
svn:keywords = Id
Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java
------------------------------------------------------------------------------
svn:keywords = Id
Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java
MeasurementModel.java ProcessModel.java
Posted by Konstantin Kolinko <kn...@gmail.com>.
2012/2/9 sebb <se...@gmail.com>:
> On 9 February 2012 16:01, Thomas Neidhart <th...@gmail.com> wrote:
>> On 02/09/2012 03:46 PM, sebb wrote:
>>
>>> Both Id and Revision are fine, and can both be useful.
>>>
>>> There's no harm in having the keywords set - it's only a problem if
>>> they are *used*.
>>> But having them set might encourage their use.
>>
>> Ok, makes sense to not set the other keywords just in case. Btw.
>>
>> Actually, I have taken the default settings from here:
>>
>> http://wiki.apache.org/commons/UsingSVN
>
> Did not know about that; fixed.
>
Note that there exists official
http://www.apache.org/dev/svn-eol-style.txt
>> Maybe we should add a section in the developers guide for the math
>> component:
>>
>> http://commons.apache.org/math/developers.html
>
> Or update the Commons guidelines (if any)?
>
>> A short statistic on the source files in src/main/java:
>>
>> 61 "Author Date Id Revision"
>
> That's a bug - the quotes will be treated as part of the keyword, so
> (e.g.) Revision won't work.
>
>> 429 Author Date Id Revision
>> 2 Date Revision
>> 7 Date Revision Id
>>
>> 121 file do not have keywords set yet.
>From practical point of view (I cannot say anything about policies)
the svn:keywords property is needed only if those keywords are
actually used in those files.
The "Author Date Id Revision" value (without quotes) should have
brought in by CVS->SVN migration.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java
MeasurementModel.java ProcessModel.java
Posted by sebb <se...@gmail.com>.
On 9 February 2012 16:01, Thomas Neidhart <th...@gmail.com> wrote:
> On 02/09/2012 03:46 PM, sebb wrote:
>
>> Both Id and Revision are fine, and can both be useful.
>>
>> There's no harm in having the keywords set - it's only a problem if
>> they are *used*.
>> But having them set might encourage their use.
>
> Ok, makes sense to not set the other keywords just in case. Btw.
>
> Actually, I have taken the default settings from here:
>
> http://wiki.apache.org/commons/UsingSVN
Did not know about that; fixed.
> Maybe we should add a section in the developers guide for the math
> component:
>
> http://commons.apache.org/math/developers.html
Or update the Commons guidelines (if any)?
> A short statistic on the source files in src/main/java:
>
> 61 "Author Date Id Revision"
That's a bug - the quotes will be treated as part of the keyword, so
(e.g.) Revision won't work.
> 429 Author Date Id Revision
> 2 Date Revision
> 7 Date Revision Id
>
> 121 file do not have keywords set yet.
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java MeasurementModel.java
ProcessModel.java
Posted by Thomas Neidhart <th...@gmail.com>.
On 02/09/2012 03:46 PM, sebb wrote:
> Both Id and Revision are fine, and can both be useful.
>
> There's no harm in having the keywords set - it's only a problem if
> they are *used*.
> But having them set might encourage their use.
Ok, makes sense to not set the other keywords just in case. Btw.
Actually, I have taken the default settings from here:
http://wiki.apache.org/commons/UsingSVN
Maybe we should add a section in the developers guide for the math
component:
http://commons.apache.org/math/developers.html
A short statistic on the source files in src/main/java:
61 "Author Date Id Revision"
429 Author Date Id Revision
2 Date Revision
7 Date Revision Id
121 file do not have keywords set yet.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java
MeasurementModel.java ProcessModel.java
Posted by sebb <se...@gmail.com>.
On 9 February 2012 15:00, Gilles Sadowski <gi...@harfang.homelinux.org> wrote:
> On Thu, Feb 09, 2012 at 02:46:26PM +0000, sebb wrote:
>> 2012/2/9 Sébastien Brisard <se...@m4x.org>:
>> > 2012/2/9 sebb <se...@gmail.com>:
>> >> 2012/2/9 Sébastien Brisard <se...@m4x.org>:
>> >>> Hi,
>> >>>
>> >>>>
>> >>>> svn:keywords = Id
>> >>>>
>> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java
>> >>>> ------------------------------------------------------------------------------
>> >>>> svn:keywords = Id
>> >>>>
>> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java
>> >>>> ------------------------------------------------------------------------------
>> >>>> svn:keywords = Id
>> >>>>
>> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java
>> >>>> ------------------------------------------------------------------------------
>> >>>> svn:keywords = Id
>> >>>>
>> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java
>> >>>> ------------------------------------------------------------------------------
>> >>>> svn:keywords = Id
>> >>>>
>> >>>>
>> >>>
>> >>> I think the property should read
>> >>> Author Date Id Revision
>> >>
>> >> Please don't use Date - it is locale-dependent and causes SVN tags to
>> >> disagree with source archives.
>> >>
>> >> Also @Author tags are strongly discouraged.
>> >> We use changes.xml and contributors in the POM instead.
>> >>
>> > OK, my mistake.
>> > I was conforming with what I saw in existing files. So should the
>> > svn:keywords property read "Id", or "Id Revision"?
>>
>> Both Id and Revision are fine, and can both be useful.
>>
>> There's no harm in having the keywords set - it's only a problem if
>> they are *used*.
>> But having them set might encourage their use.
>
> I think that we decided to stick with $Id$ only since it also contains the
> revision number.
It does, but sometimes (often ?) the revision number will be sufficient.
What's important is to avoid the properties that cause problems.
$Date is bad because it is locale-dependent; $Id offers a way round this.
> Regards,
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java
MeasurementModel.java ProcessModel.java
Posted by Sébastien Brisard <se...@m4x.org>.
>
> I think that we decided to stick with $Id$ only since it also contains the
> revision number.
>
> Regards,
> Gilles
>
OK, I do apologize for that. I'll keep it in mind in the future.
Sébastien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java MeasurementModel.java
ProcessModel.java
Posted by Luc Maisonobe <Lu...@free.fr>.
Hi,
Le 09/02/2012 16:00, Gilles Sadowski a écrit :
> On Thu, Feb 09, 2012 at 02:46:26PM +0000, sebb wrote:
>> 2012/2/9 Sébastien Brisard <se...@m4x.org>:
>>> 2012/2/9 sebb <se...@gmail.com>:
>>>> 2012/2/9 Sébastien Brisard <se...@m4x.org>:
>>>>> Hi,
>>>>>
>>>>>>
>>>>>> svn:keywords = Id
>>>>>>
>>>>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java
>>>>>> ------------------------------------------------------------------------------
>>>>>> svn:keywords = Id
>>>>>>
>>>>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java
>>>>>> ------------------------------------------------------------------------------
>>>>>> svn:keywords = Id
>>>>>>
>>>>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java
>>>>>> ------------------------------------------------------------------------------
>>>>>> svn:keywords = Id
>>>>>>
>>>>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java
>>>>>> ------------------------------------------------------------------------------
>>>>>> svn:keywords = Id
>>>>>>
>>>>>>
>>>>>
>>>>> I think the property should read
>>>>> Author Date Id Revision
>>>>
>>>> Please don't use Date - it is locale-dependent and causes SVN tags to
>>>> disagree with source archives.
>>>>
>>>> Also @Author tags are strongly discouraged.
>>>> We use changes.xml and contributors in the POM instead.
>>>>
>>> OK, my mistake.
>>> I was conforming with what I saw in existing files. So should the
>>> svn:keywords property read "Id", or "Id Revision"?
>>
>> Both Id and Revision are fine, and can both be useful.
>>
>> There's no harm in having the keywords set - it's only a problem if
>> they are *used*.
>> But having them set might encourage their use.
>
> I think that we decided to stick with $Id$ only since it also contains the
> revision number.
Yes, the change was done some times ago. We did forget to remove the
properties and as Sebb write, they encourage the use of these keywords.
We should probably remove theses properties for existing files.
best regards,
Luc
>
> Regards,
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1242237 - in
/commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java
MeasurementModel.java ProcessModel.java
Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
On Thu, Feb 09, 2012 at 02:46:26PM +0000, sebb wrote:
> 2012/2/9 Sébastien Brisard <se...@m4x.org>:
> > 2012/2/9 sebb <se...@gmail.com>:
> >> 2012/2/9 Sébastien Brisard <se...@m4x.org>:
> >>> Hi,
> >>>
> >>>>
> >>>> svn:keywords = Id
> >>>>
> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java
> >>>> ------------------------------------------------------------------------------
> >>>> svn:keywords = Id
> >>>>
> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java
> >>>> ------------------------------------------------------------------------------
> >>>> svn:keywords = Id
> >>>>
> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java
> >>>> ------------------------------------------------------------------------------
> >>>> svn:keywords = Id
> >>>>
> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java
> >>>> ------------------------------------------------------------------------------
> >>>> svn:keywords = Id
> >>>>
> >>>>
> >>>
> >>> I think the property should read
> >>> Author Date Id Revision
> >>
> >> Please don't use Date - it is locale-dependent and causes SVN tags to
> >> disagree with source archives.
> >>
> >> Also @Author tags are strongly discouraged.
> >> We use changes.xml and contributors in the POM instead.
> >>
> > OK, my mistake.
> > I was conforming with what I saw in existing files. So should the
> > svn:keywords property read "Id", or "Id Revision"?
>
> Both Id and Revision are fine, and can both be useful.
>
> There's no harm in having the keywords set - it's only a problem if
> they are *used*.
> But having them set might encourage their use.
I think that we decided to stick with $Id$ only since it also contains the
revision number.
Regards,
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java
MeasurementModel.java ProcessModel.java
Posted by sebb <se...@gmail.com>.
2012/2/9 Sébastien Brisard <se...@m4x.org>:
> 2012/2/9 sebb <se...@gmail.com>:
>> 2012/2/9 Sébastien Brisard <se...@m4x.org>:
>>> Hi,
>>>
>>>>
>>>> svn:keywords = Id
>>>>
>>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java
>>>> ------------------------------------------------------------------------------
>>>> svn:keywords = Id
>>>>
>>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java
>>>> ------------------------------------------------------------------------------
>>>> svn:keywords = Id
>>>>
>>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java
>>>> ------------------------------------------------------------------------------
>>>> svn:keywords = Id
>>>>
>>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java
>>>> ------------------------------------------------------------------------------
>>>> svn:keywords = Id
>>>>
>>>>
>>>
>>> I think the property should read
>>> Author Date Id Revision
>>
>> Please don't use Date - it is locale-dependent and causes SVN tags to
>> disagree with source archives.
>>
>> Also @Author tags are strongly discouraged.
>> We use changes.xml and contributors in the POM instead.
>>
> OK, my mistake.
> I was conforming with what I saw in existing files. So should the
> svn:keywords property read "Id", or "Id Revision"?
Both Id and Revision are fine, and can both be useful.
There's no harm in having the keywords set - it's only a problem if
they are *used*.
But having them set might encourage their use.
> Thanks for pointing this out,
> Sébastien
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java
MeasurementModel.java ProcessModel.java
Posted by Sébastien Brisard <se...@m4x.org>.
2012/2/9 sebb <se...@gmail.com>:
> 2012/2/9 Sébastien Brisard <se...@m4x.org>:
>> Hi,
>>
>>>
>>> svn:keywords = Id
>>>
>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java
>>> ------------------------------------------------------------------------------
>>> svn:keywords = Id
>>>
>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java
>>> ------------------------------------------------------------------------------
>>> svn:keywords = Id
>>>
>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java
>>> ------------------------------------------------------------------------------
>>> svn:keywords = Id
>>>
>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java
>>> ------------------------------------------------------------------------------
>>> svn:keywords = Id
>>>
>>>
>>
>> I think the property should read
>> Author Date Id Revision
>
> Please don't use Date - it is locale-dependent and causes SVN tags to
> disagree with source archives.
>
> Also @Author tags are strongly discouraged.
> We use changes.xml and contributors in the POM instead.
>
OK, my mistake.
I was conforming with what I saw in existing files. So should the
svn:keywords property read "Id", or "Id Revision"?
Thanks for pointing this out,
Sébastien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java
MeasurementModel.java ProcessModel.java
Posted by sebb <se...@gmail.com>.
2012/2/9 Sébastien Brisard <se...@m4x.org>:
> Hi,
>
>>
>> svn:keywords = Id
>>
>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java
>> ------------------------------------------------------------------------------
>> svn:keywords = Id
>>
>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java
>> ------------------------------------------------------------------------------
>> svn:keywords = Id
>>
>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java
>> ------------------------------------------------------------------------------
>> svn:keywords = Id
>>
>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java
>> ------------------------------------------------------------------------------
>> svn:keywords = Id
>>
>>
>
> I think the property should read
> Author Date Id Revision
Please don't use Date - it is locale-dependent and causes SVN tags to
disagree with source archives.
Also @Author tags are strongly discouraged.
We use changes.xml and contributors in the POM instead.
>
> Sébastien
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java MeasurementModel.java
ProcessModel.java
Posted by Thomas Neidhart <th...@gmail.com>.
On 02/09/2012 09:52 AM, Sébastien Brisard wrote:
> Hi,
> I think the property should read
> Author Date Id Revision
Ok thanks, I have fixed it. My default config lists them, but I had to
add them manually.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter:
DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java
MeasurementModel.java ProcessModel.java
Posted by Sébastien Brisard <se...@m4x.org>.
Hi,
>
> svn:keywords = Id
>
> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java
> ------------------------------------------------------------------------------
> svn:keywords = Id
>
> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java
> ------------------------------------------------------------------------------
> svn:keywords = Id
>
> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java
> ------------------------------------------------------------------------------
> svn:keywords = Id
>
> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java
> ------------------------------------------------------------------------------
> svn:keywords = Id
>
>
I think the property should read
Author Date Id Revision
Sébastien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org