You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:10:19 UTC

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4329: Adding AutoScaling for cks

davidjumani commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r515771736



##########
File path: plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java
##########
@@ -202,6 +204,10 @@ public static int compareSemanticVersions(String v1, String v2) throws IllegalAr
         return 0;
     }
 
+    public static boolean versionSupportsAutoscaling(KubernetesSupportedVersion clusterVersion) {

Review comment:
       Makes sense to deprecate it. Can also add a flag in case users are running older versions. Thanks @shwstppr 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org