[GitHub] [spark] maropu commented on a change in pull request #24187: [SPARK-27256][CORE][SQL]If the configuration is used to set the number of bytes, we'd better use `bytesConf`'.

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #24187: [SPARK-27256][CORE][SQL]If the configuration is used to set the number of bytes, we'd better use `bytesConf`'.
URL: https://github.com/apache/spark/pull/24187#discussion_r268416140
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -841,7 +841,7 @@ package object config {
   private[spark] val SHUFFLE_SORT_INIT_BUFFER_SIZE =
     ConfigBuilder("spark.shuffle.sort.initialBufferSize")
       .internal()
-      .intConf
+      .bytesConf(ByteUnit.BYTE)
       .checkValue(v => v > 0, "The value should be a positive integer.")
 
 Review comment:
   We need to check if the input value exists in the integer range?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org