You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/02/12 21:14:35 UTC
[commons-csv] branch master updated: replace findbugs with spotbugs
(#56)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-csv.git
The following commit(s) were added to refs/heads/master by this push:
new d83dab4 replace findbugs with spotbugs (#56)
d83dab4 is described below
commit d83dab4b0950e1cd8b13d29c470714e816c992a4
Author: Amey Jadiye <am...@gmail.com>
AuthorDate: Thu Feb 13 02:44:28 2020 +0530
replace findbugs with spotbugs (#56)
---
pom.xml | 31 +++++++++-------------
.../spotbugs/spotbugs-exclude-filter.xml} | 22 +++++++--------
2 files changed, 22 insertions(+), 31 deletions(-)
diff --git a/pom.xml b/pom.xml
index 870eda2..01959d5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -168,7 +168,7 @@
</properties>
<build>
- <defaultGoal>clean verify apache-rat:check clirr:check javadoc:javadoc</defaultGoal>
+ <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check spotbugs:check javadoc:javadoc</defaultGoal>
<plugins>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
@@ -208,15 +208,12 @@
<suppressionsLocation>${basedir}/src/main/resources/checkstyle/checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
</plugin>
- <!-- Allow findbugs to be run interactively; keep in sync with report config below -->
<plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>findbugs-maven-plugin</artifactId>
- <version>${commons.findbugs.version}</version>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${commons.spotbugs.version}</version>
<configuration>
- <threshold>Normal</threshold>
- <effort>Default</effort>
- <excludeFilterFile>${basedir}/src/main/resources/findbugs/findbugs-exclude-filter.xml</excludeFilterFile>
+ <excludeFilterFile>${basedir}/src/site/resources/spotbugs/spotbugs-exclude-filter.xml</excludeFilterFile>
</configuration>
</plugin>
<!-- Allow pmd to be run interactively; keep in sync with report config below -->
@@ -288,6 +285,14 @@
</reportSets>
</plugin>
<plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${commons.spotbugs.version}</version>
+ <configuration>
+ <excludeFilterFile>${basedir}/src/site/resources/spotbugs/spotbugs-exclude-filter.xml</excludeFilterFile>
+ </configuration>
+ </plugin>
+ <plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
<version>${pmd.version}</version>
@@ -302,16 +307,6 @@
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
- <artifactId>findbugs-maven-plugin</artifactId>
- <version>${commons.findbugs.version}</version>
- <configuration>
- <threshold>Normal</threshold>
- <effort>Default</effort>
- <excludeFilterFile>${basedir}/src/main/resources/findbugs/findbugs-exclude-filter.xml</excludeFilterFile>
- </configuration>
- </plugin>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
<artifactId>taglist-maven-plugin</artifactId>
<version>2.4</version>
<configuration>
diff --git a/src/main/resources/findbugs/findbugs-exclude-filter.xml b/src/site/resources/spotbugs/spotbugs-exclude-filter.xml
similarity index 57%
rename from src/main/resources/findbugs/findbugs-exclude-filter.xml
rename to src/site/resources/spotbugs/spotbugs-exclude-filter.xml
index da2896a..4af22bc 100644
--- a/src/main/resources/findbugs/findbugs-exclude-filter.xml
+++ b/src/site/resources/spotbugs/spotbugs-exclude-filter.xml
@@ -1,4 +1,3 @@
-<?xml version="1.0"?>
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
@@ -15,21 +14,18 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-
-<!--
- This file contains some false positive bugs detected by spotbugs. Their
- false positive nature has been analyzed individually and they have been
- put here to instruct spotbugs it must ignore them.
--->
<FindBugsFilter
- xmlns="https://github.com/spotbugs/filter/3.0.0"
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
+ xmlns="https://github.com/spotbugs/filter/3.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
+
<Match>
- <Class name="org.apache.commons.csv.CSVPrinter"/>
- <BugPattern name="SF_SWITCH_FALLTHROUGH"/>
- <Method name="printComment"/>
+ <Class name="org.apache.commons.csv.CSVPrinter" />
+ <Method name="printComment" >
+ <!-- Deliberate switch statement fall-through -->
+ </Method>
+ <Bug code="SF" />
</Match>
</FindBugsFilter>