You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/09 12:11:03 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #2219: CassandraQL native support #1355
JiriOndrusek opened a new pull request #2219:
URL: https://github.com/apache/camel-quarkus/pull/2219
fixes https://github.com/apache/camel-quarkus/issues/1355
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2219: CassandraQL native support #1355
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2219:
URL: https://github.com/apache/camel-quarkus/pull/2219#discussion_r573587146
##########
File path: integration-tests/cassandraql/src/test/java/org/apache/camel/quarkus/component/cassandraql/it/CassandraqlTest.java
##########
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.cassandraql.it;
+
+import io.quarkus.test.common.QuarkusTestResource;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
+import org.hamcrest.Matcher;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Order;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
+
+import static org.hamcrest.Matchers.allOf;
+import static org.hamcrest.Matchers.both;
+import static org.hamcrest.Matchers.containsString;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.not;
+
+@QuarkusTest
+@QuarkusTestResource(CassandraqlTestResource.class)
+@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
+class CassandraqlTest {
+
+ private Employee sheldon = new Employee(1, "Sheldon", "Alpha Centauri");
+ private Employee leonard = new Employee(2, "Leonard", "Earth");
+ private Employee irma = new Employee(3, "Irma", "Jupiter");
+
+ @Test
+ @Order(1)
Review comment:
Let's have some academic discussion about test structuring ;)
I see that splitting into the methods helps structuring and thus understanding the code.
I see that `@Order` is intended to overcome the fact that the test methods depend on effects caused by their predecessors. This helps when the whole class is executed without any explicit method includes/excludes.
However, `@Order` does not express the dependency. Therefore, when the first test fails, the successor tests are still executed and will most probably fail. They will all be reported as failed and I am not sure if there is any way to see quickly from the report which one of them is the root cause.
Also, the test methods cannot be executed independently via `mvn clean test -Dtest=CassandraqlTest#testUpdate` (except for the first one).
Given the above, I wonder whether this way of structuring brings enough benefits. I tend to see this kind of situation as end-to-end scenario that is best packed into as single test method where the structure is marked only by comments. (This is not a request to change this PR.) What do others think? Are there any other options to consider?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #2219: CassandraQL native support #1355
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #2219:
URL: https://github.com/apache/camel-quarkus/pull/2219#discussion_r572844107
##########
File path: integration-tests/cassandraql/src/main/java/org/apache/camel/quarkus/component/cassandraql/it/CassandraqlResource.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.cassandraql.it;
+
+import java.util.List;
+import java.util.stream.Collectors;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.inject.Inject;
+import javax.ws.rs.Consumes;
+import javax.ws.rs.GET;
+import javax.ws.rs.POST;
+import javax.ws.rs.Path;
+import javax.ws.rs.Produces;
+import javax.ws.rs.core.MediaType;
+
+import com.datastax.oss.driver.internal.core.cql.DefaultRow;
+import org.apache.camel.ConsumerTemplate;
+import org.apache.camel.Exchange;
+import org.apache.camel.FluentProducerTemplate;
+
+@Path("/cassandraql")
+@ApplicationScoped
+public class CassandraqlResource {
+ public static final String DB_URL_PARAMETER = CassandraqlResource.class.getSimpleName() + "_db_url";
+ public static final String KEYSPACE = "test";
+ public static final String EMPTY_LIST = "EMPTY";
+
+ @Inject
+ FluentProducerTemplate producerTemplate;
+
+ @Inject
+ ConsumerTemplate consumerTemplate;
+
+ @Path("/insertEmployee")
+ @POST
+ @Consumes(MediaType.APPLICATION_JSON)
+ public void insertEmployee(Employee object) {
+ producerTemplate.toF(createUrl("INSERT INTO employee(id, name, address) VALUES (?, ?, ?)"))
+ .withBody(object.getValue())
+ .request();
+ }
+
+ @Path("/getEmployee")
+ @POST
+ @Consumes(MediaType.TEXT_PLAIN)
+ @Produces(MediaType.TEXT_PLAIN)
+ public String getEmployee(String id) throws Exception {
+ final Exchange exchange = consumerTemplate
+ .receive(createUrl(String.format("SELECT * FROM employee WHERE id = %s", id)));
+ return convertBodyToString(exchange.getIn().getBody());
+ }
+
+ @Path("/getAllEmployees")
+ @GET
+ @Produces(MediaType.TEXT_PLAIN)
+ public String getAllEmployees() throws Exception {
+ final Exchange exchange = consumerTemplate.receive(createUrl("SELECT id, name, address FROM employee"));
+ return convertBodyToString(exchange.getIn().getBody());
+ }
+
+ @Path("/updateEmployee")
+ @POST
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.TEXT_PLAIN)
+ public boolean updateEmployee(Employee employee) throws Exception {
+ final Exchange exchange = consumerTemplate
+ .receive(createUrl(String.format("UPDATE employee SET name = '%s', address = '%s' WHERE id = %s",
+ employee.getName(), employee.getAddress(), employee.getId())));
+ return exchange != null;
+ }
+
+ @Path("/deleteEmployee")
+ @POST
+ @Consumes(MediaType.TEXT_PLAIN)
+ public void updateEmployee(String id) throws Exception {
Review comment:
What about renaming to something like getEmployeeById ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #2219: CassandraQL native support #1355
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #2219:
URL: https://github.com/apache/camel-quarkus/pull/2219#issuecomment-775954479
The `camel-master` branch needs some tidying so its expected to see some CI failures for docs. I'm working to fix that up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #2219: CassandraQL native support #1355
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #2219:
URL: https://github.com/apache/camel-quarkus/pull/2219#discussion_r572846259
##########
File path: integration-tests/cassandraql/src/main/java/org/apache/camel/quarkus/component/cassandraql/it/CassandraqlResource.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.cassandraql.it;
+
+import java.util.List;
+import java.util.stream.Collectors;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.inject.Inject;
+import javax.ws.rs.Consumes;
+import javax.ws.rs.GET;
+import javax.ws.rs.POST;
+import javax.ws.rs.Path;
+import javax.ws.rs.Produces;
+import javax.ws.rs.core.MediaType;
+
+import com.datastax.oss.driver.internal.core.cql.DefaultRow;
+import org.apache.camel.ConsumerTemplate;
+import org.apache.camel.Exchange;
+import org.apache.camel.FluentProducerTemplate;
+
+@Path("/cassandraql")
+@ApplicationScoped
+public class CassandraqlResource {
+ public static final String DB_URL_PARAMETER = CassandraqlResource.class.getSimpleName() + "_db_url";
+ public static final String KEYSPACE = "test";
+ public static final String EMPTY_LIST = "EMPTY";
+
+ @Inject
+ FluentProducerTemplate producerTemplate;
+
+ @Inject
+ ConsumerTemplate consumerTemplate;
+
+ @Path("/insertEmployee")
+ @POST
+ @Consumes(MediaType.APPLICATION_JSON)
+ public void insertEmployee(Employee object) {
+ producerTemplate.toF(createUrl("INSERT INTO employee(id, name, address) VALUES (?, ?, ?)"))
+ .withBody(object.getValue())
+ .request();
+ }
+
+ @Path("/getEmployee")
+ @POST
+ @Consumes(MediaType.TEXT_PLAIN)
+ @Produces(MediaType.TEXT_PLAIN)
+ public String getEmployee(String id) throws Exception {
+ final Exchange exchange = consumerTemplate
+ .receive(createUrl(String.format("SELECT * FROM employee WHERE id = %s", id)));
+ return convertBodyToString(exchange.getIn().getBody());
+ }
+
+ @Path("/getAllEmployees")
+ @GET
+ @Produces(MediaType.TEXT_PLAIN)
+ public String getAllEmployees() throws Exception {
+ final Exchange exchange = consumerTemplate.receive(createUrl("SELECT id, name, address FROM employee"));
+ return convertBodyToString(exchange.getIn().getBody());
+ }
+
+ @Path("/updateEmployee")
+ @POST
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.TEXT_PLAIN)
+ public boolean updateEmployee(Employee employee) throws Exception {
+ final Exchange exchange = consumerTemplate
+ .receive(createUrl(String.format("UPDATE employee SET name = '%s', address = '%s' WHERE id = %s",
+ employee.getName(), employee.getAddress(), employee.getId())));
+ return exchange != null;
+ }
+
+ @Path("/deleteEmployee")
+ @POST
+ @Consumes(MediaType.TEXT_PLAIN)
+ public void updateEmployee(String id) throws Exception {
Review comment:
I see now, that there is a bad method name vs path, which does not make sense, I'll fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2219: CassandraQL native support #1355
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2219:
URL: https://github.com/apache/camel-quarkus/pull/2219#discussion_r573594602
##########
File path: integration-tests/cassandraql/src/test/java/org/apache/camel/quarkus/component/cassandraql/it/CassandraqlTest.java
##########
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.cassandraql.it;
+
+import io.quarkus.test.common.QuarkusTestResource;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
+import org.hamcrest.Matcher;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Order;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
+
+import static org.hamcrest.Matchers.allOf;
+import static org.hamcrest.Matchers.both;
+import static org.hamcrest.Matchers.containsString;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.not;
+
+@QuarkusTest
+@QuarkusTestResource(CassandraqlTestResource.class)
+@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
+class CassandraqlTest {
+
+ private Employee sheldon = new Employee(1, "Sheldon", "Alpha Centauri");
+ private Employee leonard = new Employee(2, "Leonard", "Earth");
+ private Employee irma = new Employee(3, "Irma", "Jupiter");
+
+ @Test
+ @Order(1)
Review comment:
Yes, personally I'm not a fan of `@Order`. Like you say, most of our tests follow a pattern when if multiple steps are required to achieve some expected outcome, then they are bundled together in a single test case and marked by comments. E.g:
```
// Create foo
// Retrieve foo
// Delete foo
// Confirm foo was deleted
```
I'd like to 'close down' the `camel-master` branch and get the 3.8 upgrade merged to master soon. So if we can merge this now, we can have a follow up issue to restructure things later if we think its necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #2219: CassandraQL native support #1355
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #2219:
URL: https://github.com/apache/camel-quarkus/pull/2219
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #2219: CassandraQL native support #1355
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #2219:
URL: https://github.com/apache/camel-quarkus/pull/2219#discussion_r572848771
##########
File path: integration-tests/cassandraql/src/main/java/org/apache/camel/quarkus/component/cassandraql/it/CassandraqlResource.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.cassandraql.it;
+
+import java.util.List;
+import java.util.stream.Collectors;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.inject.Inject;
+import javax.ws.rs.Consumes;
+import javax.ws.rs.GET;
+import javax.ws.rs.POST;
+import javax.ws.rs.Path;
+import javax.ws.rs.Produces;
+import javax.ws.rs.core.MediaType;
+
+import com.datastax.oss.driver.internal.core.cql.DefaultRow;
+import org.apache.camel.ConsumerTemplate;
+import org.apache.camel.Exchange;
+import org.apache.camel.FluentProducerTemplate;
+
+@Path("/cassandraql")
+@ApplicationScoped
+public class CassandraqlResource {
+ public static final String DB_URL_PARAMETER = CassandraqlResource.class.getSimpleName() + "_db_url";
+ public static final String KEYSPACE = "test";
+ public static final String EMPTY_LIST = "EMPTY";
+
+ @Inject
+ FluentProducerTemplate producerTemplate;
+
+ @Inject
+ ConsumerTemplate consumerTemplate;
+
+ @Path("/insertEmployee")
+ @POST
+ @Consumes(MediaType.APPLICATION_JSON)
+ public void insertEmployee(Employee object) {
+ producerTemplate.toF(createUrl("INSERT INTO employee(id, name, address) VALUES (?, ?, ?)"))
+ .withBody(object.getValue())
+ .request();
+ }
+
+ @Path("/getEmployee")
+ @POST
+ @Consumes(MediaType.TEXT_PLAIN)
+ @Produces(MediaType.TEXT_PLAIN)
+ public String getEmployee(String id) throws Exception {
+ final Exchange exchange = consumerTemplate
+ .receive(createUrl(String.format("SELECT * FROM employee WHERE id = %s", id)));
+ return convertBodyToString(exchange.getIn().getBody());
+ }
+
+ @Path("/getAllEmployees")
+ @GET
+ @Produces(MediaType.TEXT_PLAIN)
+ public String getAllEmployees() throws Exception {
+ final Exchange exchange = consumerTemplate.receive(createUrl("SELECT id, name, address FROM employee"));
+ return convertBodyToString(exchange.getIn().getBody());
+ }
+
+ @Path("/updateEmployee")
+ @POST
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.TEXT_PLAIN)
+ public boolean updateEmployee(Employee employee) throws Exception {
+ final Exchange exchange = consumerTemplate
+ .receive(createUrl(String.format("UPDATE employee SET name = '%s', address = '%s' WHERE id = %s",
+ employee.getName(), employee.getAddress(), employee.getId())));
+ return exchange != null;
+ }
+
+ @Path("/deleteEmployee")
+ @POST
+ @Consumes(MediaType.TEXT_PLAIN)
+ public void updateEmployee(String id) throws Exception {
Review comment:
Correct functionality is to delete by Id, I renamed method to `deleteEmployeeById`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2219: CassandraQL native support #1355
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2219:
URL: https://github.com/apache/camel-quarkus/pull/2219#discussion_r573601857
##########
File path: integration-tests/cassandraql/src/test/java/org/apache/camel/quarkus/component/cassandraql/it/CassandraqlTest.java
##########
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.cassandraql.it;
+
+import io.quarkus.test.common.QuarkusTestResource;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
+import org.hamcrest.Matcher;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Order;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
+
+import static org.hamcrest.Matchers.allOf;
+import static org.hamcrest.Matchers.both;
+import static org.hamcrest.Matchers.containsString;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.not;
+
+@QuarkusTest
+@QuarkusTestResource(CassandraqlTestResource.class)
+@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
+class CassandraqlTest {
+
+ private Employee sheldon = new Employee(1, "Sheldon", "Alpha Centauri");
+ private Employee leonard = new Employee(2, "Leonard", "Earth");
+ private Employee irma = new Employee(3, "Irma", "Jupiter");
+
+ @Test
+ @Order(1)
Review comment:
This PR is good to merge. Thanks for your opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org