You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "JeremyYao (via GitHub)" <gi...@apache.org> on 2025/09/30 17:46:57 UTC
[PR] Update vscode wiki/readme to new ASF logo/branding [daffodil-vscode]
JeremyYao opened a new pull request, #1434:
URL: https://github.com/apache/daffodil-vscode/pull/1434
Closes #1433
## Description
Update existing ASF Feather branding in README and Wiki to ASF Oak Leaf branding.
## Wiki
- [ ] I have determined that no documentation updates are needed for these changes
- [ ] I have added following documentation for these changes
## Review Instructions including Screenshots
Verify the following items have the updated branding:
- README.md
- https://github.com/apache/daffodil-vscode/wiki#community-feedback
- https://github.com/apache/daffodil-vscode/wiki#legal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update vscode wiki/readme to new ASF logo/branding [daffodil-vscode]
Posted by "JeremyYao (via GitHub)" <gi...@apache.org>.
JeremyYao commented on code in PR #1434:
URL: https://github.com/apache/daffodil-vscode/pull/1434#discussion_r2395070778
##########
README.md:
##########
@@ -70,7 +70,7 @@ If additional help or guidance on using Apache Daffodil™, Apache Daffodil™ E
# Community Feedback
-[](https://www.apache.org)
+<img src="images/asf_logo_wide.png" width="581" alt="Apache Software Foundation Logo">
Review Comment:
I'd say it's worth making it smaller. The wiki logo's width is set to 200, so I'll have it be 200 to be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update vscode wiki/readme to new ASF logo/branding [daffodil-vscode]
Posted by "JeremyYao (via GitHub)" <gi...@apache.org>.
JeremyYao commented on code in PR #1434:
URL: https://github.com/apache/daffodil-vscode/pull/1434#discussion_r2395090293
##########
README.md:
##########
@@ -70,7 +70,7 @@ If additional help or guidance on using Apache Daffodil™, Apache Daffodil™ E
# Community Feedback
-[](https://www.apache.org)
+<img src="images/asf_logo_wide.png" width="581" alt="Apache Software Foundation Logo">
Review Comment:
Adjusted image's width to be 200, consistent with https://github.com/apache/daffodil-vscode/wiki.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update vscode wiki/readme to new ASF logo/branding [daffodil-vscode]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #1434:
URL: https://github.com/apache/daffodil-vscode/pull/1434#discussion_r2392416036
##########
README.md:
##########
@@ -99,7 +99,7 @@ This product includes the [space-grotesk](https://github.com/floriankarsten/spac
# Legal
-Apache, Apache Feather Logo, Apache Daffodil, Daffodil, and the Apache Daffodil logo are trademarks of The Apache Software Foundation. Visual Studio Code and VS Code are trademarks of Microsoft® Corporation. All rights reserved.
+Apache, Apache Oak Leaf Logo, Apache Daffodil, Daffodil, and the Apache Daffodil logo are trademarks of The Apache Software Foundation. Visual Studio Code and VS Code are trademarks of Microsoft® Corporation. All rights reserved.
Review Comment:
The trademark blurb on the apache.org homepage just calls it the "Apache logo". To be consistent with that, I'd suggest we drop "Oak Leaf"
##########
README.md:
##########
@@ -70,7 +70,7 @@ If additional help or guidance on using Apache Daffodil™, Apache Daffodil™ E
# Community Feedback
-[](https://www.apache.org)
+<img src="images/asf_logo_wide.png" width="581" alt="Apache Software Foundation Logo">
Review Comment:
A width of 581 seems pretty big. Is it worth making it smaller? No strong preference either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update vscode wiki/readme to new ASF logo/branding [daffodil-vscode]
Posted by "JeremyYao (via GitHub)" <gi...@apache.org>.
JeremyYao commented on code in PR #1434:
URL: https://github.com/apache/daffodil-vscode/pull/1434#discussion_r2395087647
##########
README.md:
##########
@@ -99,7 +99,7 @@ This product includes the [space-grotesk](https://github.com/floriankarsten/spac
# Legal
-Apache, Apache Feather Logo, Apache Daffodil, Daffodil, and the Apache Daffodil logo are trademarks of The Apache Software Foundation. Visual Studio Code and VS Code are trademarks of Microsoft® Corporation. All rights reserved.
+Apache, Apache Oak Leaf Logo, Apache Daffodil, Daffodil, and the Apache Daffodil logo are trademarks of The Apache Software Foundation. Visual Studio Code and VS Code are trademarks of Microsoft® Corporation. All rights reserved.
Review Comment:
Implemented suggested changes in both README.md and https://github.com/apache/daffodil-vscode/wiki.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update vscode wiki/readme to new ASF logo/branding [daffodil-vscode]
Posted by "JeremyYao (via GitHub)" <gi...@apache.org>.
JeremyYao commented on PR #1434:
URL: https://github.com/apache/daffodil-vscode/pull/1434#issuecomment-3353295371
I don't have R/W access to https://github.com/apache/daffodil-vscode.wiki.git. If anyone here has R/W access, please remove images/asf_logo_url.svg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update vscode wiki/readme to new ASF logo/branding [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell merged PR #1434:
URL: https://github.com/apache/daffodil-vscode/pull/1434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update vscode wiki/readme to new ASF logo/branding [daffodil-vscode]
Posted by "JeremyYao (via GitHub)" <gi...@apache.org>.
JeremyYao commented on code in PR #1434:
URL: https://github.com/apache/daffodil-vscode/pull/1434#discussion_r2395061441
##########
README.md:
##########
@@ -99,7 +99,7 @@ This product includes the [space-grotesk](https://github.com/floriankarsten/spac
# Legal
-Apache, Apache Feather Logo, Apache Daffodil, Daffodil, and the Apache Daffodil logo are trademarks of The Apache Software Foundation. Visual Studio Code and VS Code are trademarks of Microsoft® Corporation. All rights reserved.
+Apache, Apache Oak Leaf Logo, Apache Daffodil, Daffodil, and the Apache Daffodil logo are trademarks of The Apache Software Foundation. Visual Studio Code and VS Code are trademarks of Microsoft® Corporation. All rights reserved.
Review Comment:
I agree with having it be consistent w/ the Apache.org homepage. I'll go ahead and omit the `Oak Leaf` portion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org