You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/10 03:51:55 UTC

[GitHub] [hudi] boneanxs commented on a change in pull request #4350: [HUDI-3047] Basic Implementation of Spark Datasource V2

boneanxs commented on a change in pull request #4350:
URL: https://github.com/apache/hudi/pull/4350#discussion_r780880750



##########
File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/SparkAdapter.scala
##########
@@ -92,4 +95,31 @@ trait SparkAdapter extends Serializable {
    * ParserInterface#parseMultipartIdentifier is supported since spark3, for spark2 this should not be called.
    */
   def parseMultipartIdentifier(parser: ParserInterface, sqlText: String): Seq[String]
+
+  def isHoodieTable(table: LogicalPlan, spark: SparkSession): Boolean = {

Review comment:
       Is there any difference with **hoodieSqlCommonUtils.isHoodieTable**? I see sometimes we use **adapter.isHoodieTable**, sometimes use **hoodieSqlCommonUtils.isHoodieTable**
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org