You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2010/10/23 18:40:51 UTC
svn commit: r1026643 -
/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/MarkupComponentBorder.java
Author: mgrigorov
Date: Sat Oct 23 16:40:51 2010
New Revision: 1026643
URL: http://svn.apache.org/viewvc?rev=1026643&view=rev
Log:
Findbugs warnings: .../wicket/src/main/java/org/apache/wicket/markup/html/border/MarkupComponentBorder.java:187 Nullcheck of owner at line 188 of value previously dereferenced
Remove the check for 'null' for 'owner'. This variable is used several times before that, i.e. it is not null.
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/MarkupComponentBorder.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/MarkupComponentBorder.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/MarkupComponentBorder.java?rev=1026643&r1=1026642&r2=1026643&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/MarkupComponentBorder.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/border/MarkupComponentBorder.java Sat Oct 23 16:40:51 2010
@@ -185,7 +185,7 @@ public class MarkupComponentBorder exten
.getResourceStreamLocator();
final String style = owner.getStyle();
- final String variation = (owner == null ? null : owner.getVariation());
+ final String variation = owner.getVariation();
final Locale locale = owner.getLocale();
MarkupResourceStream markupResourceStream = null;