You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/10/30 00:11:48 UTC
Review Request: Removed the lxc isolation module.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7769/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This removes the lxc isolation module!
Diffs
-----
src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
src/launcher/launcher.hpp ead58c0f60b6bff532f241a224b547b25e292175
src/launcher/launcher.cpp 3ce8081edba669157a14b815503322ea8d367d43
src/launcher/main.cpp e90df85ae433431defdd251490c74a482a58f743
src/slave/cgroups_isolation_module.cpp a43d31760f14e641cc7d75b6e98041f98bba2b63
src/slave/isolation_module.cpp a881bab582c30e2812bcdaf649a2e6458cc23c11
src/slave/isolation_module_factory.cpp 649894549f00c4ca231341ecaf2a8e5ab71d717c
src/slave/lxc_isolation_module.hpp 49bf8741b96f58202acb737917e6cc353e758893
src/slave/lxc_isolation_module.cpp 36d86e08f7b511371a9a2053ddf43477063a79f1
src/slave/process_based_isolation_module.cpp 744832625d6d1898eb2b31b184f5d0c68408835d
src/tests/lxc_isolation_tests.cpp 30e7459069a75fecd3ea976ff02e7cf4f114089a
Diff: https://reviews.apache.org/r/7769/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Setting up a Mesos cluster to run Hadoop
Posted by Jim Donahue <jd...@adobe.com>.
I'm working on the Hadoop setup for a Mesos cluster. Here's what I take from the documentation -- please correct if I'm wrong:
1. Each node (master and slaves) needs the following (replicated) configuration files:
Mapred-site.xml (plugging in the URL of the Mesos master)
Hadoop-env.sh (with JAVA_HOME, PROTOBUF_JAR, MESOS_JAR, MESOS_NATIVE_LIBRARY and HADOOP_CLASSPATH set)
Core-site.sh
And a "master" file and a "slaves" file (with the host names or IP addresses of the master and slaves)
2. On the master, I should start a jobtracker when the cluster comes up.
3. Ports 9000 and 9001 need to be open on all instances.
I'm running the same AMI on all instances, so at least I know that the various software components are all installed in the same place on all the machines in the cluster.
Am I missing anything?
Thanks,
Jim Donahue
Adobe Systems
Re: Review Request: Removed the lxc isolation module.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7769/
-----------------------------------------------------------
(Updated Nov. 7, 2012, 12:43 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Also killed the lxc_isolation_factory.{cpp,hpp}.
Description
-------
This removes the lxc isolation module!
Diffs (updated)
-----
src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
src/launcher/launcher.hpp ead58c0f60b6bff532f241a224b547b25e292175
src/launcher/launcher.cpp 3ce8081edba669157a14b815503322ea8d367d43
src/launcher/main.cpp e90df85ae433431defdd251490c74a482a58f743
src/slave/cgroups_isolation_module.cpp 3d10ee568b8f194543707374f34f21bd3a927958
src/slave/isolation_module.cpp a881bab582c30e2812bcdaf649a2e6458cc23c11
src/slave/isolation_module_factory.hpp 9e1fef4324b6657f9887d2703be4a3257ab71f85
src/slave/isolation_module_factory.cpp 649894549f00c4ca231341ecaf2a8e5ab71d717c
src/slave/lxc_isolation_module.hpp 49bf8741b96f58202acb737917e6cc353e758893
src/slave/lxc_isolation_module.cpp 36d86e08f7b511371a9a2053ddf43477063a79f1
src/slave/main.cpp 70bb71e427aaa5e1ebb1ae132c9aad3ebe9be34c
src/slave/process_based_isolation_module.cpp b0b6a81c93acc68d1f4acbdda5ab2f9f96b5fb5a
src/tests/lxc_isolation_tests.cpp 30e7459069a75fecd3ea976ff02e7cf4f114089a
Diff: https://reviews.apache.org/r/7769/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Removed the lxc isolation module.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7769/#review13052
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/7769/#comment28091>
reviewboard bug?
These lines all have whitespace up to the trailing \
- Ben Mahler
On Oct. 29, 2012, 11:11 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7769/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2012, 11:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This removes the lxc isolation module!
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/launcher/launcher.hpp ead58c0f60b6bff532f241a224b547b25e292175
> src/launcher/launcher.cpp 3ce8081edba669157a14b815503322ea8d367d43
> src/launcher/main.cpp e90df85ae433431defdd251490c74a482a58f743
> src/slave/cgroups_isolation_module.cpp a43d31760f14e641cc7d75b6e98041f98bba2b63
> src/slave/isolation_module.cpp a881bab582c30e2812bcdaf649a2e6458cc23c11
> src/slave/isolation_module_factory.cpp 649894549f00c4ca231341ecaf2a8e5ab71d717c
> src/slave/lxc_isolation_module.hpp 49bf8741b96f58202acb737917e6cc353e758893
> src/slave/lxc_isolation_module.cpp 36d86e08f7b511371a9a2053ddf43477063a79f1
> src/slave/process_based_isolation_module.cpp 744832625d6d1898eb2b31b184f5d0c68408835d
> src/tests/lxc_isolation_tests.cpp 30e7459069a75fecd3ea976ff02e7cf4f114089a
>
> Diff: https://reviews.apache.org/r/7769/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Removed the lxc isolation module.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7769/#review13046
-----------------------------------------------------------
Ship it!
src/Makefile.am
<https://reviews.apache.org/r/7769/#comment28081>
ws
- Vinod Kone
On Oct. 29, 2012, 11:11 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7769/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2012, 11:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This removes the lxc isolation module!
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/launcher/launcher.hpp ead58c0f60b6bff532f241a224b547b25e292175
> src/launcher/launcher.cpp 3ce8081edba669157a14b815503322ea8d367d43
> src/launcher/main.cpp e90df85ae433431defdd251490c74a482a58f743
> src/slave/cgroups_isolation_module.cpp a43d31760f14e641cc7d75b6e98041f98bba2b63
> src/slave/isolation_module.cpp a881bab582c30e2812bcdaf649a2e6458cc23c11
> src/slave/isolation_module_factory.cpp 649894549f00c4ca231341ecaf2a8e5ab71d717c
> src/slave/lxc_isolation_module.hpp 49bf8741b96f58202acb737917e6cc353e758893
> src/slave/lxc_isolation_module.cpp 36d86e08f7b511371a9a2053ddf43477063a79f1
> src/slave/process_based_isolation_module.cpp 744832625d6d1898eb2b31b184f5d0c68408835d
> src/tests/lxc_isolation_tests.cpp 30e7459069a75fecd3ea976ff02e7cf4f114089a
>
> Diff: https://reviews.apache.org/r/7769/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Removed the lxc isolation module.
Posted by Ben Mahler <be...@gmail.com>.
> On Nov. 5, 2012, 10:23 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, line 210
> > <https://reviews.apache.org/r/7769/diff/1/?file=181854#file181854line210>
> >
> > Is lxc_isolation_tests.cpp is gone too?
Yep, it was either never added to the Makefile, or was removed at some point..
> On Nov. 5, 2012, 10:23 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, line 215
> > <https://reviews.apache.org/r/7769/diff/1/?file=181854#file181854line215>
> >
> > The other lines probably have tabs instead of spaces.
fixed.
> On Nov. 5, 2012, 10:23 p.m., Benjamin Hindman wrote:
> > src/slave/isolation_module_factory.cpp, line 30
> > <https://reviews.apache.org/r/7769/diff/1/?file=181860#file181860line30>
> >
> > This code is an island and should just get removed too.
Can I kill common/factory.{hpp,cpp} as well?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7769/#review13106
-----------------------------------------------------------
On Oct. 29, 2012, 11:11 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7769/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2012, 11:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This removes the lxc isolation module!
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/launcher/launcher.hpp ead58c0f60b6bff532f241a224b547b25e292175
> src/launcher/launcher.cpp 3ce8081edba669157a14b815503322ea8d367d43
> src/launcher/main.cpp e90df85ae433431defdd251490c74a482a58f743
> src/slave/cgroups_isolation_module.cpp a43d31760f14e641cc7d75b6e98041f98bba2b63
> src/slave/isolation_module.cpp a881bab582c30e2812bcdaf649a2e6458cc23c11
> src/slave/isolation_module_factory.cpp 649894549f00c4ca231341ecaf2a8e5ab71d717c
> src/slave/lxc_isolation_module.hpp 49bf8741b96f58202acb737917e6cc353e758893
> src/slave/lxc_isolation_module.cpp 36d86e08f7b511371a9a2053ddf43477063a79f1
> src/slave/process_based_isolation_module.cpp 744832625d6d1898eb2b31b184f5d0c68408835d
> src/tests/lxc_isolation_tests.cpp 30e7459069a75fecd3ea976ff02e7cf4f114089a
>
> Diff: https://reviews.apache.org/r/7769/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Removed the lxc isolation module.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7769/#review13106
-----------------------------------------------------------
Ship it!
src/Makefile.am
<https://reviews.apache.org/r/7769/#comment28242>
Is lxc_isolation_tests.cpp is gone too?
src/Makefile.am
<https://reviews.apache.org/r/7769/#comment28240>
The other lines probably have tabs instead of spaces.
src/slave/isolation_module_factory.cpp
<https://reviews.apache.org/r/7769/#comment28241>
This code is an island and should just get removed too.
- Benjamin Hindman
On Oct. 29, 2012, 11:11 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7769/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2012, 11:11 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This removes the lxc isolation module!
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/launcher/launcher.hpp ead58c0f60b6bff532f241a224b547b25e292175
> src/launcher/launcher.cpp 3ce8081edba669157a14b815503322ea8d367d43
> src/launcher/main.cpp e90df85ae433431defdd251490c74a482a58f743
> src/slave/cgroups_isolation_module.cpp a43d31760f14e641cc7d75b6e98041f98bba2b63
> src/slave/isolation_module.cpp a881bab582c30e2812bcdaf649a2e6458cc23c11
> src/slave/isolation_module_factory.cpp 649894549f00c4ca231341ecaf2a8e5ab71d717c
> src/slave/lxc_isolation_module.hpp 49bf8741b96f58202acb737917e6cc353e758893
> src/slave/lxc_isolation_module.cpp 36d86e08f7b511371a9a2053ddf43477063a79f1
> src/slave/process_based_isolation_module.cpp 744832625d6d1898eb2b31b184f5d0c68408835d
> src/tests/lxc_isolation_tests.cpp 30e7459069a75fecd3ea976ff02e7cf4f114089a
>
> Diff: https://reviews.apache.org/r/7769/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>