You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by li...@apache.org on 2022/04/25 12:20:47 UTC

[servicecomb-java-chassis] branch master updated: [SCB-2462] Fix equals in TrafficMarker (#2797)

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
     new 85b3374fa [SCB-2462] Fix equals in TrafficMarker (#2797)
85b3374fa is described below

commit 85b3374fac1019fa5ba3bf792fd83974633da857
Author: ZhangJian He <sh...@gmail.com>
AuthorDate: Mon Apr 25 20:20:42 2022 +0800

    [SCB-2462] Fix equals in TrafficMarker (#2797)
---
 ci/spotbugs/exclude.xml                                               | 4 ----
 .../java/org/apache/servicecomb/governance/marker/TrafficMarker.java  | 3 +--
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/ci/spotbugs/exclude.xml b/ci/spotbugs/exclude.xml
index e0b6e6c48..d37d28e2b 100644
--- a/ci/spotbugs/exclude.xml
+++ b/ci/spotbugs/exclude.xml
@@ -155,10 +155,6 @@
         <Bug pattern="RV_NEGATING_RESULT_OF_COMPARETO"/>
     </Match>
 
-    <Match>
-        <Bug pattern="SA_FIELD_SELF_COMPARISON"/>
-    </Match>
-
     <Match>
         <Bug pattern="SE_BAD_FIELD"/>
     </Match>
diff --git a/governance/src/main/java/org/apache/servicecomb/governance/marker/TrafficMarker.java b/governance/src/main/java/org/apache/servicecomb/governance/marker/TrafficMarker.java
index 9dbaf4d73..a578d3f9a 100644
--- a/governance/src/main/java/org/apache/servicecomb/governance/marker/TrafficMarker.java
+++ b/governance/src/main/java/org/apache/servicecomb/governance/marker/TrafficMarker.java
@@ -52,7 +52,6 @@ public class TrafficMarker extends Configurable {
   }
 
   public boolean checkMatch(GovernanceRequest governanceRequest, RequestProcessor requestProcessor) {
-    return this.matches.stream().anyMatch(match ->
-        this.name.equals(name) && requestProcessor.match(governanceRequest, match));
+    return this.matches.stream().anyMatch(match -> requestProcessor.match(governanceRequest, match));
   }
 }