You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by David Jencks <da...@gmail.com> on 2022/01/07 06:58:46 UTC
Is camel-kamelets 0.6.0 release incomplete?
The source tar.gz download looks fine to me, but the GitHub branch poms (e.g. https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml <https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml>) have version main-SNAPSHOT instead of 0.6.1-SNAPSHOT (or whatever is correct), and the dependencies in the kamelet yamls also have main-SNAPSHOT for the util version.
David Jencks
Re: Is camel-kamelets 0.6.0 release incomplete?
Posted by Andrea Cosentino <an...@gmail.com>.
I don't know if I'm not understanding, but now if you look at yamls
everything is pointing to 0.6.0 release.
Do you prefer the tag for specific reason? It might be it's late in the
evening here.
Thanks
Il ven 7 gen 2022, 22:11 David Jencks <da...@gmail.com> ha scritto:
> This is good but i realized eventually there may be a LTS kamelets release
> where we can’t just point to the branch. I suggest pointing to the tag
> instead, where the version is going to be always correct. PR soon (I hope).
>
> I think it would be possible to automate figuring out the branch/tag but
> this would require extracting the version from the pom and analyzing it:
> I’m not sure if it’s worth it, although having to set it during release
> seems like a big annoyance. Any thoughts?
>
>
> Thanks!!
> David Jencks
>
> > On Jan 7, 2022, at 12:54 AM, Andrea Cosentino <an...@gmail.com> wrote:
> >
> > To harmonize with 0.5.x and since there won't be any 0.6.x release
> anymore
> > I'll change to 0.6.0 in the end.
> >
> > Il giorno ven 7 gen 2022 alle ore 09:18 Andrea Cosentino <
> ancosen@gmail.com>
> > ha scritto:
> >
> >> About the kamelet.yaml:
> >>
> >> In the tag released the version is 0.6.0
> >>
> >>
> >>
> https://github.com/apache/camel-kamelets/blob/v0.6.0/kamelets/aws-redshift-sink.kamelet.yaml
> >>
> >> And even the library are pointing to a released version
> >>
> >>
> >>
> https://github.com/apache/camel-kamelets/blob/v0.6.0/kamelets/extract-field-action.kamelet.yaml#L42
> >>
> >> I could change the SNAPSHOT version to 0.6.0, but I don't see why, in
> the
> >> end the 0.6.x may be a development branch pointing to something still
> to be
> >> release, the important part is the tag and the released code which it's
> >> still pointing to 0.6.0
> >>
> >> The released version is pointing to released code and you could see this
> >> by looking at the uploaded jars or into the tag.
> >>
> >> Il giorno ven 7 gen 2022 alle ore 08:52 David Jencks <
> >> david.a.jencks@gmail.com> ha scritto:
> >>
> >>> Thanks!
> >>>
> >>> I think there are still a couple of problems, though:
> >>>
> >>> - the versions in the kamelet yaml are snapshots
> >>> - the source links are pointing to main
> >>>
> >>> As a result, we’re pointing to unreleased code from a released version,
> >>> and even fixing the 2nd point won’t help. The dependencies in 0.5.x
> look
> >>> like `- "mvn:org.apache.camel.kamelets:camel-kamelets-utils:0.5.0”`
> which
> >>> seems more correct to me.
> >>>
> >>> David Jencks
> >>>
> >>>> On Jan 6, 2022, at 11:08 PM, Andrea Cosentino <an...@gmail.com>
> >>> wrote:
> >>>>
> >>>> Should be ok, now.
> >>>>
> >>>> Il giorno ven 7 gen 2022 alle ore 08:03 Andrea Cosentino <
> >>> ancosen@gmail.com>
> >>>> ha scritto:
> >>>>
> >>>>> There won't be any new release of 0.6.x by the way.
> >>>>>
> >>>>> Il giorno ven 7 gen 2022 alle ore 08:02 Andrea Cosentino <
> >>>>> ancosen@gmail.com> ha scritto:
> >>>>>
> >>>>>> I still need to align the branch, but the release is complete. Using
> >>>>>> main-SNAPSHOT is not a problem, it's just a descriptor, by the way
> to
> >>> avoid
> >>>>>> confusion I'll align there.
> >>>>>>
> >>>>>> Il giorno ven 7 gen 2022 alle ore 07:58 David Jencks <
> >>>>>> david.a.jencks@gmail.com> ha scritto:
> >>>>>>
> >>>>>>> The source tar.gz download looks fine to me, but the GitHub branch
> >>> poms
> >>>>>>> (e.g. https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml
> <
> >>>>>>> https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml>) have
> >>>>>>> version main-SNAPSHOT instead of 0.6.1-SNAPSHOT (or whatever is
> >>> correct),
> >>>>>>> and the dependencies in the kamelet yamls also have main-SNAPSHOT
> >>> for the
> >>>>>>> util version.
> >>>>>>>
> >>>>>>> David Jencks
> >>>>>>
> >>>>>>
> >>>
> >>>
>
>
Re: Is camel-kamelets 0.6.0 release incomplete?
Posted by David Jencks <da...@gmail.com>.
This is good but i realized eventually there may be a LTS kamelets release where we can’t just point to the branch. I suggest pointing to the tag instead, where the version is going to be always correct. PR soon (I hope).
I think it would be possible to automate figuring out the branch/tag but this would require extracting the version from the pom and analyzing it: I’m not sure if it’s worth it, although having to set it during release seems like a big annoyance. Any thoughts?
Thanks!!
David Jencks
> On Jan 7, 2022, at 12:54 AM, Andrea Cosentino <an...@gmail.com> wrote:
>
> To harmonize with 0.5.x and since there won't be any 0.6.x release anymore
> I'll change to 0.6.0 in the end.
>
> Il giorno ven 7 gen 2022 alle ore 09:18 Andrea Cosentino <an...@gmail.com>
> ha scritto:
>
>> About the kamelet.yaml:
>>
>> In the tag released the version is 0.6.0
>>
>>
>> https://github.com/apache/camel-kamelets/blob/v0.6.0/kamelets/aws-redshift-sink.kamelet.yaml
>>
>> And even the library are pointing to a released version
>>
>>
>> https://github.com/apache/camel-kamelets/blob/v0.6.0/kamelets/extract-field-action.kamelet.yaml#L42
>>
>> I could change the SNAPSHOT version to 0.6.0, but I don't see why, in the
>> end the 0.6.x may be a development branch pointing to something still to be
>> release, the important part is the tag and the released code which it's
>> still pointing to 0.6.0
>>
>> The released version is pointing to released code and you could see this
>> by looking at the uploaded jars or into the tag.
>>
>> Il giorno ven 7 gen 2022 alle ore 08:52 David Jencks <
>> david.a.jencks@gmail.com> ha scritto:
>>
>>> Thanks!
>>>
>>> I think there are still a couple of problems, though:
>>>
>>> - the versions in the kamelet yaml are snapshots
>>> - the source links are pointing to main
>>>
>>> As a result, we’re pointing to unreleased code from a released version,
>>> and even fixing the 2nd point won’t help. The dependencies in 0.5.x look
>>> like `- "mvn:org.apache.camel.kamelets:camel-kamelets-utils:0.5.0”` which
>>> seems more correct to me.
>>>
>>> David Jencks
>>>
>>>> On Jan 6, 2022, at 11:08 PM, Andrea Cosentino <an...@gmail.com>
>>> wrote:
>>>>
>>>> Should be ok, now.
>>>>
>>>> Il giorno ven 7 gen 2022 alle ore 08:03 Andrea Cosentino <
>>> ancosen@gmail.com>
>>>> ha scritto:
>>>>
>>>>> There won't be any new release of 0.6.x by the way.
>>>>>
>>>>> Il giorno ven 7 gen 2022 alle ore 08:02 Andrea Cosentino <
>>>>> ancosen@gmail.com> ha scritto:
>>>>>
>>>>>> I still need to align the branch, but the release is complete. Using
>>>>>> main-SNAPSHOT is not a problem, it's just a descriptor, by the way to
>>> avoid
>>>>>> confusion I'll align there.
>>>>>>
>>>>>> Il giorno ven 7 gen 2022 alle ore 07:58 David Jencks <
>>>>>> david.a.jencks@gmail.com> ha scritto:
>>>>>>
>>>>>>> The source tar.gz download looks fine to me, but the GitHub branch
>>> poms
>>>>>>> (e.g. https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml <
>>>>>>> https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml>) have
>>>>>>> version main-SNAPSHOT instead of 0.6.1-SNAPSHOT (or whatever is
>>> correct),
>>>>>>> and the dependencies in the kamelet yamls also have main-SNAPSHOT
>>> for the
>>>>>>> util version.
>>>>>>>
>>>>>>> David Jencks
>>>>>>
>>>>>>
>>>
>>>
Re: Is camel-kamelets 0.6.0 release incomplete?
Posted by Andrea Cosentino <an...@gmail.com>.
To harmonize with 0.5.x and since there won't be any 0.6.x release anymore
I'll change to 0.6.0 in the end.
Il giorno ven 7 gen 2022 alle ore 09:18 Andrea Cosentino <an...@gmail.com>
ha scritto:
> About the kamelet.yaml:
>
> In the tag released the version is 0.6.0
>
>
> https://github.com/apache/camel-kamelets/blob/v0.6.0/kamelets/aws-redshift-sink.kamelet.yaml
>
> And even the library are pointing to a released version
>
>
> https://github.com/apache/camel-kamelets/blob/v0.6.0/kamelets/extract-field-action.kamelet.yaml#L42
>
> I could change the SNAPSHOT version to 0.6.0, but I don't see why, in the
> end the 0.6.x may be a development branch pointing to something still to be
> release, the important part is the tag and the released code which it's
> still pointing to 0.6.0
>
> The released version is pointing to released code and you could see this
> by looking at the uploaded jars or into the tag.
>
> Il giorno ven 7 gen 2022 alle ore 08:52 David Jencks <
> david.a.jencks@gmail.com> ha scritto:
>
>> Thanks!
>>
>> I think there are still a couple of problems, though:
>>
>> - the versions in the kamelet yaml are snapshots
>> - the source links are pointing to main
>>
>> As a result, we’re pointing to unreleased code from a released version,
>> and even fixing the 2nd point won’t help. The dependencies in 0.5.x look
>> like `- "mvn:org.apache.camel.kamelets:camel-kamelets-utils:0.5.0”` which
>> seems more correct to me.
>>
>> David Jencks
>>
>> > On Jan 6, 2022, at 11:08 PM, Andrea Cosentino <an...@gmail.com>
>> wrote:
>> >
>> > Should be ok, now.
>> >
>> > Il giorno ven 7 gen 2022 alle ore 08:03 Andrea Cosentino <
>> ancosen@gmail.com>
>> > ha scritto:
>> >
>> >> There won't be any new release of 0.6.x by the way.
>> >>
>> >> Il giorno ven 7 gen 2022 alle ore 08:02 Andrea Cosentino <
>> >> ancosen@gmail.com> ha scritto:
>> >>
>> >>> I still need to align the branch, but the release is complete. Using
>> >>> main-SNAPSHOT is not a problem, it's just a descriptor, by the way to
>> avoid
>> >>> confusion I'll align there.
>> >>>
>> >>> Il giorno ven 7 gen 2022 alle ore 07:58 David Jencks <
>> >>> david.a.jencks@gmail.com> ha scritto:
>> >>>
>> >>>> The source tar.gz download looks fine to me, but the GitHub branch
>> poms
>> >>>> (e.g. https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml <
>> >>>> https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml>) have
>> >>>> version main-SNAPSHOT instead of 0.6.1-SNAPSHOT (or whatever is
>> correct),
>> >>>> and the dependencies in the kamelet yamls also have main-SNAPSHOT
>> for the
>> >>>> util version.
>> >>>>
>> >>>> David Jencks
>> >>>
>> >>>
>>
>>
Re: Is camel-kamelets 0.6.0 release incomplete?
Posted by Andrea Cosentino <an...@gmail.com>.
About the kamelet.yaml:
In the tag released the version is 0.6.0
https://github.com/apache/camel-kamelets/blob/v0.6.0/kamelets/aws-redshift-sink.kamelet.yaml
And even the library are pointing to a released version
https://github.com/apache/camel-kamelets/blob/v0.6.0/kamelets/extract-field-action.kamelet.yaml#L42
I could change the SNAPSHOT version to 0.6.0, but I don't see why, in the
end the 0.6.x may be a development branch pointing to something still to be
release, the important part is the tag and the released code which it's
still pointing to 0.6.0
The released version is pointing to released code and you could see this by
looking at the uploaded jars or into the tag.
Il giorno ven 7 gen 2022 alle ore 08:52 David Jencks <
david.a.jencks@gmail.com> ha scritto:
> Thanks!
>
> I think there are still a couple of problems, though:
>
> - the versions in the kamelet yaml are snapshots
> - the source links are pointing to main
>
> As a result, we’re pointing to unreleased code from a released version,
> and even fixing the 2nd point won’t help. The dependencies in 0.5.x look
> like `- "mvn:org.apache.camel.kamelets:camel-kamelets-utils:0.5.0”` which
> seems more correct to me.
>
> David Jencks
>
> > On Jan 6, 2022, at 11:08 PM, Andrea Cosentino <an...@gmail.com> wrote:
> >
> > Should be ok, now.
> >
> > Il giorno ven 7 gen 2022 alle ore 08:03 Andrea Cosentino <
> ancosen@gmail.com>
> > ha scritto:
> >
> >> There won't be any new release of 0.6.x by the way.
> >>
> >> Il giorno ven 7 gen 2022 alle ore 08:02 Andrea Cosentino <
> >> ancosen@gmail.com> ha scritto:
> >>
> >>> I still need to align the branch, but the release is complete. Using
> >>> main-SNAPSHOT is not a problem, it's just a descriptor, by the way to
> avoid
> >>> confusion I'll align there.
> >>>
> >>> Il giorno ven 7 gen 2022 alle ore 07:58 David Jencks <
> >>> david.a.jencks@gmail.com> ha scritto:
> >>>
> >>>> The source tar.gz download looks fine to me, but the GitHub branch
> poms
> >>>> (e.g. https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml <
> >>>> https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml>) have
> >>>> version main-SNAPSHOT instead of 0.6.1-SNAPSHOT (or whatever is
> correct),
> >>>> and the dependencies in the kamelet yamls also have main-SNAPSHOT for
> the
> >>>> util version.
> >>>>
> >>>> David Jencks
> >>>
> >>>
>
>
Re: Is camel-kamelets 0.6.0 release incomplete?
Posted by David Jencks <da...@gmail.com>.
Thanks!
I think there are still a couple of problems, though:
- the versions in the kamelet yaml are snapshots
- the source links are pointing to main
As a result, we’re pointing to unreleased code from a released version, and even fixing the 2nd point won’t help. The dependencies in 0.5.x look like `- "mvn:org.apache.camel.kamelets:camel-kamelets-utils:0.5.0”` which seems more correct to me.
David Jencks
> On Jan 6, 2022, at 11:08 PM, Andrea Cosentino <an...@gmail.com> wrote:
>
> Should be ok, now.
>
> Il giorno ven 7 gen 2022 alle ore 08:03 Andrea Cosentino <an...@gmail.com>
> ha scritto:
>
>> There won't be any new release of 0.6.x by the way.
>>
>> Il giorno ven 7 gen 2022 alle ore 08:02 Andrea Cosentino <
>> ancosen@gmail.com> ha scritto:
>>
>>> I still need to align the branch, but the release is complete. Using
>>> main-SNAPSHOT is not a problem, it's just a descriptor, by the way to avoid
>>> confusion I'll align there.
>>>
>>> Il giorno ven 7 gen 2022 alle ore 07:58 David Jencks <
>>> david.a.jencks@gmail.com> ha scritto:
>>>
>>>> The source tar.gz download looks fine to me, but the GitHub branch poms
>>>> (e.g. https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml <
>>>> https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml>) have
>>>> version main-SNAPSHOT instead of 0.6.1-SNAPSHOT (or whatever is correct),
>>>> and the dependencies in the kamelet yamls also have main-SNAPSHOT for the
>>>> util version.
>>>>
>>>> David Jencks
>>>
>>>
Re: Is camel-kamelets 0.6.0 release incomplete?
Posted by Andrea Cosentino <an...@gmail.com>.
Should be ok, now.
Il giorno ven 7 gen 2022 alle ore 08:03 Andrea Cosentino <an...@gmail.com>
ha scritto:
> There won't be any new release of 0.6.x by the way.
>
> Il giorno ven 7 gen 2022 alle ore 08:02 Andrea Cosentino <
> ancosen@gmail.com> ha scritto:
>
>> I still need to align the branch, but the release is complete. Using
>> main-SNAPSHOT is not a problem, it's just a descriptor, by the way to avoid
>> confusion I'll align there.
>>
>> Il giorno ven 7 gen 2022 alle ore 07:58 David Jencks <
>> david.a.jencks@gmail.com> ha scritto:
>>
>>> The source tar.gz download looks fine to me, but the GitHub branch poms
>>> (e.g. https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml <
>>> https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml>) have
>>> version main-SNAPSHOT instead of 0.6.1-SNAPSHOT (or whatever is correct),
>>> and the dependencies in the kamelet yamls also have main-SNAPSHOT for the
>>> util version.
>>>
>>> David Jencks
>>
>>
Re: Is camel-kamelets 0.6.0 release incomplete?
Posted by Andrea Cosentino <an...@gmail.com>.
There won't be any new release of 0.6.x by the way.
Il giorno ven 7 gen 2022 alle ore 08:02 Andrea Cosentino <an...@gmail.com>
ha scritto:
> I still need to align the branch, but the release is complete. Using
> main-SNAPSHOT is not a problem, it's just a descriptor, by the way to avoid
> confusion I'll align there.
>
> Il giorno ven 7 gen 2022 alle ore 07:58 David Jencks <
> david.a.jencks@gmail.com> ha scritto:
>
>> The source tar.gz download looks fine to me, but the GitHub branch poms
>> (e.g. https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml <
>> https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml>) have
>> version main-SNAPSHOT instead of 0.6.1-SNAPSHOT (or whatever is correct),
>> and the dependencies in the kamelet yamls also have main-SNAPSHOT for the
>> util version.
>>
>> David Jencks
>
>
Re: Is camel-kamelets 0.6.0 release incomplete?
Posted by Andrea Cosentino <an...@gmail.com>.
I still need to align the branch, but the release is complete. Using
main-SNAPSHOT is not a problem, it's just a descriptor, by the way to avoid
confusion I'll align there.
Il giorno ven 7 gen 2022 alle ore 07:58 David Jencks <
david.a.jencks@gmail.com> ha scritto:
> The source tar.gz download looks fine to me, but the GitHub branch poms
> (e.g. https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml <
> https://github.com/apache/camel-kamelets/blob/0.6.x/pom.xml>) have
> version main-SNAPSHOT instead of 0.6.1-SNAPSHOT (or whatever is correct),
> and the dependencies in the kamelet yamls also have main-SNAPSHOT for the
> util version.
>
> David Jencks