You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/04/21 13:59:25 UTC
[GitHub] [cassandra-dtest] mfleming opened a new pull request #133: Remove references to run_dtests from README
mfleming opened a new pull request #133:
URL: https://github.com/apache/cassandra-dtest/pull/133
Newcomers to cassandra-dtest that look through `README.md` will see that the `run_dtests.py` script is the quickest way to get started running tests. Unfortunately, the script has a number of problems and I'm not sure it ever work properly after the move to the pytest framework.
## Process stdout/stderr buffering
Firstly, when I execute `run_dtests.py` I don't see any output after
```
$ ./run_dtests.py --dtest-tests paging_test.py
============================= test session starts ==============================
```
This looks likely to be because of the buffering that pytest does internally for stdout and stderr and because of the way that it's executed by `run_dtests.py`, i.e. I suspect that `run_dtests.py` is blocked on the following line for most of the execution because there's no data available in the pipe for stderr:
```
stderr_output = sp.stderr.readline()
```
## `--pytest-options` doesn't work
Secondly, the options specified in `--pytest-options` aren't actually passed through to pytest.
## Most devs run pytest directly
When I spoke to @ekaterinadimitrova2 it seemed like most developers just run the tests directly with pytest which would explain why `run_dtests.py` has bitrotted.
I've separated out the patches into two in case it makes sense to keep `run_dtests.py` around even if it's not referenced from `README.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] mfleming edited a comment on pull request #133: Remove references to run_dtests from README
Posted by GitBox <gi...@apache.org>.
mfleming edited a comment on pull request #133:
URL: https://github.com/apache/cassandra-dtest/pull/133#issuecomment-824929198
> I was thinking a bit about this. I don't think we should remove it but improve the wording.
> Probably we can say explicitly that developers should use pytest as this is just to run the tests getting back minimal info. WDYT?
It doesn't return any info from my testing other than the "test session starts" line, e.g.
```
$ ./run_dtests.py --dtest-tests cql_prepared_test.py
============================= test session starts ==============================
$
```
To me (as a newbie) this doesn't seem like a particularly user-friendly way to run the tests at all. It doesn't tell me where the logs live, doesn't provide any info on the test progress or even if the test passed/failed. In fact, if I patch `cql_prepared_test.py` to make the test fail immediately, I see the exact same output as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] michaelsembwever commented on pull request #133: Remove references to run_dtests from README
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #133:
URL: https://github.com/apache/cassandra-dtest/pull/133#issuecomment-824925168
It is used for listing tests still. For example see [here](https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L89)
But the changes to the README in this PR LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] mfleming commented on pull request #133: Remove references to run_dtests from README
Posted by GitBox <gi...@apache.org>.
mfleming commented on pull request #133:
URL: https://github.com/apache/cassandra-dtest/pull/133#issuecomment-824929198
> I was thinking a bit about this. I don't think we should remove it but improve the wording.
> Probably we can say explicitly that developers should use pytest as this is just to run the tests getting back minimal info. WDYT?
It doesn't return any info from my testing other than the "test session starts" line, e.g.
```
$ ./run_dtests.py --dtest-tests cql_prepared_test.py
============================= test session starts ==============================
$
```
To me (as a newbie) this doesn't seem like a particularly user-friendly way to run the test at all. It doesn't tell me where the logs, doesn't provide any info on the test progress or even if the test passed/failed. In fact, if I patch `cql_prepared_test.py` to fail immediately, I see the exact same output as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org