You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/30 03:12:42 UTC
[GitHub] [incubator-dolphinscheduler] nauu opened a new pull request #1634:
Add ParamUtilsTest which is the UT of ParamUtils
nauu opened a new pull request #1634: Add ParamUtilsTest which is the UT of ParamUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1634
## What is the purpose of the pull request
For #1465.
1. Add ParamUtilsTest.
2. Add a null check in the method convert.
3. Add the UT path to the root pom.
## Brief change log
- *Add ParamUtilsTest.java*
- *Edit ParamUtils.java*
- *Add the UT path to root pom.xml*
## Verify this pull request
This change added tests and can be verified as follows:
- *Added ParamUtilsTest to verify the change.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1634:
Add ParamUtilsTest which is the UT of ParamUtils
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1634: Add ParamUtilsTest which is the UT of ParamUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1634#issuecomment-569570766
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1634?src=pr&el=h1) Report
> Merging [#1634](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1634?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/6d4a3410c86feed171063b760aa4b504662c75a2?src=pr&el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1634?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1634 +/- ##
========================================
+ Coverage 8.11% 8.3% +0.18%
========================================
Files 282 282
Lines 13924 13926 +2
Branches 2254 2255 +1
========================================
+ Hits 1130 1156 +26
+ Misses 12676 12648 -28
- Partials 118 122 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1634?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ache/dolphinscheduler/server/utils/ParamUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1634/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1BhcmFtVXRpbHMuamF2YQ==) | `86.66% <100%> (+86.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1634?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1634?src=pr&el=footer). Last update [6d4a341...59f4b7f](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1634?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] khadgarmage merged pull request #1634:
Add ParamUtilsTest which is the UT of ParamUtils
Posted by GitBox <gi...@apache.org>.
khadgarmage merged pull request #1634: Add ParamUtilsTest which is the UT of ParamUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1634
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services