You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/07 00:45:01 UTC

[GitHub] [beam] robertwb commented on a change in pull request #16143: Avoid overriding explicit portable job submission disabling.

robertwb commented on a change in pull request #16143:
URL: https://github.com/apache/beam/pull/16143#discussion_r763535031



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -595,7 +595,10 @@ def _maybe_add_unified_worker_missing_options(self, options):
       if not debug_options.lookup_experiment('disable_runner_v2'):
         debug_options.add_experiment('beam_fn_api')
         debug_options.add_experiment('use_runner_v2')
-        debug_options.add_experiment('use_portable_job_submission')
+        if (not debug_options.lookup_experiment('use_portable_job_submission')

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org