You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "John Plevyak (JIRA)" <ji...@apache.org> on 2010/02/26 23:54:05 UTC

[jira] Created: (TS-222) Cache::open_write should use an options arg for flexability and shoudl allow SYNC writes

Cache::open_write should use an options arg for flexability and shoudl allow SYNC writes
----------------------------------------------------------------------------------------

                 Key: TS-222
                 URL: https://issues.apache.org/jira/browse/TS-222
             Project: Traffic Server
          Issue Type: Improvement
          Components: Cache
    Affects Versions: 2.1.0
            Reporter: John Plevyak
            Assignee: John Plevyak


Unix file open supports a number of options, e.g. O_DIRECT O_NOATIME etc.
Currently open_write takes one option "overwrite", but there are several other options
which would be nice, including CLOSE_COMPLETE (finalize the object when nbytes == ndone
and expect a close, preventing the head from being split from the data in cases where
the object is small) and SYNC which would call COMPLETE when the object has hit
the disk and would be recovered in the case of a crash.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-222) Cache::open_write should use an options arg for flexability and shoudl allow SYNC writes

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Plevyak updated TS-222:
----------------------------

    Attachment: ts-222-jp-v1.patch

Request for review.

This patch changes "overwrite" to be a generic "options" arg and
defines CACHE_WRITE_OPT_OVERWRITE as well as
CACHE_WRITE_OPT_CLOSE_COMPLETE and
CACHE_WRITE_OPT_SYNC.

> Cache::open_write should use an options arg for flexability and shoudl allow SYNC writes
> ----------------------------------------------------------------------------------------
>
>                 Key: TS-222
>                 URL: https://issues.apache.org/jira/browse/TS-222
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Cache
>    Affects Versions: 2.1.0
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>         Attachments: ts-222-jp-v1.patch
>
>
> Unix file open supports a number of options, e.g. O_DIRECT O_NOATIME etc.
> Currently open_write takes one option "overwrite", but there are several other options
> which would be nice, including CLOSE_COMPLETE (finalize the object when nbytes == ndone
> and expect a close, preventing the head from being split from the data in cases where
> the object is small) and SYNC which would call COMPLETE when the object has hit
> the disk and would be recovered in the case of a crash.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-222) Cache::open_write should use an options arg for flexability and shoudl allow SYNC writes

Posted by "George Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Paul updated TS-222:
---------------------------

    Fix Version/s: 2.1.0

> Cache::open_write should use an options arg for flexability and shoudl allow SYNC writes
> ----------------------------------------------------------------------------------------
>
>                 Key: TS-222
>                 URL: https://issues.apache.org/jira/browse/TS-222
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Cache
>    Affects Versions: 2.1.0
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.0
>
>         Attachments: ts-222-jp-v1.patch
>
>
> Unix file open supports a number of options, e.g. O_DIRECT O_NOATIME etc.
> Currently open_write takes one option "overwrite", but there are several other options
> which would be nice, including CLOSE_COMPLETE (finalize the object when nbytes == ndone
> and expect a close, preventing the head from being split from the data in cases where
> the object is small) and SYNC which would call COMPLETE when the object has hit
> the disk and would be recovered in the case of a crash.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TS-222) Cache::open_write should use an options arg for flexability and shoudl allow SYNC writes

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Plevyak resolved TS-222.
-----------------------------

    Resolution: Fixed

Committed revision 919125.


> Cache::open_write should use an options arg for flexability and shoudl allow SYNC writes
> ----------------------------------------------------------------------------------------
>
>                 Key: TS-222
>                 URL: https://issues.apache.org/jira/browse/TS-222
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Cache
>    Affects Versions: 2.1.0
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.0
>
>         Attachments: ts-222-jp-v1.patch
>
>
> Unix file open supports a number of options, e.g. O_DIRECT O_NOATIME etc.
> Currently open_write takes one option "overwrite", but there are several other options
> which would be nice, including CLOSE_COMPLETE (finalize the object when nbytes == ndone
> and expect a close, preventing the head from being split from the data in cases where
> the object is small) and SYNC which would call COMPLETE when the object has hit
> the disk and would be recovered in the case of a crash.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-222) Cache::open_write should use an options arg for flexability and shoudl allow SYNC writes

Posted by "George Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841385#action_12841385 ] 

George Paul commented on TS-222:
--------------------------------

Reviewed and tested patch 'ts-222-jp-v1.patch'. Looks good to commit.
-George

> Cache::open_write should use an options arg for flexability and shoudl allow SYNC writes
> ----------------------------------------------------------------------------------------
>
>                 Key: TS-222
>                 URL: https://issues.apache.org/jira/browse/TS-222
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Cache
>    Affects Versions: 2.1.0
>            Reporter: John Plevyak
>            Assignee: John Plevyak
>             Fix For: 2.1.0
>
>         Attachments: ts-222-jp-v1.patch
>
>
> Unix file open supports a number of options, e.g. O_DIRECT O_NOATIME etc.
> Currently open_write takes one option "overwrite", but there are several other options
> which would be nice, including CLOSE_COMPLETE (finalize the object when nbytes == ndone
> and expect a close, preventing the head from being split from the data in cases where
> the object is small) and SYNC which would call COMPLETE when the object has hit
> the disk and would be recovered in the case of a crash.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.