You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jack Cai (JIRA)" <ji...@apache.org> on 2009/07/29 08:58:14 UTC
[jira] Created: (GERONIMO-4769) Add English resource bundle for
Admin console
Add English resource bundle for Admin console
---------------------------------------------
Key: GERONIMO-4769
URL: https://issues.apache.org/jira/browse/GERONIMO-4769
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: console
Affects Versions: 2.1.5, 2.2
Reporter: Jack Cai
Priority: Minor
The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by Jack Cai <gr...@gmail.com>.
En, good idea. Agree to generate the en resources on the fly.
As to the "trick code", I don't see any in the current code. The JSPs soley
depends on the <fmt:message> tag to load the resource bundles. We could
reset system's default locale to "en_US", which is not a good idea to me
though.
On Wed, Jul 29, 2009 at 4:26 PM, Shawn Jiang (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736527#action_12736527]
>
> Shawn Jiang commented on GERONIMO-4769:
> ---------------------------------------
>
> Firstly, I'd like to fix the i18n resource bundle before fixing this
> because the i18n patch is very hard to create. : )
>
> Secondly, I agree with Ivan that we could copy and rename these resource
> file at build time instead of duplicated files. Seem only regex based move
> ant task could do the trick.
>
> > Add English resource bundle for Admin console
> > ---------------------------------------------
> >
> > Key: GERONIMO-4769
> > URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> > Project: Geronimo
> > Issue Type: Bug
> > Security Level: public(Regular issues)
> > Components: console
> > Affects Versions: 2.1.5, 2.2
> > Reporter: Jack Cai
> > Priority: Minor
> > Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_trunk.patch
> >
> >
> > The resource bundle search logic will consider default locale before
> falling back to the base resource bundle. This means if Geronimo is running
> on a Chinese OS with locale "zh_CN", when a user visits the admin console
> with "en_US" as the browser locale, the user will actually see the admin
> console in Chinese!
> > To avoid this problem, we shall duplicate the base resource bundles with
> the name *en.properties.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Assigned: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan reassigned GERONIMO-4769:
------------------------------
Assignee: Ivan
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Assignee: Ivan
> Priority: Minor
> Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_21_0804.patch, GERONIMO-4769_trunk.patch, GERONIMO-4769_trunk_0804.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Cai updated GERONIMO-4769:
-------------------------------
Attachment: GERONIMO-4769_21_0812.patch
GERONIMO-4769_trunk_command_0812.patch
GERONIMO-4769_trunk_0812.patch
Update the patch to adapt to the latest code. Also write commands for renaming resources .
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Assignee: Ivan
> Priority: Minor
> Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_21_0804.patch, GERONIMO-4769_21_0812.patch, GERONIMO-4769_21_command_0812.patch, GERONIMO-4769_trunk.patch, GERONIMO-4769_trunk_0804.patch, GERONIMO-4769_trunk_0812.patch, GERONIMO-4769_trunk_command_0812.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Cai updated GERONIMO-4769:
-------------------------------
Attachment: GERONIMO-4769_21_0804.patch
So this is another try based on the previous suggestions from Ivan and Shawn. I use the maven ant plugin to do the copies. For convenience I rename the base bundles to *_en.properties. The patch works well for me.
Please review.
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Priority: Minor
> Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_21_0804.patch, GERONIMO-4769_trunk.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Cai updated GERONIMO-4769:
-------------------------------
Attachment: GERONIMO-4769_trunk_0804.patch
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Priority: Minor
> Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_21_0804.patch, GERONIMO-4769_trunk.patch, GERONIMO-4769_trunk_0804.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan resolved GERONIMO-4769.
----------------------------
Resolution: Fixed
Fix Version/s: 2.2
2.1.5
Commit the patch to trunk At revision: 803804, and 2.1.5-SNAPSHOT At revision: 803807
Thanks, Jack !
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.1.5, 2.2
>
> Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_21_0804.patch, GERONIMO-4769_21_0812.patch, GERONIMO-4769_21_command_0812.patch, GERONIMO-4769_trunk.patch, GERONIMO-4769_trunk_0804.patch, GERONIMO-4769_trunk_0812.patch, GERONIMO-4769_trunk_command_0812.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736527#action_12736527 ]
Shawn Jiang commented on GERONIMO-4769:
---------------------------------------
Firstly, I'd like to fix the i18n resource bundle before fixing this because the i18n patch is very hard to create. : )
Secondly, I agree with Ivan that we could copy and rename these resource file at build time instead of duplicated files. Seem only regex based move ant task could do the trick.
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Priority: Minor
> Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_trunk.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Cai updated GERONIMO-4769:
-------------------------------
Attachment: GERONIMO-4769_trunk.patch
For trunk.
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Priority: Minor
> Attachments: GERONIMO-4769_21.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Cai updated GERONIMO-4769:
-------------------------------
Attachment: (was: GERONIMO-4769_trunk.patch)
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Priority: Minor
> Attachments: GERONIMO-4769_21.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Cai updated GERONIMO-4769:
-------------------------------
Attachment: GERONIMO-4769_21.patch
Simply duplicate the base bundles with the "_en" extension.
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Priority: Minor
> Attachments: GERONIMO-4769_21.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Cai updated GERONIMO-4769:
-------------------------------
Attachment: GERONIMO-4769_21_command_0812.patch
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Assignee: Ivan
> Priority: Minor
> Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_21_0804.patch, GERONIMO-4769_21_0812.patch, GERONIMO-4769_21_command_0812.patch, GERONIMO-4769_trunk.patch, GERONIMO-4769_trunk_0804.patch, GERONIMO-4769_trunk_0812.patch, GERONIMO-4769_trunk_command_0812.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Cai updated GERONIMO-4769:
-------------------------------
Attachment: GERONIMO-4769_trunk.patch
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Priority: Minor
> Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_trunk.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rex Wang closed GERONIMO-4769.
------------------------------
done. close it
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.1.5, 2.2
>
> Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_21_0804.patch, GERONIMO-4769_21_0812.patch, GERONIMO-4769_21_command_0812.patch, GERONIMO-4769_trunk.patch, GERONIMO-4769_trunk_0804.patch, GERONIMO-4769_trunk_0812.patch, GERONIMO-4769_trunk_command_0812.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4769) Add English resource bundle for
Admin console
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736494#action_12736494 ]
Ivan commented on GERONIMO-4769:
--------------------------------
I remember that we did some discussion about it in the past, and some trick codes are added to handle it, not sure why it does not work now.
Even if we need to keep two copies in the server, I would suggest to do it in the building time, maybe use a maven plugin, or it will be a big effort to maintaine the two copies.
> Add English resource bundle for Admin console
> ---------------------------------------------
>
> Key: GERONIMO-4769
> URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.5, 2.2
> Reporter: Jack Cai
> Priority: Minor
> Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_trunk.patch
>
>
> The resource bundle search logic will consider default locale before falling back to the base resource bundle. This means if Geronimo is running on a Chinese OS with locale "zh_CN", when a user visits the admin console with "en_US" as the browser locale, the user will actually see the admin console in Chinese!
> To avoid this problem, we shall duplicate the base resource bundles with the name *en.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.