You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/07 22:54:02 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
> Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.97%`.
> The diff coverage is `67.44%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9628 +/- ##
==========================================
- Coverage 70.93% 65.95% -4.98%
==========================================
Files 183 593 +410
Lines 17847 30642 +12795
Branches 0 3200 +3200
==========================================
+ Hits 12660 20211 +7551
- Misses 5187 10240 +5053
- Partials 0 191 +191
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.01% <67.44%> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
| [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
| [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `40.00% <ø> (ø)` | |
| [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...3106d17](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org