You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by ni...@apache.org on 2018/11/02 09:34:58 UTC
[02/12] ignite git commit: IGNITE-9312: Remove unnecessary
@SuppressWarnings annotation - Fixes #4632.
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemHandshakeSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemHandshakeSelfTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemHandshakeSelfTest.java
index 02c708b..cab318c 100644
--- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemHandshakeSelfTest.java
+++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemHandshakeSelfTest.java
@@ -231,7 +231,6 @@ public class IgniteHadoopFileSystemHandshakeSelfTest extends IgfsCommonAbstractT
* @param authority Authority.
* @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void checkInvalid(final String authority) throws Exception {
GridTestUtils.assertThrows(log, new Callable<Object>() {
@Override public Object call() throws Exception {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemShmemAbstractSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemShmemAbstractSelfTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemShmemAbstractSelfTest.java
index b5cf7be..1c75cfb 100644
--- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemShmemAbstractSelfTest.java
+++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemShmemAbstractSelfTest.java
@@ -61,7 +61,6 @@ public abstract class IgniteHadoopFileSystemShmemAbstractSelfTest extends Ignite
*
* @throws Exception If error occurred.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testOutOfResources() throws Exception {
final Collection<IpcEndpoint> eps = new LinkedList<>();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemShmemExternalToClientAbstractSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemShmemExternalToClientAbstractSelfTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemShmemExternalToClientAbstractSelfTest.java
index fa64ed7..bef23c0 100644
--- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemShmemExternalToClientAbstractSelfTest.java
+++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemShmemExternalToClientAbstractSelfTest.java
@@ -73,7 +73,6 @@ public abstract class IgniteHadoopFileSystemShmemExternalToClientAbstractSelfTes
*
* @throws Exception If error occurred.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testOutOfResources() throws Exception {
final Collection<IpcEndpoint> eps = new LinkedList<>();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/util/ChainedUserNameMapperSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/util/ChainedUserNameMapperSelfTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/util/ChainedUserNameMapperSelfTest.java
index a9d295f..0434ebb 100644
--- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/util/ChainedUserNameMapperSelfTest.java
+++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/util/ChainedUserNameMapperSelfTest.java
@@ -44,7 +44,6 @@ public class ChainedUserNameMapperSelfTest extends GridCommonAbstractTest {
*
* @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testNullMappers() throws Exception {
GridTestUtils.assertThrows(null, new Callable<Void>() {
@Override public Void call() throws Exception {
@@ -60,7 +59,6 @@ public class ChainedUserNameMapperSelfTest extends GridCommonAbstractTest {
*
* @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testNullMapperElement() throws Exception {
GridTestUtils.assertThrows(null, new Callable<Void>() {
@Override public Void call() throws Exception {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/DmlStatementsProcessor.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/DmlStatementsProcessor.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/DmlStatementsProcessor.java
index 31715f1..363b173 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/DmlStatementsProcessor.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/DmlStatementsProcessor.java
@@ -401,7 +401,7 @@ public class DmlStatementsProcessor {
* @return Number of rows in given INSERT statement.
* @throws IgniteCheckedException if failed.
*/
- @SuppressWarnings({"unchecked", "ConstantConditions"})
+ @SuppressWarnings({"unchecked"})
long streamUpdateQuery(String schemaName, IgniteDataStreamer streamer, PreparedStatement stmt, final Object[] args)
throws IgniteCheckedException {
idx.checkStatementStreamable(stmt);
@@ -484,7 +484,7 @@ public class DmlStatementsProcessor {
* @return Pair [number of successfully processed items; keys that have failed to be processed]
* @throws IgniteCheckedException if failed.
*/
- @SuppressWarnings({"ConstantConditions", "unchecked"})
+ @SuppressWarnings({"ConstantConditions"})
private UpdateResult executeUpdateStatement(String schemaName, final UpdatePlan plan,
SqlFieldsQuery fieldsQry, boolean loc, IndexingQueryFilter filters,
GridQueryCancel cancel) throws IgniteCheckedException {
@@ -726,7 +726,6 @@ public class DmlStatementsProcessor {
* @param loc Local query flag.
* @return Update plan.
*/
- @SuppressWarnings({"unchecked", "ConstantConditions"})
UpdatePlan getPlanForStatement(String schema, Connection conn, Prepared p, SqlFieldsQuery fieldsQry,
boolean loc, @Nullable Integer errKeysPos) throws IgniteCheckedException {
isDmlOnSchemaSupported(schema);
@@ -775,7 +774,6 @@ public class DmlStatementsProcessor {
* @param pageSize Batch size for streaming, anything <= 0 for single page operations.
* @return Results of DELETE (number of items affected AND keys that failed to be updated).
*/
- @SuppressWarnings({"unchecked", "ConstantConditions", "ThrowableResultOfMethodCallIgnored"})
private UpdateResult doDelete(GridCacheContext cctx, Iterable<List<?>> cursor, int pageSize)
throws IgniteCheckedException {
DmlBatchSender sender = new DmlBatchSender(cctx, pageSize, 1);
@@ -821,7 +819,6 @@ public class DmlStatementsProcessor {
* @return Pair [cursor corresponding to results of UPDATE (contains number of items affected); keys whose values
* had been modified concurrently (arguments for a re-run)].
*/
- @SuppressWarnings({"unchecked", "ThrowableResultOfMethodCallIgnored"})
private UpdateResult doUpdate(UpdatePlan plan, Iterable<List<?>> cursor, int pageSize)
throws IgniteCheckedException {
GridCacheContext cctx = plan.cacheContext();
@@ -914,7 +911,7 @@ public class DmlStatementsProcessor {
* @return Number of items affected.
* @throws IgniteCheckedException if failed, particularly in case of duplicate keys.
*/
- @SuppressWarnings({"unchecked", "ConstantConditions"})
+ @SuppressWarnings({"unchecked"})
private long doInsert(UpdatePlan plan, Iterable<List<?>> cursor, int pageSize) throws IgniteCheckedException {
GridCacheContext cctx = plan.cacheContext();
@@ -1110,7 +1107,6 @@ public class DmlStatementsProcessor {
* @return Iterator upon updated values.
* @throws IgniteCheckedException If failed.
*/
- @SuppressWarnings("unchecked")
public UpdateSourceIterator<?> prepareDistributedUpdate(String schema, Connection conn,
PreparedStatement stmt, SqlFieldsQuery qry,
IndexingQueryFilter filter, GridQueryCancel cancel, boolean local,
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2ResultSetIterator.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2ResultSetIterator.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2ResultSetIterator.java
index 814e83d..6f75603 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2ResultSetIterator.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2ResultSetIterator.java
@@ -142,7 +142,6 @@ public abstract class H2ResultSetIterator<T> extends GridCloseableIteratorAdapte
}
/** {@inheritDoc} */
- @SuppressWarnings("IteratorNextCanNotThrowNoSuchElementException")
@Override public T onNext() {
if (!hasNext())
throw new NoSuchElementException();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/IgniteH2Indexing.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/IgniteH2Indexing.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/IgniteH2Indexing.java
index 9ea1931..fcd3483 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/IgniteH2Indexing.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/IgniteH2Indexing.java
@@ -915,7 +915,6 @@ public class IgniteH2Indexing implements GridQueryIndexing {
}
/** {@inheritDoc} */
- @SuppressWarnings("SynchronizationOnLocalVariableOrMethodParameter")
@Override public void dynamicIndexDrop(final String schemaName, String idxName, boolean ifExists)
throws IgniteCheckedException{
String sql = H2Utils.indexDropSql(schemaName, idxName, ifExists);
@@ -1017,7 +1016,6 @@ public class IgniteH2Indexing implements GridQueryIndexing {
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public <K, V> GridCloseableIterator<IgniteBiTuple<K, V>> queryLocalText(String schemaName,
String cacheName, String qry, String typeName, IndexingQueryFilter filters) throws IgniteCheckedException {
H2TableDescriptor tbl = tableDescriptor(schemaName, cacheName, typeName);
@@ -1053,7 +1051,6 @@ public class IgniteH2Indexing implements GridQueryIndexing {
* @return Query result.
* @throws IgniteCheckedException If failed.
*/
- @SuppressWarnings("unchecked")
public GridQueryFieldsResult queryLocalSqlFields(String schemaName, String qry, @Nullable Collection<Object> params,
IndexingQueryFilter filter, boolean enforceJoinOrder, boolean startTx, int timeout,
GridQueryCancel cancel) throws IgniteCheckedException {
@@ -1075,7 +1072,6 @@ public class IgniteH2Indexing implements GridQueryIndexing {
* @return Query result.
* @throws IgniteCheckedException If failed.
*/
- @SuppressWarnings("unchecked")
GridQueryFieldsResult queryLocalSqlFields(final String schemaName, String qry,
@Nullable final Collection<Object> params, final IndexingQueryFilter filter, boolean enforceJoinOrder,
boolean startTx, int qryTimeout, final GridQueryCancel cancel,
@@ -2081,7 +2077,6 @@ public class IgniteH2Indexing implements GridQueryIndexing {
* @param tx Transaction.
* @throws IgniteCheckedException if failed.
*/
- @SuppressWarnings("ThrowFromFinallyBlock")
private void doCommit(@NotNull GridNearTxLocal tx) throws IgniteCheckedException {
try {
// TODO: Why checking for rollback only?
@@ -2098,7 +2093,6 @@ public class IgniteH2Indexing implements GridQueryIndexing {
* @param tx Transaction.
* @throws IgniteCheckedException if failed.
*/
- @SuppressWarnings("ThrowFromFinallyBlock")
private void doRollback(@NotNull GridNearTxLocal tx) throws IgniteCheckedException {
try {
tx.rollback();
@@ -3149,7 +3143,7 @@ public class IgniteH2Indexing implements GridQueryIndexing {
}
/** {@inheritDoc} */
- @SuppressWarnings({"NonThreadSafeLazyInitialization", "deprecation"})
+ @SuppressWarnings({"deprecation"})
@Override public void start(GridKernalContext ctx, GridSpinBusyLock busyLock) throws IgniteCheckedException {
if (log.isDebugEnabled())
log.debug("Starting cache query index...");
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/UpdateResult.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/UpdateResult.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/UpdateResult.java
index 5afbc16..32d84e1 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/UpdateResult.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/UpdateResult.java
@@ -42,7 +42,6 @@ public final class UpdateResult {
* @param cnt Updated rows count.
* @param errKeys Array of erroneous keys.
*/
- @SuppressWarnings("ConstantConditions")
public UpdateResult(long cnt, Object[] errKeys) {
this.cnt = cnt;
this.errKeys = U.firstNotNull(errKeys, X.EMPTY_OBJECT_ARRAY);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/database/H2PkHashIndex.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/database/H2PkHashIndex.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/database/H2PkHashIndex.java
index 5d877cd..ef6d5ff 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/database/H2PkHashIndex.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/database/H2PkHashIndex.java
@@ -124,7 +124,6 @@ public class H2PkHashIndex extends GridH2IndexBase {
}
/** {@inheritDoc} */
- @SuppressWarnings("StatementWithEmptyBody")
@Override public GridH2Row put(GridH2Row row) {
// Should not be called directly. Rows are inserted into underlying cache data stores.
assert false;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/ddl/DdlStatementsProcessor.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/ddl/DdlStatementsProcessor.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/ddl/DdlStatementsProcessor.java
index 94e39ef..8e029d0 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/ddl/DdlStatementsProcessor.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/ddl/DdlStatementsProcessor.java
@@ -119,7 +119,6 @@ public class DdlStatementsProcessor {
* @param cmd Command.
* @return Result.
*/
- @SuppressWarnings("unchecked")
public FieldsQueryCursor<List<?>> runDdlStatement(String sql, SqlCommand cmd) {
IgniteInternalFuture fut = null;
@@ -258,7 +257,7 @@ public class DdlStatementsProcessor {
* @param prepared Prepared.
* @return Cursor on query results.
*/
- @SuppressWarnings({"unchecked", "ThrowableResultOfMethodCallIgnored"})
+ @SuppressWarnings({"unchecked"})
public FieldsQueryCursor<List<?>> runDdlStatement(String sql, Prepared prepared) {
IgniteInternalFuture fut = null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlBatchSender.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlBatchSender.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlBatchSender.java
index 7c2a422..814a174 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlBatchSender.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlBatchSender.java
@@ -207,7 +207,7 @@ public class DmlBatchSender {
* @return Triple [number of rows actually changed; keys that failed to update (duplicates or concurrently
* updated ones); chain of exceptions for all keys whose processing resulted in error, or null for no errors].
*/
- @SuppressWarnings({"unchecked", "ConstantConditions"})
+ @SuppressWarnings({"unchecked"})
private DmlPageProcessingResult processPage(GridCacheContext cctx, Batch batch) {
Map<Object, EntryProcessorResult<Boolean>> res;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlPageProcessingErrorResult.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlPageProcessingErrorResult.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlPageProcessingErrorResult.java
index 02e7359..b1a443b 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlPageProcessingErrorResult.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlPageProcessingErrorResult.java
@@ -41,7 +41,6 @@ public final class DmlPageProcessingErrorResult {
private final SQLException ex;
/** */
- @SuppressWarnings("ConstantConditions")
public DmlPageProcessingErrorResult(@NotNull Object[] errKeys, SQLException ex, int exCnt) {
errKeys = U.firstNotNull(errKeys, X.EMPTY_OBJECT_ARRAY);
// When exceptions count must be zero, exceptions chain must be not null, and vice versa.
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlPageProcessingResult.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlPageProcessingResult.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlPageProcessingResult.java
index f2db3a7..783e6ad 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlPageProcessingResult.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/DmlPageProcessingResult.java
@@ -38,7 +38,6 @@ public final class DmlPageProcessingResult {
private final SQLException ex;
/** */
- @SuppressWarnings("ConstantConditions")
public DmlPageProcessingResult(long cnt, Object[] errKeys, @Nullable SQLException ex) {
this.cnt = cnt;
this.errKeys = U.firstNotNull(errKeys, X.EMPTY_OBJECT_ARRAY);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/FastUpdate.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/FastUpdate.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/FastUpdate.java
index 346ad48..b052da8 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/FastUpdate.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/FastUpdate.java
@@ -74,7 +74,7 @@ public final class FastUpdate {
* @return 1 if an item was affected, 0 otherwise.
* @throws IgniteCheckedException if failed.
*/
- @SuppressWarnings({"unchecked", "ConstantConditions"})
+ @SuppressWarnings({"unchecked"})
public UpdateResult execute(GridCacheAdapter cache, Object[] args) throws IgniteCheckedException {
Object key = keyArg.get(args);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/UpdatePlanBuilder.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/UpdatePlanBuilder.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/UpdatePlanBuilder.java
index cf7903e..d4be92c 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/UpdatePlanBuilder.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/dml/UpdatePlanBuilder.java
@@ -493,7 +493,6 @@ public final class UpdatePlanBuilder {
* @return The update plan for this command.
* @throws IgniteCheckedException if failed.
*/
- @SuppressWarnings("ConstantConditions")
public static UpdatePlan planForBulkLoad(SqlBulkLoadCommand cmd, GridH2Table tbl) throws IgniteCheckedException {
GridH2RowDescriptor desc = tbl.rowDescriptor();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridH2PrimaryScanIndex.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridH2PrimaryScanIndex.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridH2PrimaryScanIndex.java
index 6c49ac2..d10a79b 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridH2PrimaryScanIndex.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridH2PrimaryScanIndex.java
@@ -28,7 +28,6 @@ import java.util.HashSet;
/**
* Wrapper type for primary key.
*/
-@SuppressWarnings("PackageVisibleInnerClass")
public class GridH2PrimaryScanIndex extends GridH2ScanIndex<GridH2IndexBase> {
/** */
static final String SCAN_INDEX_NAME_SUFFIX = "__SCAN_";
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridH2Table.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridH2Table.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridH2Table.java
index a612b63..b2da670 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridH2Table.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridH2Table.java
@@ -334,7 +334,6 @@ public class GridH2Table extends TableBase {
}
/** {@inheritDoc} */
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
@Override public void removeChildrenAndResources(Session ses) {
lock(true);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridLuceneLockFactory.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridLuceneLockFactory.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridLuceneLockFactory.java
index e14a408..2442444 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridLuceneLockFactory.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/opt/GridLuceneLockFactory.java
@@ -30,7 +30,6 @@ import org.apache.lucene.store.LockObtainFailedException;
*/
public class GridLuceneLockFactory extends LockFactory {
/** */
- @SuppressWarnings("TypeMayBeWeakened")
private final GridConcurrentHashSet<String> locks = new GridConcurrentHashSet<>();
/** {@inheritDoc} */
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQueryParser.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQueryParser.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQueryParser.java
index 856951f..26a8dcc 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQueryParser.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQueryParser.java
@@ -130,7 +130,6 @@ import static org.apache.ignite.internal.processors.query.h2.sql.GridSqlType.fro
/**
* H2 Query parser.
*/
-@SuppressWarnings("TypeMayBeWeakened")
public class GridSqlQueryParser {
/** */
private static final GridSqlOperationType[] COMPARISON_TYPES =
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQuerySplitter.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQuerySplitter.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQuerySplitter.java
index b19dd14..2e27f93 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQuerySplitter.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQuerySplitter.java
@@ -999,7 +999,6 @@ public class GridSqlQuerySplitter {
* @param prnt Parent expression.
* @param childIdx Child index.
*/
- @SuppressWarnings("SuspiciousMethodCalls")
private void pushDownColumnsInExpression(
Set<GridSqlAlias> tblAliases,
Map<String,GridSqlAlias> cols,
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java
index f228111..c2ea9a8 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java
@@ -1341,7 +1341,6 @@ public class GridMapQueryExecutor {
* @param pageSize Page size.
* @param removeMapping Remove mapping flag.
*/
- @SuppressWarnings("unchecked")
private void sendNextPage(MapNodeResults nodeRess, ClusterNode node, MapQueryResults qr, int qry, int segmentId,
int pageSize, boolean removeMapping) {
try {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMergeIndex.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMergeIndex.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMergeIndex.java
index b70adb0..1c1cfaf 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMergeIndex.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMergeIndex.java
@@ -58,7 +58,6 @@ import static org.apache.ignite.IgniteSystemProperties.getInteger;
/**
* Merge index.
*/
-@SuppressWarnings("AtomicFieldUpdaterIssues")
public abstract class GridMergeIndex extends BaseIndex {
/** */
private static final int MAX_FETCH_SIZE = getInteger(IGNITE_SQL_MERGE_TABLE_MAX_SIZE, 10_000);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/MapQueryResults.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/MapQueryResults.java b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/MapQueryResults.java
index 76527bc..acb4f4e 100644
--- a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/MapQueryResults.java
+++ b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/MapQueryResults.java
@@ -63,7 +63,6 @@ class MapQueryResults {
* @param lazyWorker Lazy worker (if any).
* @param forUpdate {@code SELECT FOR UPDATE} flag.
*/
- @SuppressWarnings("unchecked")
MapQueryResults(IgniteH2Indexing h2, long qryReqId, int qrys, @Nullable GridCacheContext<?, ?> cctx,
@Nullable MapQueryLazyWorker lazyWorker, boolean forUpdate) {
this.forUpdate = forUpdate;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheQueryIndexDisabledSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheQueryIndexDisabledSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheQueryIndexDisabledSelfTest.java
index 525b688..14b1f67 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheQueryIndexDisabledSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheQueryIndexDisabledSelfTest.java
@@ -49,7 +49,6 @@ public class GridCacheQueryIndexDisabledSelfTest extends GridCommonAbstractTest
/**
* {@inheritDoc}
*/
- @SuppressWarnings("unchecked")
@Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractFieldsQuerySelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractFieldsQuerySelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractFieldsQuerySelfTest.java
index ce5c95e..3b15e81 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractFieldsQuerySelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractFieldsQuerySelfTest.java
@@ -1070,7 +1070,6 @@ public abstract class IgniteCacheAbstractFieldsQuerySelfTest extends GridCommonA
/**
* Person key.
*/
- @SuppressWarnings("UnusedDeclaration")
private static class PersonKey implements Serializable {
/** ID. */
@QuerySqlField
@@ -1106,7 +1105,6 @@ public abstract class IgniteCacheAbstractFieldsQuerySelfTest extends GridCommonA
/**
* Person.
*/
- @SuppressWarnings("UnusedDeclaration")
private static class Person implements Serializable {
/** Name. */
@QuerySqlField(index = false)
@@ -1163,7 +1161,6 @@ public abstract class IgniteCacheAbstractFieldsQuerySelfTest extends GridCommonA
/**
* Organization.
*/
- @SuppressWarnings("UnusedDeclaration")
private static class Organization implements Serializable {
/** ID. */
@QuerySqlField
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractQuerySelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractQuerySelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractQuerySelfTest.java
index ac9de6f..0f7fe3a 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractQuerySelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractQuerySelfTest.java
@@ -2226,7 +2226,6 @@ public abstract class IgniteCacheAbstractQuerySelfTest extends GridCommonAbstrac
/**
* Empty test object.
*/
- @SuppressWarnings("UnusedDeclaration")
private static class EmptyObject {
/** */
private int val;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheConfigVariationsQueryTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheConfigVariationsQueryTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheConfigVariationsQueryTest.java
index 4e6af25..152a325 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheConfigVariationsQueryTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheConfigVariationsQueryTest.java
@@ -164,7 +164,6 @@ public class IgniteCacheConfigVariationsQueryTest extends IgniteCacheConfigVaria
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("SubtractionInCompareTo")
public void testScanFilters() throws Exception {
runInAllDataModes(new TestRunnable() {
@Override public void run() throws Exception {
@@ -208,7 +207,6 @@ public class IgniteCacheConfigVariationsQueryTest extends IgniteCacheConfigVaria
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("SubtractionInCompareTo")
public void testLocalScanQuery() throws Exception {
runInAllDataModes(new TestRunnable() {
@Override public void run() throws Exception {
@@ -246,7 +244,6 @@ public class IgniteCacheConfigVariationsQueryTest extends IgniteCacheConfigVaria
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("SubtractionInCompareTo")
public void testScanQueryLocalFilter() throws Exception {
runInAllDataModes(new TestRunnable() {
@Override public void run() throws Exception {
@@ -293,7 +290,6 @@ public class IgniteCacheConfigVariationsQueryTest extends IgniteCacheConfigVaria
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("SubtractionInCompareTo")
public void testScanQueryPartitionFilter() throws Exception {
runInAllDataModes(new TestRunnable() {
@Override public void run() throws Exception {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheConfigurationPrimitiveTypesSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheConfigurationPrimitiveTypesSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheConfigurationPrimitiveTypesSelfTest.java
index 4ea537b..10fc58e 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheConfigurationPrimitiveTypesSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheConfigurationPrimitiveTypesSelfTest.java
@@ -30,7 +30,6 @@ import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
/**
*
*/
-@SuppressWarnings("unchecked")
public class IgniteCacheConfigurationPrimitiveTypesSelfTest extends GridCommonAbstractTest {
/** */
private static TcpDiscoveryIpFinder ipFinder = new TcpDiscoveryVmIpFinder(true);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheInsertSqlQuerySelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheInsertSqlQuerySelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheInsertSqlQuerySelfTest.java
index 0f72883..bc5686d 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheInsertSqlQuerySelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheInsertSqlQuerySelfTest.java
@@ -167,7 +167,6 @@ public class IgniteCacheInsertSqlQuerySelfTest extends IgniteCacheAbstractInsert
/**
*
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testDuplicateKeysException() {
final IgniteCache<Integer, Integer> p = ignite(0).cache("I2I");
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheNoClassQuerySelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheNoClassQuerySelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheNoClassQuerySelfTest.java
index 2eb66ee..4dc9116 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheNoClassQuerySelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheNoClassQuerySelfTest.java
@@ -42,7 +42,7 @@ public class IgniteCacheNoClassQuerySelfTest extends GridCommonAbstractTest {
private static final TcpDiscoveryIpFinder ipFinder = new TcpDiscoveryVmIpFinder(true);
/** {@inheritDoc} */
- @SuppressWarnings({"unchecked", "deprecation"})
+ @SuppressWarnings({"deprecation"})
@Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
IgniteConfiguration c = super.getConfiguration(igniteInstanceName);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheQueryH2IndexingLeakTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheQueryH2IndexingLeakTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheQueryH2IndexingLeakTest.java
index 59be138..14593de 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheQueryH2IndexingLeakTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheQueryH2IndexingLeakTest.java
@@ -134,7 +134,6 @@ public class IgniteCacheQueryH2IndexingLeakTest extends GridCommonAbstractTest {
/**
* @throws Exception If failed.
*/
- @SuppressWarnings({"TooBroadScope"})
public void testLeaksInIgniteH2IndexingOnTerminatedThread() throws Exception {
final IgniteCache<Integer, Integer> c = grid(0).cache(DEFAULT_CACHE_NAME);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheQueryMultiThreadedSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheQueryMultiThreadedSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheQueryMultiThreadedSelfTest.java
index 77c178a..8f28501 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheQueryMultiThreadedSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheQueryMultiThreadedSelfTest.java
@@ -56,7 +56,6 @@ import static org.apache.ignite.cache.CacheWriteSynchronizationMode.FULL_SYNC;
/**
* Multi-threaded tests for cache queries.
*/
-@SuppressWarnings("StatementWithEmptyBody")
public class IgniteCacheQueryMultiThreadedSelfTest extends GridCommonAbstractTest {
/** */
private static final boolean TEST_INFO = true;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCrossCachesJoinsQueryTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCrossCachesJoinsQueryTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCrossCachesJoinsQueryTest.java
index c80ae69..17a8ed3 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCrossCachesJoinsQueryTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCrossCachesJoinsQueryTest.java
@@ -425,7 +425,6 @@ public class IgniteCrossCachesJoinsQueryTest extends AbstractH2CompareQueryTest
* @param cacheList Caches.
* @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void checkAllCacheCombinations(
boolean idx,
List<List<TestCache>> cacheList) throws Exception {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/QueryEntityCaseMismatchTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/QueryEntityCaseMismatchTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/QueryEntityCaseMismatchTest.java
index 1b0546a..93ffa18 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/QueryEntityCaseMismatchTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/QueryEntityCaseMismatchTest.java
@@ -94,7 +94,6 @@ public class QueryEntityCaseMismatchTest extends GridCommonAbstractTest {
*
* @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testCacheInitializationFailure() throws Exception {
GridTestUtils.assertThrows(log, new Callable<Void>() {
@Override public Void call() throws Exception {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheDistributedQueryStopOnCancelOrTimeoutSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheDistributedQueryStopOnCancelOrTimeoutSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheDistributedQueryStopOnCancelOrTimeoutSelfTest.java
index 56fd7b8..c0e91f8 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheDistributedQueryStopOnCancelOrTimeoutSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheDistributedQueryStopOnCancelOrTimeoutSelfTest.java
@@ -233,7 +233,6 @@ public class IgniteCacheDistributedQueryStopOnCancelOrTimeoutSelfTest extends Gr
/**
* Validates clean state on all participating nodes after query cancellation.
*/
- @SuppressWarnings("unchecked")
private void checkCleanState() throws IgniteCheckedException {
for (int i = 0; i < GRIDS_CNT; i++) {
IgniteEx grid = grid(i);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheQueryStopOnCancelOrTimeoutDistributedJoinSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheQueryStopOnCancelOrTimeoutDistributedJoinSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheQueryStopOnCancelOrTimeoutDistributedJoinSelfTest.java
index 03a8d49..6c989dd 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheQueryStopOnCancelOrTimeoutDistributedJoinSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/IgniteCacheQueryStopOnCancelOrTimeoutDistributedJoinSelfTest.java
@@ -118,7 +118,6 @@ public class IgniteCacheQueryStopOnCancelOrTimeoutDistributedJoinSelfTest extend
/**
* Validates clean state on all participating nodes after query cancellation.
*/
- @SuppressWarnings("unchecked")
private void checkCleanState() throws IgniteCheckedException {
for (int i = 0; i < GRID_CNT; i++) {
IgniteEx grid = grid(i);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractConcurrentSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractConcurrentSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractConcurrentSelfTest.java
index 072f1ab..e6fd321 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractConcurrentSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractConcurrentSelfTest.java
@@ -1011,7 +1011,6 @@ public abstract class DynamicColumnsAbstractConcurrentSelfTest extends DynamicCo
*
* @param node Node.
*/
- @SuppressWarnings("SuspiciousMethodCalls")
private static CountDownLatch blockIndexing(Ignite node) {
UUID nodeId = ((IgniteEx)node).localNode().id();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractTest.java
index dd2d901..c106a98 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicColumnsAbstractTest.java
@@ -231,7 +231,6 @@ public abstract class DynamicColumnsAbstractTest extends GridCommonAbstractTest
* @param sql Statement.
* @param msg Expected message.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
protected void assertThrows(final Ignite node, final String sql, String msg) {
GridTestUtils.assertThrows(log, new Callable<Object>() {
@Override public Object call() throws Exception {
@@ -249,7 +248,6 @@ public abstract class DynamicColumnsAbstractTest extends GridCommonAbstractTest
* @param cls Expected exception class.
* @param msg Expected message.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
protected void assertThrowsAnyCause(final Ignite node, final String sql, Class<? extends Throwable> cls,
String msg) {
GridTestUtils.assertThrowsAnyCause(log, new Callable<Object>() {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractBasicSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractBasicSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractBasicSelfTest.java
index 93a653e..dfc353b 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractBasicSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractBasicSelfTest.java
@@ -47,7 +47,7 @@ import static org.apache.ignite.cache.CacheMode.REPLICATED;
/**
* Tests for dynamic index creation.
*/
-@SuppressWarnings({"unchecked", "ThrowableResultOfMethodCallIgnored"})
+@SuppressWarnings({"unchecked"})
public abstract class DynamicIndexAbstractBasicSelfTest extends DynamicIndexAbstractSelfTest {
/** Node index for regular server (coordinator). */
protected static final int IDX_SRV_CRD = 0;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractConcurrentSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractConcurrentSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractConcurrentSelfTest.java
index bf98491..ca47c7f 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractConcurrentSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractConcurrentSelfTest.java
@@ -979,7 +979,6 @@ public abstract class DynamicIndexAbstractConcurrentSelfTest extends DynamicInde
*
* @param node Node.
*/
- @SuppressWarnings("SuspiciousMethodCalls")
private static CountDownLatch blockIndexing(Ignite node) {
UUID nodeId = ((IgniteEx)node).localNode().id();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractSelfTest.java
index 0bab750..99e610b 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/DynamicIndexAbstractSelfTest.java
@@ -53,7 +53,7 @@ import org.apache.ignite.spi.discovery.tcp.ipfinder.vm.TcpDiscoveryVmIpFinder;
/**
* Tests for dynamic index creation.
*/
-@SuppressWarnings({"unchecked", "ThrowableResultOfMethodCallIgnored"})
+@SuppressWarnings({"unchecked"})
public abstract class DynamicIndexAbstractSelfTest extends AbstractSchemaSelfTest {
/** IP finder. */
private static final TcpDiscoveryIpFinder IP_FINDER = new TcpDiscoveryVmIpFinder(true);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicColumnsAbstractBasicSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicColumnsAbstractBasicSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicColumnsAbstractBasicSelfTest.java
index bd2f8d0..ef7b150 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicColumnsAbstractBasicSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicColumnsAbstractBasicSelfTest.java
@@ -382,7 +382,7 @@ public abstract class H2DynamicColumnsAbstractBasicSelfTest extends DynamicColum
/**
* Test that {@code ADD COLUMN} fails for non dynamic table that has flat value.
*/
- @SuppressWarnings({"unchecked", "ThrowFromFinallyBlock"})
+ @SuppressWarnings({"unchecked"})
public void testTestAlterTableOnFlatValueNonDynamicTable() {
CacheConfiguration c =
new CacheConfiguration("ints").setIndexedTypes(Integer.class, Integer.class)
@@ -401,7 +401,6 @@ public abstract class H2DynamicColumnsAbstractBasicSelfTest extends DynamicColum
/**
* Test that {@code ADD COLUMN} fails for dynamic table that has flat value.
*/
- @SuppressWarnings({"unchecked", "ThrowFromFinallyBlock"})
public void testTestAlterTableOnFlatValueDynamicTable() {
try {
run("CREATE TABLE TEST (id int primary key, x varchar) with \"wrap_value=false\"");
@@ -760,7 +759,6 @@ public abstract class H2DynamicColumnsAbstractBasicSelfTest extends DynamicColum
* @param sql Statement.
* @param msg Expected message.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
protected void assertThrows(final String sql, String msg) {
assertThrows(grid(nodeIndex()), sql, msg);
}
@@ -772,7 +770,6 @@ public abstract class H2DynamicColumnsAbstractBasicSelfTest extends DynamicColum
* @param cls Expected exception class.
* @param msg Expected message.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
protected void assertThrowsAnyCause(final String sql, Class<? extends Throwable> cls, String msg) {
assertThrowsAnyCause(grid(nodeIndex()), sql, cls, msg);
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicIndexingComplexAbstractTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicIndexingComplexAbstractTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicIndexingComplexAbstractTest.java
index e53a78d..6fa595f 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicIndexingComplexAbstractTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicIndexingComplexAbstractTest.java
@@ -88,7 +88,6 @@ public abstract class H2DynamicIndexingComplexAbstractTest extends DynamicIndexA
}
/** Do test. */
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testOperations() {
executeSql("CREATE TABLE person (id int, name varchar, age int, company varchar, city varchar, " +
"primary key (id, name, city)) WITH \"template=" + cacheMode.name() + ",atomicity=" + atomicityMode.name() +
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicTableSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicTableSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicTableSelfTest.java
index c97d934..0e06e35 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicTableSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicTableSelfTest.java
@@ -295,7 +295,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* Test that attempting to create a cache with a pre-existing name yields an error.
* @throws Exception if failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testDuplicateCustomCacheName() throws Exception {
client().getOrCreateCache("new");
@@ -450,7 +449,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* @param checkedTblName Table name to expect in error message.
* @param cmd Command to execute.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void assertCommandThrowsTableNotFound(String checkedTblName, final String cmd) {
final Throwable e = GridTestUtils.assertThrowsWithCause(new Callable<Object>() {
@Override public Object call() throws Exception {
@@ -473,10 +471,8 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* @param checkedTblName Table name to expect in error message.
* @param cmd Command to execute.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void assertDdlCommandThrowsTableNotFound(String checkedTblName, final String cmd) {
GridTestUtils.assertThrows(null, new Callable<Object>() {
- @SuppressWarnings("ConstantConditions")
@Override public Object call() throws Exception {
execute(cmd);
@@ -695,7 +691,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* Test that attempting to {@code CREATE TABLE} that already exists yields an error.
* @throws Exception if failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testCreateExistingTable() throws Exception {
execute("CREATE TABLE \"Person\" (\"id\" int, \"city\" varchar," +
" \"name\" varchar, \"surname\" varchar, \"age\" int, PRIMARY KEY (\"id\", \"city\")) WITH " +
@@ -755,7 +750,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* Test that attempting to execute {@code DROP TABLE} via API of cache being dropped yields an error.
* @throws Exception if failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testCacheSelfDrop() throws Exception {
execute("CREATE TABLE IF NOT EXISTS \"Person\" (\"id\" int, \"city\" varchar," +
" \"name\" varchar, \"surname\" varchar, \"age\" int, PRIMARY KEY (\"id\", \"city\")) WITH " +
@@ -788,7 +782,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* Test that attempting to {@code DROP TABLE} that does not exist yields an error.
* @throws Exception if failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testDropMissingTable() throws Exception {
GridTestUtils.assertThrows(null, new Callable<Object>() {
@Override public Object call() throws Exception {
@@ -803,7 +796,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* Check that {@code DROP TABLE} for caches not created with {@code CREATE TABLE} yields an error.
* @throws Exception if failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testDropNonDynamicTable() throws Exception {
GridTestUtils.assertThrows(null, new Callable<Object>() {
@Override public Object call() throws Exception {
@@ -819,7 +811,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* Test that attempting to destroy via cache API a cache created via SQL yields an error.
* @throws Exception if failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testDestroyDynamicSqlCache() throws Exception {
execute("CREATE TABLE \"Person\" (\"id\" int, \"city\" varchar," +
" \"name\" varchar, \"surname\" varchar, \"age\" int, PRIMARY KEY (\"id\", \"city\")) WITH " +
@@ -840,7 +831,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* SQL flag does not match that of cache with the same name that is already started, yields an error.
* @throws Exception if failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testSqlFlagCompatibilityCheck() throws Exception {
execute("CREATE TABLE \"Person\" (\"id\" int, \"city\" varchar, \"name\" varchar, \"surname\" varchar, " +
"\"age\" int, PRIMARY KEY (\"id\", \"city\")) WITH \"template=cache\"");
@@ -861,7 +851,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* Tests index name conflict check in discovery thread.
* @throws Exception if failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testIndexNameConflictCheckDiscovery() throws Exception {
execute(grid(0), "CREATE TABLE \"Person\" (id int primary key, name varchar)");
@@ -890,7 +879,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* Tests table name conflict check in {@link DdlStatementsProcessor}.
* @throws Exception if failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testTableNameConflictCheckSql() throws Exception {
execute(grid(0), "CREATE TABLE \"Person\" (id int primary key, name varchar)");
@@ -991,7 +979,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
/**
* Test various cases of affinity key column specification.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testAffinityKeyCaseSensitivity() {
execute("CREATE TABLE \"A\" (\"name\" varchar primary key, \"code\" int) WITH wrap_key,wrap_value," +
"\"affinity_key='name'\"");
@@ -1053,7 +1040,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
/**
* Tests that attempting to specify an affinity key that actually is a value column yields an error.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testAffinityKeyNotKeyColumn() {
// Error arises because user has specified case sensitive affinity column name
GridTestUtils.assertThrows(null, new Callable<Object>() {
@@ -1068,7 +1054,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
/**
* Tests that attempting to specify an affinity key that actually is a value column yields an error.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testAffinityKeyNotFound() {
// Error arises because user has specified case sensitive affinity column name
GridTestUtils.assertThrows(null, new Callable<Object>() {
@@ -1477,7 +1462,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* @param params Engine parameters.
* @param expErrMsg Expected error message.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void assertCreateTableWithParamsThrows(final String params, String expErrMsg) {
GridTestUtils.assertThrows(null, new Callable<Object>() {
@Override public Object call() throws Exception {
@@ -1493,7 +1477,6 @@ public class H2DynamicTableSelfTest extends AbstractSchemaSelfTest {
* @param cmd Command.
* @param expErrMsg Expected error message.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void assertDdlCommandThrows(final String cmd, String expErrMsg) {
GridTestUtils.assertThrows(null, new Callable<Object>() {
@Override public Object call() throws Exception {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/QueryEntityValidationSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/QueryEntityValidationSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/QueryEntityValidationSelfTest.java
index c8f6706..5f24191 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/QueryEntityValidationSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/QueryEntityValidationSelfTest.java
@@ -33,7 +33,6 @@ import java.util.concurrent.Callable;
/**
* Tests for query entity validation.
*/
-@SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public class QueryEntityValidationSelfTest extends GridCommonAbstractTest {
/** Cache name. */
private static final String CACHE_NAME = "cache";
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/SqlTransactionsCommandsWithMvccEnabledSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/SqlTransactionsCommandsWithMvccEnabledSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/SqlTransactionsCommandsWithMvccEnabledSelfTest.java
index fdca241..3ac94c8 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/SqlTransactionsCommandsWithMvccEnabledSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/SqlTransactionsCommandsWithMvccEnabledSelfTest.java
@@ -180,7 +180,6 @@ public class SqlTransactionsCommandsWithMvccEnabledSelfTest extends AbstractSche
/**
* Test that attempting to perform a cache API operation from within an SQL transaction fails.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void checkCacheOperationThrows(final String opName, final Object... args) {
execute(node(), "BEGIN");
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/SqlTransactionsSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/SqlTransactionsSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/SqlTransactionsSelfTest.java
index fbc07c3..e225f28 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/SqlTransactionsSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/SqlTransactionsSelfTest.java
@@ -181,7 +181,6 @@ public class SqlTransactionsSelfTest extends AbstractSchemaSelfTest {
/**
* Test that attempting to perform a cache API operation from within an SQL transaction fails.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void checkCacheOperationThrows(final String opName, final Object... args) {
execute(node(), "BEGIN");
@@ -264,7 +263,6 @@ public class SqlTransactionsSelfTest extends AbstractSchemaSelfTest {
/**
* Test that attempting to perform a cache PUT operation from within an SQL transaction fails.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testCacheOperationsFromSqlTransaction() {
checkCacheOperationThrows("get", 1);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccAbstractSqlCoordinatorFailoverTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccAbstractSqlCoordinatorFailoverTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccAbstractSqlCoordinatorFailoverTest.java
index c449ee2..5eac352 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccAbstractSqlCoordinatorFailoverTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccAbstractSqlCoordinatorFailoverTest.java
@@ -26,7 +26,6 @@ import static org.apache.ignite.transactions.TransactionIsolation.REPEATABLE_REA
/**
* Mvcc SQL API coordinator failover test.
*/
-@SuppressWarnings("unchecked")
public abstract class CacheMvccAbstractSqlCoordinatorFailoverTest extends CacheMvccAbstractBasicCoordinatorFailoverTest {
/**
* @throws Exception If failed.
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccSelectForUpdateQueryAbstractTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccSelectForUpdateQueryAbstractTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccSelectForUpdateQueryAbstractTest.java
index 16b45ab..0d3ff7e 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccSelectForUpdateQueryAbstractTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/mvcc/CacheMvccSelectForUpdateQueryAbstractTest.java
@@ -275,7 +275,7 @@ public abstract class CacheMvccSelectForUpdateQueryAbstractTest extends CacheMvc
* @param locked Whether the key is locked
* @throws Exception if failed.
*/
- @SuppressWarnings({"ThrowableNotThrown", "unchecked"})
+ @SuppressWarnings({"unchecked"})
private void checkLocks(String cacheName, List<Integer> keys, boolean locked) throws Exception {
Ignite node = ignite(2);
IgniteCache cache = node.cache(cacheName);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/client/ClientConnectorConfigurationValidationSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/client/ClientConnectorConfigurationValidationSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/client/ClientConnectorConfigurationValidationSelfTest.java
index 8ce334e..6ca3030 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/client/ClientConnectorConfigurationValidationSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/client/ClientConnectorConfigurationValidationSelfTest.java
@@ -277,7 +277,6 @@ public class ClientConnectorConfigurationValidationSelfTest extends GridCommonAb
*
* @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testDisabled() throws Exception {
IgniteConfiguration cfg = baseConfiguration();
@@ -317,7 +316,6 @@ public class ClientConnectorConfigurationValidationSelfTest extends GridCommonAb
*
* @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testJdbcConnectionDisabled() throws Exception {
IgniteConfiguration cfg = baseConfiguration();
@@ -342,7 +340,6 @@ public class ClientConnectorConfigurationValidationSelfTest extends GridCommonAb
*
* @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testJdbcConnectionDisabledForDaemon() throws Exception {
final IgniteConfiguration cfg = baseConfiguration().setDaemon(true);
@@ -395,7 +392,6 @@ public class ClientConnectorConfigurationValidationSelfTest extends GridCommonAb
* @param cliConnCfg Client connector configuration.
* @param success Success flag. * @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void check(ClientConnectorConfiguration cliConnCfg, boolean success) throws Exception {
final IgniteConfiguration cfg = baseConfiguration();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/database/IgnitePersistentStoreSchemaLoadTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/database/IgnitePersistentStoreSchemaLoadTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/database/IgnitePersistentStoreSchemaLoadTest.java
index b64910c..4671698 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/database/IgnitePersistentStoreSchemaLoadTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/database/IgnitePersistentStoreSchemaLoadTest.java
@@ -144,7 +144,6 @@ public class IgnitePersistentStoreSchemaLoadTest extends GridCommonAbstractTest
}
/** */
- @SuppressWarnings("unchecked")
public void testDynamicSchemaChangesPersistenceWithStaticCache() throws Exception {
IgniteEx node = startGrid(getConfigurationWithStaticCache(getTestIgniteInstanceName(0)));
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteSqlSchemaIndexingTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteSqlSchemaIndexingTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteSqlSchemaIndexingTest.java
index 2dee617..63451cd 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteSqlSchemaIndexingTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteSqlSchemaIndexingTest.java
@@ -114,7 +114,6 @@ public class IgniteSqlSchemaIndexingTest extends GridCommonAbstractTest {
*
* @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testCustomSchemaMultipleCachesTablesCollision() throws Exception {
//TODO: Rewrite with dynamic cache creation, and GRID start in #beforeTest after resolve of
//TODO: https://issues.apache.org/jira/browse/IGNITE-1094
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteSqlSkipReducerOnUpdateDmlSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteSqlSkipReducerOnUpdateDmlSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteSqlSkipReducerOnUpdateDmlSelfTest.java
index 12def67..0a41d94 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteSqlSkipReducerOnUpdateDmlSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/IgniteSqlSkipReducerOnUpdateDmlSelfTest.java
@@ -61,7 +61,7 @@ import static org.apache.ignite.events.EventType.EVT_CACHE_QUERY_EXECUTED;
/**
* Tests for distributed DML.
*/
-@SuppressWarnings({"unchecked", "ThrowableResultOfMethodCallIgnored"})
+@SuppressWarnings({"unchecked"})
public class IgniteSqlSkipReducerOnUpdateDmlSelfTest extends GridCommonAbstractTest {
/** IP finder. */
private static final TcpDiscoveryVmIpFinder IP_FINDER = new TcpDiscoveryVmIpFinder(true);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/LazyQuerySelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/LazyQuerySelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/LazyQuerySelfTest.java
index d5cc0eb..d6e4a24 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/LazyQuerySelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/LazyQuerySelfTest.java
@@ -315,7 +315,6 @@ public class LazyQuerySelfTest extends GridCommonAbstractTest {
* @param qry Query.
* @return Cursor.
*/
- @SuppressWarnings("unchecked")
private static FieldsQueryCursor<List<?>> execute(Ignite node, SqlFieldsQuery qry) {
return cache(node).query(qry.setLazy(true));
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/AbstractH2CompareQueryTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/AbstractH2CompareQueryTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/AbstractH2CompareQueryTest.java
index b1d5842..dd53fe9 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/AbstractH2CompareQueryTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/AbstractH2CompareQueryTest.java
@@ -65,7 +65,6 @@ public abstract class AbstractH2CompareQueryTest extends GridCommonAbstractTest
protected static Connection conn;
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
IgniteConfiguration c = super.getConfiguration(igniteInstanceName);
@@ -221,7 +220,6 @@ public abstract class AbstractH2CompareQueryTest extends GridCommonAbstractTest
* @return Result set after SQL query execution.
* @throws SQLException If exception.
*/
- @SuppressWarnings("unchecked")
protected static List<List<?>> compareQueryRes0(IgniteCache cache, String sql, @Nullable Object[] args,
Ordering ordering) throws SQLException {
return compareQueryRes0(cache, sql, false, args, ordering);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/GridQueryParsingTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/GridQueryParsingTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/GridQueryParsingTest.java
index de77150..ca24e57 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/GridQueryParsingTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/GridQueryParsingTest.java
@@ -75,7 +75,6 @@ public class GridQueryParsingTest extends GridCommonAbstractTest {
private static Ignite ignite;
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
IgniteConfiguration c = super.getConfiguration(igniteInstanceName);
@@ -698,7 +697,6 @@ public class GridQueryParsingTest extends GridCommonAbstractTest {
* @param exCls Exception class.
* @param msg Expected message.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void assertParseThrows(final String sql, Class<? extends Exception> exCls, String msg) {
GridTestUtils.assertThrows(null, new Callable<Object>() {
@Override public Object call() throws Exception {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/H2CompareBigQueryTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/H2CompareBigQueryTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/H2CompareBigQueryTest.java
index 50b71b5..79ef96c 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/H2CompareBigQueryTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/h2/sql/H2CompareBigQueryTest.java
@@ -161,7 +161,6 @@ public class H2CompareBigQueryTest extends AbstractH2CompareQueryTest {
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override protected void createCaches() {
cacheCustOrd = ignite.cache("custord");
cacheReplOrd = ignite.cache("replord");
@@ -171,7 +170,6 @@ public class H2CompareBigQueryTest extends AbstractH2CompareQueryTest {
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override protected void initCacheAndDbData() throws SQLException {
final AtomicInteger idGen = new AtomicInteger();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/sql/IgniteCachePartitionedAtomicColumnConstraintsTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/sql/IgniteCachePartitionedAtomicColumnConstraintsTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/sql/IgniteCachePartitionedAtomicColumnConstraintsTest.java
index 601090f..3715cf7 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/sql/IgniteCachePartitionedAtomicColumnConstraintsTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/sql/IgniteCachePartitionedAtomicColumnConstraintsTest.java
@@ -369,7 +369,6 @@ public class IgniteCachePartitionedAtomicColumnConstraintsTest extends GridCommo
}
/** */
- @SuppressWarnings("UnusedDeclaration")
private static class Organization implements Serializable {
/** Name. */
private final String name;
@@ -383,7 +382,6 @@ public class IgniteCachePartitionedAtomicColumnConstraintsTest extends GridCommo
}
/** */
- @SuppressWarnings("UnusedDeclaration")
private static class Address implements Serializable {
/** Name. */
private final String address;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/internal/processors/sql/SqlConnectorConfigurationValidationSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/sql/SqlConnectorConfigurationValidationSelfTest.java b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/sql/SqlConnectorConfigurationValidationSelfTest.java
index 4d1b333..7890ab6 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/internal/processors/sql/SqlConnectorConfigurationValidationSelfTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/internal/processors/sql/SqlConnectorConfigurationValidationSelfTest.java
@@ -163,7 +163,7 @@ public class SqlConnectorConfigurationValidationSelfTest extends GridCommonAbstr
* @param sqlCfg SQL configuration.
* @param success Success flag. * @throws Exception If failed.
*/
- @SuppressWarnings({"ThrowableResultOfMethodCallIgnored", "unchecked"})
+ @SuppressWarnings({"unchecked"})
private void check(SqlConnectorConfiguration sqlCfg, boolean success) throws Exception {
final IgniteConfiguration cfg = super.getConfiguration();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/indexing/src/test/java/org/apache/ignite/loadtests/h2indexing/FetchingQueryCursorStressTest.java
----------------------------------------------------------------------
diff --git a/modules/indexing/src/test/java/org/apache/ignite/loadtests/h2indexing/FetchingQueryCursorStressTest.java b/modules/indexing/src/test/java/org/apache/ignite/loadtests/h2indexing/FetchingQueryCursorStressTest.java
index 8a73a8e..ce95634 100644
--- a/modules/indexing/src/test/java/org/apache/ignite/loadtests/h2indexing/FetchingQueryCursorStressTest.java
+++ b/modules/indexing/src/test/java/org/apache/ignite/loadtests/h2indexing/FetchingQueryCursorStressTest.java
@@ -214,7 +214,6 @@ public class FetchingQueryCursorStressTest {
}
/** {@inheritDoc} */
- @SuppressWarnings("InfiniteLoopStatement")
@Override public void run() {
System.out.println("Executor started: " + Thread.currentThread().getName());
@@ -250,7 +249,6 @@ public class FetchingQueryCursorStressTest {
*/
private static class ThroughputPrinter implements Runnable {
/** {@inheritDoc} */
- @SuppressWarnings("InfiniteLoopStatement")
@Override public void run() {
while (error.get()==null) {
long before = CNT.get();