You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jablko <gi...@git.apache.org> on 2017/01/13 21:22:02 UTC
[GitHub] trafficserver pull request #1328: Replace gethostbyname_r() with getaddrinfo...
GitHub user jablko opened a pull request:
https://github.com/apache/trafficserver/pull/1328
Replace gethostbyname_r() with getaddrinfo()
Fixes #1312
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jablko/trafficserver gethostbyname_r
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1328
----
commit 9901a9e243e7e659552b42c0e2880374d59dd38f
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2017-01-13T21:17:48Z
Replace gethostbyname_r() with getaddrinfo()
Fixes #1312
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the issue:
https://github.com/apache/trafficserver/pull/1328
This looks good to me! :+1:
Thanks Jack
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1328
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1336/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by jablko <gi...@git.apache.org>.
Github user jablko commented on the issue:
https://github.com/apache/trafficserver/pull/1328
@bgaff Thanks! I messaged @jirib to see if building Traffic Server works for him now. This is the last of the four issues he reported, but yeah, I suspect there'll be more once his build gets past this point.
Either way, I think this change is productive, since 1) it moves a step closer to building on this platform -- OpenBSD doesn't implement gethostbyname_r(), 2) "The gethostbyname*() and gethostbyaddr*() functions are obsolete." at least according to [1]. "Applications should use getaddrinfo(3) and getnameinfo(3) instead.", and 3) this is the only occurrence of gethostbyname_r(), whereas we already depend on getaddrinfo() -- it's used elsewhere in the code.
[1] https://linux.die.net/man/3/gethostbyname_r
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1328
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1360/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1328
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1228/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1328
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1254/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by jablko <gi...@git.apache.org>.
Github user jablko commented on the issue:
https://github.com/apache/trafficserver/pull/1328
I agree with @bgaff.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the issue:
https://github.com/apache/trafficserver/pull/1328
Sure I'll review this very soon. Was this the final dependency for openbsd? I know when I was looking into it way back when it looked like this was only going to be one piece of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1328: Replace gethostbyname_r() with getaddrinfo...
Posted by jablko <gi...@git.apache.org>.
Github user jablko closed the pull request at:
https://github.com/apache/trafficserver/pull/1328
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1328
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1334/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1328
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1361/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1328
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1335/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1328
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1230/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1328
Are you guys comfortable with cherry-picking this to 7.1.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1328
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1229/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the issue:
https://github.com/apache/trafficserver/pull/1328
Shall I merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the issue:
https://github.com/apache/trafficserver/pull/1328
I dont think it's a good idea personally. The patch is trivial to backport and the only known benefit is openbsd support. IMO risk isn't worth the reward, just my two cents.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by jirib <gi...@git.apache.org>.
Github user jirib commented on the issue:
https://github.com/apache/trafficserver/pull/1328
OpenBSD amd64 build passes this stage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1328
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1253/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Posted by jablko <gi...@git.apache.org>.
Github user jablko commented on the issue:
https://github.com/apache/trafficserver/pull/1328
Thanks @bgaff and @jirib! Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---