You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/15 10:36:00 UTC

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17664: [fix][metadata] Set revalidateAfterReconnection true for certain failures

mattisonchao commented on code in PR #17664:
URL: https://github.com/apache/pulsar/pull/17664#discussion_r971821216


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/ResourceLockImpl.java:
##########
@@ -196,6 +196,7 @@ synchronized void lockWasInvalidated() {
                             // We failed to revalidate the lock due to connectivity issue

Review Comment:
   Plus, I think we also need to handle `LockBusyException` here to avoid forgetting to complete `expiredFuture`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org