You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/27 13:56:20 UTC

[GitHub] [airflow] rwitzel opened a new pull request #11887: Support consistent timeout for retried sensor

rwitzel opened a new pull request #11887:
URL: https://github.com/apache/airflow/pull/11887


   Why? If the Airflow scheduler is restarted (e.g. due to
   rollout of a new Kubernetes version), then the timeout
   behaviour of a sensor should not be affected.
   But before the code change, the timer would start from
   zero again when the sensor is retried. This was unexpected.
   
   Solution: When a sensor is retried, then the sensor
   uses the start date of the earliest try to justify
   a time-out. To stay backwards-compatible, the new behaviour
   is only active when explicitly activated for that sensor.
   
   Note: The exponential backoff feature for poking still uses
   the start date of the current try. This is to keep the
   code change small. No issues expected from that.
   
   related: #9232 (the linked issue cares about execution_timeout for tasks
   in general, not only sensors)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] stale[bot] commented on pull request #11887: Support consistent timeout for retried sensor

Posted by GitBox <gi...@apache.org>.

stale[bot] commented on pull request #11887:
URL: https://github.com/apache/airflow/pull/11887#issuecomment-751239943


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] closed pull request #11887: Support consistent timeout for retried sensor

Posted by GitBox <gi...@apache.org>.

github-actions[bot] closed pull request #11887:
URL: https://github.com/apache/airflow/pull/11887


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11887: Support consistent timeout for retried sensor

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #11887:
URL: https://github.com/apache/airflow/pull/11887#issuecomment-724235441


   [The Workflow run](https://github.com/apache/airflow/actions/runs/354617726) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11887: Support consistent timeout for retried sensor

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #11887:
URL: https://github.com/apache/airflow/pull/11887#issuecomment-807788310


   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] rwitzel commented on pull request #11887: Support consistent timeout for retried sensor

Posted by GitBox <gi...@apache.org>.

rwitzel commented on pull request #11887:
URL: https://github.com/apache/airflow/pull/11887#issuecomment-717282835


   I am not so happy with the name of the new property. So I am open for alternatives. 
   
   Here some alternative suggestions for `timeout_fullspan: bool = False`:
   * restore_timeout : bool = False
   * restore_startdate : bool = False
   * earliest_start_date_for_timeout : bool = False
   * restore_timer: bool = False
   * consistent_timeout: bool = False
   * time_sum_of_tries: bool = False
   * include_previous_tries: bool = False
   * ignore_previous_tries: bool = True
   * timeout_for_current_try: bool = True
   
   Let me know your preferences.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11887: Support consistent timeout for retried sensor

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #11887:
URL: https://github.com/apache/airflow/pull/11887#issuecomment-717260972

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org