You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/09 01:20:00 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #18847: Handle leading slash in samba path

uranusjr commented on a change in pull request #18847:
URL: https://github.com/apache/airflow/pull/18847#discussion_r725409759



##########
File path: airflow/providers/samba/hooks/samba.py
##########
@@ -80,7 +80,7 @@ def __exit__(self, exc_type, exc_value, traceback):
         self._connection_cache.clear()
 
     def _join_path(self, path):
-        return f"//{posixpath.join(self._host, self._share, path)}"
+        return f"//{posixpath.join(self._host, self._share, path.strip('/'))}"

Review comment:
       ```suggestion
           return f"//{posixpath.join(self._host, self._share, path.lstrip('/'))}"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org