You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by na...@apache.org on 2001/03/10 06:13:41 UTC
cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler IncludeGenerator.java
nacho 01/03/09 21:13:41
Modified: src/share/org/apache/jasper/compiler IncludeGenerator.java
Log:
Fix for Bug#284
<jsp:include> error message is not descriptive BugRat Report#529
Submitted by : katkere@praja.com (Arun Katkere)
Revision Changes Path
1.7 +16 -16 jakarta-tomcat/src/share/org/apache/jasper/compiler/IncludeGenerator.java
Index: IncludeGenerator.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/IncludeGenerator.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- IncludeGenerator.java 2001/01/07 19:24:17 1.6
+++ IncludeGenerator.java 2001/03/10 05:13:40 1.7
@@ -84,29 +84,29 @@
boolean isExpression = false;
Hashtable params;
- public IncludeGenerator(Mark start, Hashtable attrs, Hashtable param)
- throws JasperException
- {
- if (attrs.size() != 2)
- throw new CompileException(start,
- Constants.getString("jsp.error.include.tag"));
-
+ public IncludeGenerator(Mark start, Hashtable attrs, Hashtable param )
+ throws JasperException {
page = (String) attrs.get("page");
- if (page == null)
- throw new CompileException(start,
- Constants.getString("jsp.error.include.tag"));
-
+ if (page == null){
+ throw new CompileException(start,
+ Constants.getString("jsp.error.include.tag"));
+ }
String flush = (String) attrs.get("flush");
- if (flush == null)
+ if (flush == null){
throw new CompileException(start,
Constants.getString("jsp.error.include.noflush"));
-
- if (!flush.equals("true"))
+ }
+ if (!flush.equals("true")){
throw new CompileException(start,
Constants.getString("jsp.error.include.badflush"));
+ }
+ if (attrs.size() != 2){
+ throw new CompileException(start,
+ Constants.getString("jsp.error.include.tag"));
+ }
- this.params = param;
- isExpression = JspUtil.isExpression (page);
+ this.params = param;
+ isExpression = JspUtil.isExpression (page);
}
public void generate(ServletWriter writer, Class phase) {
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, email: tomcat-dev-help@jakarta.apache.org