You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/10/06 23:31:44 UTC
[jira] Created: (HADOOP-4354) Separate
TestDatanodeDeath.testDatanodeDeath() into 4 tests
Separate TestDatanodeDeath.testDatanodeDeath() into 4 tests
-----------------------------------------------------------
Key: HADOOP-4354
URL: https://issues.apache.org/jira/browse/HADOOP-4354
Project: Hadoop Core
Issue Type: Sub-task
Components: test
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
Priority: Blocker
Fix For: 0.19.0
TestDatanodeDeath fails occasionally as reported in HADOOP-4278. TestDatanodeDeath.testDatanodeDeath() indeed contains 4 tests. It would be easily for debugging to separate the tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4354) Separate
TestDatanodeDeath.testDatanodeDeath() into 4 tests
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4354:
-------------------------------------------
Attachment: 4354_20081006.patch
4354_20081006.patch:
- separate the tests
- change some classes/methods to static
- use random seed instead of a fixed seed.
> Separate TestDatanodeDeath.testDatanodeDeath() into 4 tests
> -----------------------------------------------------------
>
> Key: HADOOP-4354
> URL: https://issues.apache.org/jira/browse/HADOOP-4354
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4354_20081006.patch
>
>
> TestDatanodeDeath fails occasionally as reported in HADOOP-4278. TestDatanodeDeath.testDatanodeDeath() indeed contains 4 tests. It would be easily for debugging to separate the tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4354) Separate
TestDatanodeDeath.testDatanodeDeath() into 4 tests
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637480#action_12637480 ]
Hudson commented on HADOOP-4354:
--------------------------------
Integrated in Hadoop-trunk #626 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/626/])
. Separate TestDatanodeDeath.testDatanodeDeath() into 4 tests. (szetszwo)
> Separate TestDatanodeDeath.testDatanodeDeath() into 4 tests
> -----------------------------------------------------------
>
> Key: HADOOP-4354
> URL: https://issues.apache.org/jira/browse/HADOOP-4354
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4354_20081006.patch
>
>
> TestDatanodeDeath fails occasionally as reported in HADOOP-4278. TestDatanodeDeath.testDatanodeDeath() indeed contains 4 tests. It would be easily for debugging to separate the tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4354) Separate
TestDatanodeDeath.testDatanodeDeath() into 4 tests
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4354:
----------------------------------
Hadoop Flags: [Reviewed]
+1
> Separate TestDatanodeDeath.testDatanodeDeath() into 4 tests
> -----------------------------------------------------------
>
> Key: HADOOP-4354
> URL: https://issues.apache.org/jira/browse/HADOOP-4354
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4354_20081006.patch
>
>
> TestDatanodeDeath fails occasionally as reported in HADOOP-4278. TestDatanodeDeath.testDatanodeDeath() indeed contains 4 tests. It would be easily for debugging to separate the tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4354) Separate
TestDatanodeDeath.testDatanodeDeath() into 4 tests
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637288#action_12637288 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4354:
------------------------------------------------
{noformat}
[exec] +1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
{noformat}
The patch only changed TestDatanodeDeath.java and I tested it locally.
> Separate TestDatanodeDeath.testDatanodeDeath() into 4 tests
> -----------------------------------------------------------
>
> Key: HADOOP-4354
> URL: https://issues.apache.org/jira/browse/HADOOP-4354
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4354_20081006.patch
>
>
> TestDatanodeDeath fails occasionally as reported in HADOOP-4278. TestDatanodeDeath.testDatanodeDeath() indeed contains 4 tests. It would be easily for debugging to separate the tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4354) Separate
TestDatanodeDeath.testDatanodeDeath() into 4 tests
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4354:
-------------------------------------------
Status: Patch Available (was: Open)
> Separate TestDatanodeDeath.testDatanodeDeath() into 4 tests
> -----------------------------------------------------------
>
> Key: HADOOP-4354
> URL: https://issues.apache.org/jira/browse/HADOOP-4354
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4354_20081006.patch
>
>
> TestDatanodeDeath fails occasionally as reported in HADOOP-4278. TestDatanodeDeath.testDatanodeDeath() indeed contains 4 tests. It would be easily for debugging to separate the tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4354) Separate
TestDatanodeDeath.testDatanodeDeath() into 4 tests
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4354:
-------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> Separate TestDatanodeDeath.testDatanodeDeath() into 4 tests
> -----------------------------------------------------------
>
> Key: HADOOP-4354
> URL: https://issues.apache.org/jira/browse/HADOOP-4354
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4354_20081006.patch
>
>
> TestDatanodeDeath fails occasionally as reported in HADOOP-4278. TestDatanodeDeath.testDatanodeDeath() indeed contains 4 tests. It would be easily for debugging to separate the tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.