You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/24 07:58:39 UTC
[GitHub] [incubator-doris] caiconghui opened a new pull request #4175: [Bug][UpdateDataQuota] Skip update data used quota for information_schema db and fix bug for wrong time interval for UpdateDbUsedDataQuotaDaemon
caiconghui opened a new pull request #4175:
URL: https://github.com/apache/incubator-doris/pull/4175
## Proposed changes
This PR is to skip update data used quota for information_schema db and fix bug for wrong time interval for UpdateDbUsedDataQuotaDaemon
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Doris's issues](https://github.com/apache/incubator-doris/issues), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related issues ID, like "#4071 Add pull request template to doris project"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4175: [Bug][UpdateDataQuota] Skip update used data quota for information_schema db and fix bug for wrong time interval for UpdateDbUsedDataQuotaDaemon
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4175:
URL: https://github.com/apache/incubator-doris/pull/4175
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4175: [Bug][UpdateDataQuota] Skip update used data quota for information_schema db and fix bug for wrong time interval for UpdateDbUsedDataQuotaDaemon
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4175:
URL: https://github.com/apache/incubator-doris/pull/4175#discussion_r460052620
##########
File path: fe/fe-core/src/main/java/org/apache/doris/transaction/UpdateDbUsedDataQuotaDaemon.java
##########
@@ -44,6 +44,10 @@ private void updateAllDatabaseUsedDataQuota() {
List<Long> dbIdList = catalog.getDbIds();
GlobalTransactionMgr globalTransactionMgr = catalog.getGlobalTransactionMgr();
for (Long dbId : dbIdList) {
+ if (dbId == 0) {
Review comment:
Not sure about it, better to judge it by `db.isInfoSchemaDb()`;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #4175: [Bug][UpdateDataQuota] Skip update used data quota for information_schema db and fix bug for wrong time interval for UpdateDbUsedDataQuotaDaemon
Posted by GitBox <gi...@apache.org>.
caiconghui commented on a change in pull request #4175:
URL: https://github.com/apache/incubator-doris/pull/4175#discussion_r460065609
##########
File path: fe/fe-core/src/main/java/org/apache/doris/transaction/UpdateDbUsedDataQuotaDaemon.java
##########
@@ -44,6 +44,10 @@ private void updateAllDatabaseUsedDataQuota() {
List<Long> dbIdList = catalog.getDbIds();
GlobalTransactionMgr globalTransactionMgr = catalog.getGlobalTransactionMgr();
for (Long dbId : dbIdList) {
+ if (dbId == 0) {
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org