You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Piero Sartini (JIRA)" <ji...@apache.org> on 2008/04/04 14:49:58 UTC
[jira] Created: (WW-2576) Explicit configuration of included action
packages
Explicit configuration of included action packages
--------------------------------------------------
Key: WW-2576
URL: https://issues.apache.org/struts/browse/WW-2576
Project: Struts 2
Issue Type: Improvement
Components: Plugin - Convention
Reporter: Piero Sartini
Right now, there is a constant named "struts.convention.exclude.packages"
I had to add "oracle.toplink.*" in order to get the plugin working.
It would be nice to have the possibility to configure a top level package (my.project.* ) that will be searched instead of excluding everything else.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2576) Possibility to reduce classpath scanning
to a parent-package
Posted by "Piero Sartini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piero Sartini updated WW-2576:
------------------------------
Attachment: struts2-convention-packageLocatorBase.patch
> Possibility to reduce classpath scanning to a parent-package
> ------------------------------------------------------------
>
> Key: WW-2576
> URL: https://issues.apache.org/struts/browse/WW-2576
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Convention
> Affects Versions: 2.1.3
> Reporter: Piero Sartini
> Assignee: Piero Sartini
> Fix For: 2.2.x
>
> Attachments: struts2-convention-packageLocatorBase.patch
>
>
> Right now, there is a constant named "struts.convention.exclude.packages"
> I had to add "oracle.toplink.*" in order to get the plugin working.
> It would be nice to have the possibility to configure a top level package (my.project.** ) that will be scanned instead of excluding everything else.
> After looking at the source I came to the conclusion that the convention
> plugin is designed to exclude a whole bunch of packages from classpath
> scanning. For my feeling that is not the best way to go because you can never
> be sure what is on your classpath. Worst case the application stops working
> because the admin adds some jars to the classpath of the appserver, the ear
> is extended with some lib or whatever. In an enterprise environment this
> behaviour is IMHO a no-no.
> Anyway, I do understand that there are usecases where this approach is needed.
> To solve this, I thought about an option like "scanPath" that defaults
> to "**" (or "^(.*)$") In my case, I would set it to something
> like "com.project.**" or "^com\.myproject\.(.*)$"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (WW-2576) Possibility to reduce classpath
scanning to a parent-package
Posted by "Piero Sartini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on WW-2576 started by Piero Sartini.
> Possibility to reduce classpath scanning to a parent-package
> ------------------------------------------------------------
>
> Key: WW-2576
> URL: https://issues.apache.org/struts/browse/WW-2576
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Convention
> Affects Versions: 2.1.3
> Reporter: Piero Sartini
> Assignee: Piero Sartini
> Fix For: 2.2.x
>
> Attachments: struts2-convention-packageLocatorBase.patch
>
>
> Right now, there is a constant named "struts.convention.exclude.packages"
> I had to add "oracle.toplink.*" in order to get the plugin working.
> It would be nice to have the possibility to configure a top level package (my.project.** ) that will be scanned instead of excluding everything else.
> After looking at the source I came to the conclusion that the convention
> plugin is designed to exclude a whole bunch of packages from classpath
> scanning. For my feeling that is not the best way to go because you can never
> be sure what is on your classpath. Worst case the application stops working
> because the admin adds some jars to the classpath of the appserver, the ear
> is extended with some lib or whatever. In an enterprise environment this
> behaviour is IMHO a no-no.
> Anyway, I do understand that there are usecases where this approach is needed.
> To solve this, I thought about an option like "scanPath" that defaults
> to "**" (or "^(.*)$") In my case, I would set it to something
> like "com.project.**" or "^com\.myproject\.(.*)$"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2576) Possibility to reduce classpath scanning
to a parent-package
Posted by "Piero Sartini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piero Sartini updated WW-2576:
------------------------------
Assignee: Piero Sartini
Description:
Right now, there is a constant named "struts.convention.exclude.packages"
I had to add "oracle.toplink.*" in order to get the plugin working.
It would be nice to have the possibility to configure a top level package (my.project.** ) that will be scanned instead of excluding everything else.
After looking at the source I came to the conclusion that the convention
plugin is designed to exclude a whole bunch of packages from classpath
scanning. For my feeling that is not the best way to go because you can never
be sure what is on your classpath. Worst case the application stops working
because the admin adds some jars to the classpath of the appserver, the ear
is extended with some lib or whatever. In an enterprise environment this
behaviour is IMHO a no-no.
Anyway, I do understand that there are usecases where this approach is needed.
To solve this, I thought about an option like "scanPath" that defaults
to "**" (or "^(.*)$") In my case, I would set it to something
like "com.project.**" or "^com\.myproject\.(.*)$"
was:
Right now, there is a constant named "struts.convention.exclude.packages"
I had to add "oracle.toplink.*" in order to get the plugin working.
It would be nice to have the possibility to configure a top level package (my.project.* ) that will be searched instead of excluding everything else.
Affects Version/s: 2.1.3
Summary: Possibility to reduce classpath scanning to a parent-package (was: Explicit configuration of included action packages)
better explanation and included post from mailing list
> Possibility to reduce classpath scanning to a parent-package
> ------------------------------------------------------------
>
> Key: WW-2576
> URL: https://issues.apache.org/struts/browse/WW-2576
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Convention
> Affects Versions: 2.1.3
> Reporter: Piero Sartini
> Assignee: Piero Sartini
> Fix For: 2.2.x
>
>
> Right now, there is a constant named "struts.convention.exclude.packages"
> I had to add "oracle.toplink.*" in order to get the plugin working.
> It would be nice to have the possibility to configure a top level package (my.project.** ) that will be scanned instead of excluding everything else.
> After looking at the source I came to the conclusion that the convention
> plugin is designed to exclude a whole bunch of packages from classpath
> scanning. For my feeling that is not the best way to go because you can never
> be sure what is on your classpath. Worst case the application stops working
> because the admin adds some jars to the classpath of the appserver, the ear
> is extended with some lib or whatever. In an enterprise environment this
> behaviour is IMHO a no-no.
> Anyway, I do understand that there are usecases where this approach is needed.
> To solve this, I thought about an option like "scanPath" that defaults
> to "**" (or "^(.*)$") In my case, I would set it to something
> like "com.project.**" or "^com\.myproject\.(.*)$"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2576) Possibility to reduce classpath scanning
to a parent-package
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso resolved WW-2576.
---------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.2.x)
Future
Merged into sandbox + some tests. Thanks for the patch
> Possibility to reduce classpath scanning to a parent-package
> ------------------------------------------------------------
>
> Key: WW-2576
> URL: https://issues.apache.org/struts/browse/WW-2576
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Convention
> Affects Versions: 2.1.3
> Reporter: Piero Sartini
> Assignee: Piero Sartini
> Fix For: Future
>
> Attachments: struts2-convention-packageLocatorBase.patch
>
>
> Right now, there is a constant named "struts.convention.exclude.packages"
> I had to add "oracle.toplink.*" in order to get the plugin working.
> It would be nice to have the possibility to configure a top level package (my.project.** ) that will be scanned instead of excluding everything else.
> After looking at the source I came to the conclusion that the convention
> plugin is designed to exclude a whole bunch of packages from classpath
> scanning. For my feeling that is not the best way to go because you can never
> be sure what is on your classpath. Worst case the application stops working
> because the admin adds some jars to the classpath of the appserver, the ear
> is extended with some lib or whatever. In an enterprise environment this
> behaviour is IMHO a no-no.
> Anyway, I do understand that there are usecases where this approach is needed.
> To solve this, I thought about an option like "scanPath" that defaults
> to "**" (or "^(.*)$") In my case, I would set it to something
> like "com.project.**" or "^com\.myproject\.(.*)$"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2576) Explicit configuration of included action
packages
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-2576:
--------------------------
Fix Version/s: 2.2.x
> Explicit configuration of included action packages
> --------------------------------------------------
>
> Key: WW-2576
> URL: https://issues.apache.org/struts/browse/WW-2576
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Convention
> Reporter: Piero Sartini
> Fix For: 2.2.x
>
>
> Right now, there is a constant named "struts.convention.exclude.packages"
> I had to add "oracle.toplink.*" in order to get the plugin working.
> It would be nice to have the possibility to configure a top level package (my.project.* ) that will be searched instead of excluding everything else.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work stopped: (WW-2576) Possibility to reduce classpath
scanning to a parent-package
Posted by "Piero Sartini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on WW-2576 stopped by Piero Sartini.
> Possibility to reduce classpath scanning to a parent-package
> ------------------------------------------------------------
>
> Key: WW-2576
> URL: https://issues.apache.org/struts/browse/WW-2576
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Convention
> Affects Versions: 2.1.3
> Reporter: Piero Sartini
> Assignee: Piero Sartini
> Fix For: 2.2.x
>
> Attachments: struts2-convention-packageLocatorBase.patch
>
>
> Right now, there is a constant named "struts.convention.exclude.packages"
> I had to add "oracle.toplink.*" in order to get the plugin working.
> It would be nice to have the possibility to configure a top level package (my.project.** ) that will be scanned instead of excluding everything else.
> After looking at the source I came to the conclusion that the convention
> plugin is designed to exclude a whole bunch of packages from classpath
> scanning. For my feeling that is not the best way to go because you can never
> be sure what is on your classpath. Worst case the application stops working
> because the admin adds some jars to the classpath of the appserver, the ear
> is extended with some lib or whatever. In an enterprise environment this
> behaviour is IMHO a no-no.
> Anyway, I do understand that there are usecases where this approach is needed.
> To solve this, I thought about an option like "scanPath" that defaults
> to "**" (or "^(.*)$") In my case, I would set it to something
> like "com.project.**" or "^com\.myproject\.(.*)$"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.