[GitHub] [spark] cloud-fan commented on a change in pull request #24581: [SPARK-27675][SQL] do not use MutableColumnarRow in ColumnarBatch

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24581: [SPARK-27675][SQL] do not use MutableColumnarRow in ColumnarBatch
URL: https://github.com/apache/spark/pull/24581#discussion_r283194273
 
 

 ##########
 File path: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnarRow.java
 ##########
 @@ -39,17 +38,10 @@
  */
 public final class MutableColumnarRow extends InternalRow {
   public int rowId;
-  private final ColumnVector[] columns;
-  private final WritableColumnVector[] writableColumns;
-
-  public MutableColumnarRow(ColumnVector[] columns) {
-    this.columns = columns;
-    this.writableColumns = null;
-  }
+  private final WritableColumnVector[] columns;
 
 Review comment:
   I thought about it too. `MutableColumnarRow` is used in performance critical path (hash aggregate), and I'm a little hesitant to add class Hierarchy here, which may hurt performance.  cc @kiszk 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org