You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "sbernard31 (via GitHub)" <gi...@apache.org> on 2023/12/13 13:52:14 UTC
[PR] [SUREFIRE-1923] Add documentation about minimal java version usable with toolchain [maven-surefire]
sbernard31 opened a new pull request, #701:
URL: https://github.com/apache/maven-surefire/pull/701
This was triggered by https://issues.apache.org/jira/browse/SUREFIRE-1923?focusedCommentId=17795866&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17795866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "sbernard31 (via GitHub)" <gi...@apache.org>.
sbernard31 commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425440185
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal java version for toolchain
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+--------------------------+--------------------------+
+|| <<Surefire version>> || <<Minimal Java version>> || <<Class File Format>> |
+*---------------------------------------------+--------------------------+--------------------------+
+| 3.0.0-M6 or higher | Java 8 | 52 |
+*---------------------------------------------+--------------------------+--------------------------+
+| 3.0.0-M5 and lower | Java 7 | 51 |
+*---------------------------------------------+--------------------------+--------------------------+
+| To Be Completed | Java 6 | 50 |
Review Comment:
I tried but sorry this is really too time consuming.
Note that following : https://maven.apache.org/guides/mini/guide-using-toolchains.html, **Surefire** starts to support toolchain since 2.5, so theoretically no need to search before for this documentation section.
I tried to look what version was supported in 2.5 and not sure but I understand it starts with java 1.3 (see https://github.com/apache/maven-surefire/blob/surefire-2.5/pom.xml#L145-L152)
In also let a link to easily find Class File Version from Java Version : https://docs.oracle.com/javase/specs/jvms/se16/html/jvms-4.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "sbernard31 (via GitHub)" <gi...@apache.org>.
sbernard31 commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425479179
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal Java Versoin for Toolchains
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+---------------------------+-------------------------+
+|| <<Surefire Version>> || <<Minimal Java Version>> || <<Class File Version>> |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M6 or higher | Java 8 | 52 |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M5 and lower | Java 7 | 51 |
+*---------------------------------------------+---------------------------+-------------------------+
+| To Be Completed | Java 6 | 50 |
Review Comment:
Ok so I just added missing information about java 6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "sbernard31 (via GitHub)" <gi...@apache.org>.
sbernard31 commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425449591
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal Java Versoin for Toolchains
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+---------------------------+-------------------------+
+|| <<Surefire Version>> || <<Minimal Java Version>> || <<Class File Version>> |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M6 or higher | Java 8 | 52 |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M5 and lower | Java 7 | 51 |
+*---------------------------------------------+---------------------------+-------------------------+
+| To Be Completed | Java 6 | 50 |
+*---------------------------------------------+---------------------------+-------------------------+
+
+ If you try to use an older version than minimal supported one, you should face something like:
Review Comment:
You want me to change it like this :
```diff
-If you try to use an older version than minimal supported one
+If you try to use an older version then the minimal supported one
```
My english is not very good but I didn't get the sentence like this, so I need some explanation ?
I tried to get help with deepl and it propose something like :
> If you try to use a version older than the minimum supported version
Does it sounds better ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-1923] Add documentation about minimal java version usable with toolchain [maven-surefire]
Posted by "sbernard31 (via GitHub)" <gi...@apache.org>.
sbernard31 commented on PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#issuecomment-1853965694
I hope I've understood the syntax of the documentation correctly.
Note that I didn't check if this generates the web site properly.
Also I tried to search minimal java version requirement for older surefire version. I think this would be a useful information but didn't find any easy way to get that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "sbernard31 (via GitHub)" <gi...@apache.org>.
sbernard31 commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425454077
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal Java Versoin for Toolchains
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+---------------------------+-------------------------+
+|| <<Surefire Version>> || <<Minimal Java Version>> || <<Class File Version>> |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M6 or higher | Java 8 | 52 |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M5 and lower | Java 7 | 51 |
+*---------------------------------------------+---------------------------+-------------------------+
+| To Be Completed | Java 6 | 50 |
Review Comment:
Like explained at https://github.com/apache/maven-surefire/pull/701#discussion_r1425440185
Ideally we need all between 2.5 and now.
2.5 -> 1.3
? -> 1.4
? -> 1.5
before 3.0.0-M1 -> 1.6
3.0.0-M5 and lower -> 1.7
more -> 1.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425452462
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal Java Versoin for Toolchains
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+---------------------------+-------------------------+
+|| <<Surefire Version>> || <<Minimal Java Version>> || <<Class File Version>> |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M6 or higher | Java 8 | 52 |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M5 and lower | Java 7 | 51 |
+*---------------------------------------------+---------------------------+-------------------------+
+| To Be Completed | Java 6 | 50 |
+*---------------------------------------------+---------------------------+-------------------------+
+
+ If you try to use an older version than minimal supported one, you should face something like:
Review Comment:
That is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425458587
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal Java Versoin for Toolchains
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+---------------------------+-------------------------+
+|| <<Surefire Version>> || <<Minimal Java Version>> || <<Class File Version>> |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M6 or higher | Java 8 | 52 |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M5 and lower | Java 7 | 51 |
+*---------------------------------------------+---------------------------+-------------------------+
+| To Be Completed | Java 6 | 50 |
Review Comment:
I think everything before 6 is irrelevant these days... no need to put too much time into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit merged PR #701:
URL: https://github.com/apache/maven-surefire/pull/701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425437147
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal Java Versoin for Toolchains
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+---------------------------+-------------------------+
+|| <<Surefire Version>> || <<Minimal Java Version>> || <<Class File Version>> |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M6 or higher | Java 8 | 52 |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M5 and lower | Java 7 | 51 |
+*---------------------------------------------+---------------------------+-------------------------+
+| To Be Completed | Java 6 | 50 |
Review Comment:
Here it is d23e970cd86ce4896edf5f8ad1f1acd66a9a27c2, https://issues.apache.org/jira/browse/SUREFIRE-1474, so everything before 3.0.0-M1
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal Java Versoin for Toolchains
Review Comment:
Version
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal Java Versoin for Toolchains
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+---------------------------+-------------------------+
+|| <<Surefire Version>> || <<Minimal Java Version>> || <<Class File Version>> |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M6 or higher | Java 8 | 52 |
+*---------------------------------------------+---------------------------+-------------------------+
+| 3.0.0-M5 and lower | Java 7 | 51 |
+*---------------------------------------------+---------------------------+-------------------------+
+| To Be Completed | Java 6 | 50 |
+*---------------------------------------------+---------------------------+-------------------------+
+
+ If you try to use an older version than minimal supported one, you should face something like:
Review Comment:
then the minimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425396777
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal java version for toolchain
Review Comment:
Minimal Java Version for Toolchains
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal Java Versoin for Toolchains
Review Comment:
By bad
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal Java Versoin for Toolchains
Review Comment:
My bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-1923] Add documentation about minimal java version usable with toolchain [maven-surefire]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425396231
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal java version for toolchain
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+--------------------------+--------------------------+
+|| <<Surefire version>> || <<Minimal Java version>> || <<Class File Format>> |
Review Comment:
Class File Version
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal java version for toolchain
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+--------------------------+--------------------------+
+|| <<Surefire version>> || <<Minimal Java version>> || <<Class File Format>> |
+*---------------------------------------------+--------------------------+--------------------------+
+| 3.0.0-M6 or higher | Java 8 | 52 |
+*---------------------------------------------+--------------------------+--------------------------+
+| 3.0.0-M5 and lower | Java 7 | 51 |
+*---------------------------------------------+--------------------------+--------------------------+
+| To Be Completed | Java 6 | 50 |
+*---------------------------------------------+--------------------------+--------------------------+
+
+ If you try to use smaller version than minimal supported one, you should face something like:
Review Comment:
...use an older version...
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal java version for toolchain
+
+ Unfortunately, the minimum version of Java that can be used as a toolchain is limited by the Surefire Booter requirement.
+
+*---------------------------------------------+--------------------------+--------------------------+
+|| <<Surefire version>> || <<Minimal Java version>> || <<Class File Format>> |
+*---------------------------------------------+--------------------------+--------------------------+
+| 3.0.0-M6 or higher | Java 8 | 52 |
+*---------------------------------------------+--------------------------+--------------------------+
+| 3.0.0-M5 and lower | Java 7 | 51 |
+*---------------------------------------------+--------------------------+--------------------------+
+| To Be Completed | Java 6 | 50 |
Review Comment:
Could you check Git repo for this?
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal java version for toolchain
Review Comment:
Minimal Java Versoin for Toolchains
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "sbernard31 (via GitHub)" <gi...@apache.org>.
sbernard31 commented on code in PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#discussion_r1425445430
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -54,3 +54,36 @@ Using Maven Toolchains with ${thisPlugin}.
+---+
The above example assumes that your toolchains.xml contains a valid entry with these values.
+
+* Minimal Java Versoin for Toolchains
Review Comment:
Sorry I copy/paste you text just above :point_up: https://github.com/apache/maven-surefire/pull/701#discussion_r1425396777, I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "sbernard31 (via GitHub)" <gi...@apache.org>.
sbernard31 commented on PR #701:
URL: https://github.com/apache/maven-surefire/pull/701#issuecomment-1854091684
> Thanks for your contribution. Looks good to me now. Will handle squash and merge.
Thx :pray: for taking time to answer to questions and maintaining this useful piece of software.
(Keep in mind that I didn't test if this will generate web site correctly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SUREFIRE-2221] Document minimum supported Java version for Toolchains [maven-surefire]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit merged PR #701:
URL: https://github.com/apache/maven-surefire/pull/701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org