You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "clickingbuttons (via GitHub)" <gi...@apache.org> on 2023/05/05 16:56:00 UTC
[GitHub] [arrow] clickingbuttons opened a new pull request, #35451: MINOR: [Docs] Fix VarBinary examples to use Values buffer
clickingbuttons opened a new pull request, #35451:
URL: https://github.com/apache/arrow/pull/35451
I'm implementing Arrow and noticed an inconsistency in the docs. After reading the cpp and Rust implementations and talking to @tustvold I believe VarBinary is actually laid out according to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35451: [FORMAT]: Minor Fix `VarBinary` examples to use Values buffer
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35451:
URL: https://github.com/apache/arrow/pull/35451#issuecomment-1546807328
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/74b1828557fe4607b5ed65b10eaac570...b6cb43a585f1453faac68cfa9976e329/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35451: [FORMAT]: Minor Fix `VarBinary` examples to use Values buffer
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35451:
URL: https://github.com/apache/arrow/pull/35451#issuecomment-1536692791
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #35451: [FORMAT]: Minor Fix `VarBinary` examples to use Values buffer
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #35451:
URL: https://github.com/apache/arrow/pull/35451#issuecomment-1536693114
Thank you @clickingbuttons
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35451: [FORMAT]: Minor Fix `VarBinary` examples to use Values buffer
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35451:
URL: https://github.com/apache/arrow/pull/35451#issuecomment-1546807043
Benchmark runs are scheduled for baseline = e324f9ab8aaa7f51d7a14d4d3f1a9713b866196b and contender = cd6e2a4d2b9373b942da18b4cc82cb41431764d9. cd6e2a4d2b9373b942da18b4cc82cb41431764d9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/cca66b8044824339bdcb8cd456616348...f88348ede88f444e92eab6d67d5e91cb/)
[Failed :arrow_down:0.09% :arrow_up:3.17%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/44820e1b277642f6a11788a30317c2a5...da2bea7f95104cfea6945d40389b27aa/)
[Finished :arrow_down:2.79% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/74b1828557fe4607b5ed65b10eaac570...b6cb43a585f1453faac68cfa9976e329/)
[Finished :arrow_down:0.75% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/72e6f533a14347339451132dcf641a8c...f4c6eddc4fcd4ef0a88da0a861456bdd/)
Buildkite builds:
[Finished] [`cd6e2a4d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2870)
[Failed] [`cd6e2a4d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2906)
[Finished] [`cd6e2a4d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2871)
[Finished] [`cd6e2a4d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2896)
[Finished] [`e324f9ab` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2869)
[Failed] [`e324f9ab` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2905)
[Finished] [`e324f9ab` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2870)
[Finished] [`e324f9ab` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2895)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] tustvold merged pull request #35451: [FORMAT]: Minor Fix `VarBinary` examples to use Values buffer
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #35451:
URL: https://github.com/apache/arrow/pull/35451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org