You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LatrecheYasser (via GitHub)" <gi...@apache.org> on 2024/07/31 11:06:48 UTC

[PR] feat: Add wildcard projection to SELECT statement if no projection was set [datafusion]

LatrecheYasser opened a new pull request, #11744:
URL: https://github.com/apache/datafusion/pull/11744

   ## Which issue does this PR close?
   
   Closes #11743.
   
   ## Rationale for this change
   
   This PR will check the `select_builder` in the `select_to_sql_expr` after calling the `select_to_sql_recursively` and if no projection is set, it will add a projection with one element set to `ast::SelectItem::Wildcard(ast::WildcardAdditionalOptions::default())`
   
   ## What changes are included in this PR?
   
   The changes described above, and some test cases. 
   
   ## Are these changes tested?
   
   Yes. 
   
   ## Are there any user-facing changes?
   
   I would say no. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fix `plan_to_sql`: Add wildcard projection to SELECT statement if no projection was set [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11744:
URL: https://github.com/apache/datafusion/pull/11744#issuecomment-2260790849

   https://github.com/apache/datafusion/actions/runs/10179108058/job/28167144185?pr=11744 is failing -- I think we can fix that by running `cargo fmt` and committing the result


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fix `plan_to_sql`: Add wildcard projection to SELECT statement if no projection was set [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11744:
URL: https://github.com/apache/datafusion/pull/11744#issuecomment-2262813214

   🚀 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fix `plan_to_sql`: Add wildcard projection to SELECT statement if no projection was set [datafusion]

Posted by "LatrecheYasser (via GitHub)" <gi...@apache.org>.
LatrecheYasser commented on PR #11744:
URL: https://github.com/apache/datafusion/pull/11744#issuecomment-2260834200

   > https://github.com/apache/datafusion/actions/runs/10179108058/job/28167144185?pr=11744 is failing -- I think we can fix that by running `cargo fmt` and committing the result
   
   thanks @alamb I will run the `cargo fmt` and push a new commit. Thanks for the quick review 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fix `plan_to_sql`: Add wildcard projection to SELECT statement if no projection was set [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #11744:
URL: https://github.com/apache/datafusion/pull/11744


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org