You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/12/15 00:49:18 UTC
Review Request 64634: RANGER-1929:The ranger should support preview
policy.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1929
https://issues.apache.org/jira/browse/RANGER-1929
Repository: ranger
Description
-------
Currently we can only edit the policy without previewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
Diffs
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3b
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e166
security-admin/src/main/webapp/styles/xa.css 22eedf64
security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
Diff: https://reviews.apache.org/r/64634/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 64634: RANGER-1929:The ranger should support
preview policy.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/#review194050
-----------------------------------------------------------
Ship it!
This is a valuable feature.
- Qiang Zhang
On Dec. 15, 2017, 1:23 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64634/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 1:23 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1929
> https://issues.apache.org/jira/browse/RANGER-1929
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently we can only edit the policy without previewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3b
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e166
> security-admin/src/main/webapp/styles/xa.css 22eedf64
> security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64634/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 64634: RANGER-1929:The ranger should support the
View policy.
Posted by pengjianhua <pe...@zte.com.cn>.
> On 十二月 19, 2017, 11:14 a.m., Colm O hEigeartaigh wrote:
> > Looks good thanks, but please see Vel's comments on the JIRA.
Ok. I had fixed it according to Vel's comments. Please get it from https://reviews.apache.org/r/64634/diff/5/. Thanks.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/#review194135
-----------------------------------------------------------
On 十二月 20, 2017, 6:23 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64634/
> -----------------------------------------------------------
>
> (Updated 十二月 20, 2017, 6:23 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1929
> https://issues.apache.org/jira/browse/RANGER-1929
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently we can only edit the policy without viewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3ba
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e1669
> security-admin/src/main/webapp/styles/xa.css 22eedf644
> security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64634/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 64634: RANGER-1929:The ranger should support
preview policy.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/#review194135
-----------------------------------------------------------
Looks good thanks, but please see Vel's comments on the JIRA.
- Colm O hEigeartaigh
On Dec. 19, 2017, 9:16 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64634/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 9:16 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1929
> https://issues.apache.org/jira/browse/RANGER-1929
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently we can only edit the policy without previewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3b
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e166
> security-admin/src/main/webapp/styles/xa.css 22eedf64
> security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64634/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 64634: RANGER-1929:The ranger should support the
View policy.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/#review194225
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On Dec. 20, 2017, 6:23 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64634/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 6:23 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1929
> https://issues.apache.org/jira/browse/RANGER-1929
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently we can only edit the policy without viewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3ba
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e1669
> security-admin/src/main/webapp/styles/xa.css 22eedf644
> security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64634/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 64634: RANGER-1929:The ranger should support the
View policy.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/
-----------------------------------------------------------
(Updated 十二月 20, 2017, 6:23 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1929
https://issues.apache.org/jira/browse/RANGER-1929
Repository: ranger
Description
-------
Currently we can only edit the policy without viewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3ba
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e1669
security-admin/src/main/webapp/styles/xa.css 22eedf644
security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
Diff: https://reviews.apache.org/r/64634/diff/5/
Changes: https://reviews.apache.org/r/64634/diff/4-5/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 64634: RANGER-1929:The ranger should support the
View policy.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/
-----------------------------------------------------------
(Updated 十二月 20, 2017, 3:19 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Summary (updated)
-----------------
RANGER-1929:The ranger should support the View policy.
Bugs: RANGER-1929
https://issues.apache.org/jira/browse/RANGER-1929
Repository: ranger
Description (updated)
-------
Currently we can only edit the policy without viewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
Diffs
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3b
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e166
security-admin/src/main/webapp/styles/xa.css 22eedf64
security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
Diff: https://reviews.apache.org/r/64634/diff/4/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 64634: RANGER-1929:The ranger should support
preview policy.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/
-----------------------------------------------------------
(Updated 十二月 19, 2017, 9:16 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1929
https://issues.apache.org/jira/browse/RANGER-1929
Repository: ranger
Description
-------
Currently we can only edit the policy without previewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3b
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e166
security-admin/src/main/webapp/styles/xa.css 22eedf64
security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
Diff: https://reviews.apache.org/r/64634/diff/4/
Changes: https://reviews.apache.org/r/64634/diff/3-4/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 64634: RANGER-1929:The ranger should support
preview policy.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/
-----------------------------------------------------------
(Updated 十二月 19, 2017, 6:17 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1929
https://issues.apache.org/jira/browse/RANGER-1929
Repository: ranger
Description
-------
Currently we can only edit the policy without previewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3b
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e166
security-admin/src/main/webapp/styles/xa.css 22eedf64
security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
Diff: https://reviews.apache.org/r/64634/diff/3/
Changes: https://reviews.apache.org/r/64634/diff/2-3/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 64634: RANGER-1929:The ranger should support
preview policy.
Posted by pengjianhua <pe...@zte.com.cn>.
> On 十二月 18, 2017, 4:20 p.m., Colm O hEigeartaigh wrote:
> > Looks pretty good to me. Could you remove the whitespace errors from the patch?
Ok. I had fixed it. Please get it from https://reviews.apache.org/r/64634/diff/4/. Thanks.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/#review194076
-----------------------------------------------------------
On 十二月 19, 2017, 9:16 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64634/
> -----------------------------------------------------------
>
> (Updated 十二月 19, 2017, 9:16 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1929
> https://issues.apache.org/jira/browse/RANGER-1929
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently we can only edit the policy without previewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3b
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e166
> security-admin/src/main/webapp/styles/xa.css 22eedf64
> security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64634/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 64634: RANGER-1929:The ranger should support
preview policy.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/#review194076
-----------------------------------------------------------
Looks pretty good to me. Could you remove the whitespace errors from the patch?
- Colm O hEigeartaigh
On Dec. 15, 2017, 1:23 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64634/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 1:23 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1929
> https://issues.apache.org/jira/browse/RANGER-1929
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently we can only edit the policy without previewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3b
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e166
> security-admin/src/main/webapp/styles/xa.css 22eedf64
> security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
> security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64634/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 64634: RANGER-1929:The ranger should support
preview policy.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64634/
-----------------------------------------------------------
(Updated 十二月 15, 2017, 1:23 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1929
https://issues.apache.org/jira/browse/RANGER-1929
Repository: ranger
Description
-------
Currently we can only edit the policy without previewing the policy. We must use editing funtion of policy when only need to query the detail for policy. So we should supply the function of the query detail for policy.
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js b8de5c3b
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js PRE-CREATION
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 09e2e166
security-admin/src/main/webapp/styles/xa.css 22eedf64
security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html PRE-CREATION
security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html PRE-CREATION
Diff: https://reviews.apache.org/r/64634/diff/2/
Changes: https://reviews.apache.org/r/64634/diff/1-2/
Testing
-------
Thanks,
pengjianhua