You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ly...@apache.org on 2022/09/08 21:43:40 UTC

[superset] branch lyndsi/languagepicker-act-cleanup created (now cea137c909)

This is an automated email from the ASF dual-hosted git repository.

lyndsi pushed a change to branch lyndsi/languagepicker-act-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git


      at cea137c909 2 act errors removed from LanguagePicker test

This branch includes the following new commits:

     new cea137c909 2 act errors removed from LanguagePicker test

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[superset] 01/01: 2 act errors removed from LanguagePicker test

Posted by ly...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

lyndsi pushed a commit to branch lyndsi/languagepicker-act-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git

commit cea137c909fc3547b86b954bcc93bfb80f085033
Author: lyndsiWilliams <kc...@gmail.com>
AuthorDate: Thu Sep 8 16:43:24 2022 -0500

    2 act errors removed from LanguagePicker test
---
 superset-frontend/src/views/components/LanguagePicker.test.tsx | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/superset-frontend/src/views/components/LanguagePicker.test.tsx b/superset-frontend/src/views/components/LanguagePicker.test.tsx
index 230c89d18b..a427c4e91a 100644
--- a/superset-frontend/src/views/components/LanguagePicker.test.tsx
+++ b/superset-frontend/src/views/components/LanguagePicker.test.tsx
@@ -38,22 +38,23 @@ const mockedProps = {
   },
 };
 
-test('should render', () => {
+test('should render', async () => {
   const { container } = render(
     <Menu>
       <LanguagePicker {...mockedProps} />
     </Menu>,
   );
+  expect(await screen.findByRole('button')).toBeInTheDocument();
   expect(container).toBeInTheDocument();
 });
 
-test('should render the language picker', () => {
+test('should render the language picker', async () => {
   render(
     <Menu>
       <LanguagePicker {...mockedProps} />
     </Menu>,
   );
-  expect(screen.getByLabelText('Languages')).toBeInTheDocument();
+  expect(await screen.findByLabelText('Languages')).toBeInTheDocument();
 });
 
 test('should render the items', async () => {