You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2006/05/23 22:46:29 UTC

[jira] Created: (HADOOP-246) the record-io generated c++ has wrong comments

the record-io generated c++ has wrong comments
----------------------------------------------

         Key: HADOOP-246
         URL: http://issues.apache.org/jira/browse/HADOOP-246
     Project: Hadoop
        Type: Bug

  Components: record  
    Versions: 0.2.1    
    Reporter: Owen O'Malley
 Assigned to: Milind Bhandarkar 


The comments on the namespaces on the closing come out backward:

} // end namespace org
} // end namespace apache
} // end namespace hadoop
} // end namespace record
} // end namespace test


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HADOOP-246) the record-io generated c++ has wrong comments

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HADOOP-246?page=comments#action_12412990 ] 

Owen O'Malley commented on HADOOP-246:
--------------------------------------

It would also be nice if the namespaces weren't closed off just to be opened again...

} // end namespace org
} // end namespace apache
} // end namespace hadoop
} // end namespace record
} // end namespace test
namespace org {
namespace apache {
namespace hadoop {
namespace record {
namespace test {


> the record-io generated c++ has wrong comments
> ----------------------------------------------
>
>          Key: HADOOP-246
>          URL: http://issues.apache.org/jira/browse/HADOOP-246
>      Project: Hadoop
>         Type: Bug

>   Components: record
>     Versions: 0.2.1
>     Reporter: Owen O'Malley
>     Assignee: Milind Bhandarkar

>
> The comments on the namespaces on the closing come out backward:
> } // end namespace org
> } // end namespace apache
> } // end namespace hadoop
> } // end namespace record
> } // end namespace test

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HADOOP-246) the record-io generated c++ has wrong comments

Posted by "Sameer Paranjpye (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-246?page=all ]

Sameer Paranjpye updated HADOOP-246:
------------------------------------

    Fix Version: 0.3

> the record-io generated c++ has wrong comments
> ----------------------------------------------
>
>          Key: HADOOP-246
>          URL: http://issues.apache.org/jira/browse/HADOOP-246
>      Project: Hadoop
>         Type: Bug

>   Components: record
>     Versions: 0.2.1
>     Reporter: Owen O'Malley
>     Assignee: Milind Bhandarkar
>      Fix For: 0.3

>
> The comments on the namespaces on the closing come out backward:
> } // end namespace org
> } // end namespace apache
> } // end namespace hadoop
> } // end namespace record
> } // end namespace test

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HADOOP-246) the record-io generated c++ has wrong comments

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HADOOP-246?page=comments#action_12413038 ] 

Milind Bhandarkar commented on HADOOP-246:
------------------------------------------

I have attached a patch to hadoop-245 that includes a fix for this bug as well. Repeated opening and closing of namespaces does not cause any runtime inefficiency. (and probably very small compile-time inefficiency.) However it makes the code generator hairier than it needs to be. That is why I open and close namespaces for each record independently.

> the record-io generated c++ has wrong comments
> ----------------------------------------------
>
>          Key: HADOOP-246
>          URL: http://issues.apache.org/jira/browse/HADOOP-246
>      Project: Hadoop
>         Type: Bug

>   Components: record
>     Versions: 0.2.1
>     Reporter: Owen O'Malley
>     Assignee: Milind Bhandarkar

>
> The comments on the namespaces on the closing come out backward:
> } // end namespace org
> } // end namespace apache
> } // end namespace hadoop
> } // end namespace record
> } // end namespace test

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HADOOP-246) the record-io generated c++ has wrong comments

Posted by "Sameer Paranjpye (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-246?page=all ]
     
Sameer Paranjpye resolved HADOOP-246:
-------------------------------------

    Resolution: Duplicate

Fix is part of patch in HADOOP-245

> the record-io generated c++ has wrong comments
> ----------------------------------------------
>
>          Key: HADOOP-246
>          URL: http://issues.apache.org/jira/browse/HADOOP-246
>      Project: Hadoop
>         Type: Bug

>   Components: record
>     Versions: 0.2.1
>     Reporter: Owen O'Malley
>     Assignee: Milind Bhandarkar
>      Fix For: 0.3

>
> The comments on the namespaces on the closing come out backward:
> } // end namespace org
> } // end namespace apache
> } // end namespace hadoop
> } // end namespace record
> } // end namespace test

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HADOOP-246) the record-io generated c++ has wrong comments

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-246?page=all ]
     
Doug Cutting closed HADOOP-246:
-------------------------------


> the record-io generated c++ has wrong comments
> ----------------------------------------------
>
>          Key: HADOOP-246
>          URL: http://issues.apache.org/jira/browse/HADOOP-246
>      Project: Hadoop
>         Type: Bug

>   Components: record
>     Versions: 0.2.1
>     Reporter: Owen O'Malley
>     Assignee: Milind Bhandarkar
>      Fix For: 0.3.0

>
> The comments on the namespaces on the closing come out backward:
> } // end namespace org
> } // end namespace apache
> } // end namespace hadoop
> } // end namespace record
> } // end namespace test

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira