You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/19 18:57:28 UTC
[GitHub] [solr] madrob opened a new pull request #36: Allow configuring maven snapshots repository mirrors
madrob opened a new pull request #36:
URL: https://github.com/apache/solr/pull/36
Not sure if this is the best approach, but I need a way to be able to specify an internal repo for building against Lucene snapshots without depending on the state of the last published Apache snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] dweiss commented on a change in pull request #36: Allow configuring maven snapshots repository mirrors
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #36:
URL: https://github.com/apache/solr/pull/36#discussion_r597950033
##########
File path: gradle/defaults.gradle
##########
@@ -77,4 +68,13 @@ allprojects {
}
}
}
+
+ // Repositories to fetch dependencies from.
+ repositories {
Review comment:
Maybe check for a separate property "custom.snapshots.repo" and if it exists skip the "ApacheSnapshots" and define a "CustomRepository"? It's weird to just substitute the URL here. I'm not sure if a more elegant way of doing this exists (although there very likely must be one for folks behind corporate firewalls)...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] madrob commented on pull request #36: Allow configuring maven snapshots repository mirrors
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #36:
URL: https://github.com/apache/solr/pull/36#issuecomment-804187352
I ended up with a few other workarounds, the one that worked is I think that users can define another maven repository with the same name in their init.gradle and it will overwrite the URL value we set. I had a bunch of other things I tried so I'm not 100% sure that's the one that worked, but I'm afraid to change things now because it was such a pain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #36: Allow configuring maven snapshots repository mirrors
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #36:
URL: https://github.com/apache/solr/pull/36#discussion_r597964277
##########
File path: gradle/defaults.gradle
##########
@@ -77,4 +68,13 @@ allprojects {
}
}
}
+
+ // Repositories to fetch dependencies from.
+ repositories {
+ mavenCentral()
+ maven {
+ name "ApacheSnapshots"
+ url propertyOrDefault('apache-snapshot-repo', 'https://repository.apache.org/content/repositories/snapshots/')
Review comment:
Does it need to have "Apache" in the name? With the URL configurable, associating with Apache seems wrong/misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] madrob closed pull request #36: Allow configuring maven snapshots repository mirrors
Posted by GitBox <gi...@apache.org>.
madrob closed pull request #36:
URL: https://github.com/apache/solr/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org