You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by TomasHofman <gi...@git.apache.org> on 2017/06/01 09:25:49 UTC

[GitHub] activemq-artemis pull request #1311: ARTEMIS-1187 Incompatible version when ...

GitHub user TomasHofman opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1311

    ARTEMIS-1187 Incompatible version when recreating a session with olde…

    …r server
    
    https://issues.apache.org/jira/browse/ARTEMIS-1187
    https://issues.jboss.org/browse/JBEAP-9522
    
    Upstream PR: https://github.com/apache/activemq-artemis/pull/1298

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TomasHofman/activemq-artemis JBEAP-9522-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1311.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1311
    
----
commit e6e366872252f80ce36d063925f7961e0a2015ee
Author: Tomas Hofman <th...@redhat.com>
Date:   2017-05-29T10:27:09Z

    ARTEMIS-1187 Incompatible version when recreating a session with older server

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1311: ARTEMIS-1187 Incompatible version when ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1311


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1311: ARTEMIS-1187 Incompatible version when ...

Posted by TomasHofman <gi...@git.apache.org>.
Github user TomasHofman commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1311#discussion_r119632869
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java ---
    @@ -643,7 +643,7 @@ protected CreateSessionMessage newCreateSession(String username,
                                                        boolean autoCommitSends,
                                                        boolean autoCommitAcks,
                                                        boolean preAcknowledge) {
    -      return new CreateSessionMessage(name, sessionChannel.getID(), VersionLoader.getVersion().getIncrementingVersion(), username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null);
    --- End diff --
    
    OK, 1.x and 1.5.5-x PRs should be good now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1311: ARTEMIS-1187 Incompatible version when ...

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1311#discussion_r119606267
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java ---
    @@ -643,7 +643,7 @@ protected CreateSessionMessage newCreateSession(String username,
                                                        boolean autoCommitSends,
                                                        boolean autoCommitAcks,
                                                        boolean preAcknowledge) {
    -      return new CreateSessionMessage(name, sessionChannel.getID(), VersionLoader.getVersion().getIncrementingVersion(), username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null);
    --- End diff --
    
    There's another commi I had to do on master to fix checkstyle.
    
    
    if you could please try building with:
    
    ```
    mvn install -Pdev install -DskipTests=true
    ```
    
    
    You will see where the checkstyle failed.
    
    
    Please amend and a push -f..
    
    
    I have seen a Pull request for the wildfly fork, you will have to do the same now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---