You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2014/04/01 23:33:02 UTC
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/291
SPARK-1387. Update build plugins, avoid plugin version warning, centralize versions
Another handful of small build changes to organize and standardize a bit, and avoid warnings:
- Update Maven plugin versions for good measure
- Since plugins need maven 3.0.4 already, require it explicitly (<3.0.4 had some bugs anyway)
- Use variables to define versions across dependencies where they should move in lock step
- ... and make this consistent between Maven/SBT
OK, I also updated the JIRA URL while I was at it here.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-1387
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #291
----
commit 32f5f4501bf204e0655a3b07e173d6716c746cfe
Author: Sean Owen <so...@cloudera.com>
Date: 2014-04-01T21:29:52Z
Update plugins and Maven version; use variables consistently across Maven/SBT to define dependency versions that should stay in step.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/291#issuecomment-39262500
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/291#issuecomment-39688554
Okay I'm just gonna merge this with a minor doc change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/291#issuecomment-39667204
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13820/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/291#issuecomment-39728466
Thanks @pwendell for finishing it off with the doc update -- would have done it if I weren't asleep here!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/291#discussion_r11328600
--- Diff: pom.xml ---
@@ -54,11 +54,11 @@
</developers>
<issueManagement>
<system>JIRA</system>
- <url>https://spark-project.atlassian.net/browse/SPARK</url>
+ <url>https://issues.apache.org/jira/browse/SPARK</url>
</issueManagement>
<prerequisites>
- <maven>3.0.0</maven>
+ <maven>3.0.4</maven>
--- End diff --
The Maven versions plugin claimed that some plugin already in use required Maven >= 3.0.4. I presume it would warn or fail if run with earlier versions, which would indicate no active devs are running an earlier version, but I can't be sure. This was just a bit of tidiness.
Is anyone out there on Maven < 3.0.4? In general I think it's easy to upgrade; on Linux they're just packages and AFAIK people usually use `brew` on OS X to easily update things like this.
If there's a hint that it might cause pains, it can be reversed, but I am presuming that we would know already if someone was using <3.0.4?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/291#issuecomment-39667203
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/291#issuecomment-39271482
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/291#issuecomment-39686424
Looks great! Two very minor comments/questions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/291#issuecomment-39666117
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/291#discussion_r11328562
--- Diff: pom.xml ---
@@ -810,7 +814,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
- <version>2.4</version>
--- End diff --
just to confirm - this will inherit the version from our own `pluginManagement` section in this same pom, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/291#issuecomment-39666122
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/291#issuecomment-39271485
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13648/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/291#issuecomment-39262512
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/291#discussion_r11328579
--- Diff: pom.xml ---
@@ -810,7 +814,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
- <version>2.4</version>
--- End diff --
Exactly, they are inherited. The idea is to move towards centralizing the versions in the main pom for everything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/291#discussion_r11328744
--- Diff: pom.xml ---
@@ -54,11 +54,11 @@
</developers>
<issueManagement>
<system>JIRA</system>
- <url>https://spark-project.atlassian.net/browse/SPARK</url>
+ <url>https://issues.apache.org/jira/browse/SPARK</url>
</issueManagement>
<prerequisites>
- <maven>3.0.0</maven>
+ <maven>3.0.4</maven>
--- End diff --
Okay - mind updating the `building-with-maven` doc then? It currently says
```
Building Spark using Maven Requires Maven 3 (the build process is tested with Maven 3.0.4) and Java 1.6 or newer.
```
But maybe we can just say:
```
Building Spark using Maven Requires Maven 3.0.4 or newer and Java 1.6 or newer.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1387. Update build plugins, avoid plugin...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/291#discussion_r11328543
--- Diff: pom.xml ---
@@ -54,11 +54,11 @@
</developers>
<issueManagement>
<system>JIRA</system>
- <url>https://spark-project.atlassian.net/browse/SPARK</url>
+ <url>https://issues.apache.org/jira/browse/SPARK</url>
</issueManagement>
<prerequisites>
- <maven>3.0.0</maven>
+ <maven>3.0.4</maven>
--- End diff --
Just wondering - why is this needed? Does this mean that users with Maven 3.0.X (X < 4) will need to upgrade?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---