You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2018/12/03 18:14:42 UTC
[GitHub] nifi-minifi-cpp pull request #454: MINIFICPP-404: Correct invalid assumption...
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/454
MINIFICPP-404: Correct invalid assumption and protect against invalid…
… protocols
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-404
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/454.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #454
----
commit 8c08f31273f72f37bf640d27ea52c5821e98a8d4
Author: Marc Parisi <ph...@...>
Date: 2018-12-03T18:14:26Z
MINIFICPP-404: Correct invalid assumption and protect against invalid protocols
----
---
[GitHub] nifi-minifi-cpp pull request #454: MINIFICPP-404: Correct invalid assumption...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/454#discussion_r239092725
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -325,6 +325,12 @@ void YamlConfiguration::parseRemoteProcessGroupYaml(YAML::Node *rpgNode, core::P
}
}
}
+ } else if (transport_protocol == "RAW") {
+ group->setTransportProtocol(transport_protocol);
+ } else {
+ std::stringstream stream;
+ stream << "Invalid transport protocol " << transport_protocol;
+ throw minifi::Exception(ExceptionType::SITE2SITE_EXCEPTION, stream.str().c_str());
--- End diff --
I think it's vestigial (existed since the early days of the project )-- no reason, just no desire to make changes that require unnecessary classes to change in this PR. If someone said, "it has to be done to approve," I'd go ahead and do it but a follow on PR like the one you made is perfect.
---
[GitHub] nifi-minifi-cpp pull request #454: MINIFICPP-404: Correct invalid assumption...
Posted by arpadboda <gi...@git.apache.org>.
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/454#discussion_r238631364
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -325,6 +325,12 @@ void YamlConfiguration::parseRemoteProcessGroupYaml(YAML::Node *rpgNode, core::P
}
}
}
+ } else if (transport_protocol == "RAW") {
+ group->setTransportProtocol(transport_protocol);
+ } else {
+ std::stringstream stream;
+ stream << "Invalid transport protocol " << transport_protocol;
+ throw minifi::Exception(ExceptionType::SITE2SITE_EXCEPTION, stream.str().c_str());
--- End diff --
This is fine, however makes me wonder why don't we have string param ctr. for minifi::Exception as we convert to the const char* to string anyway in the current ctr.
---
[GitHub] nifi-minifi-cpp pull request #454: MINIFICPP-404: Correct invalid assumption...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/454
---