You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/07/29 22:10:19 UTC
[PR] [SPARK-58435][SQL] Use named containsNull argument in KLL sketch ArrayType results [spark]
uros-b opened a new pull request, #57642:
URL: https://github.com/apache/spark/pull/57642
### What changes were proposed in this pull request?
Uses the named `containsNull = false` argument in the two `dataType` overrides of the KLL sketch expressions, matching the named form already used by the `inputTypes` declarations in the same classes.
### Why are the changes needed?
`ArrayType`'s second (and final) parameter is `containsNull`, so bare positional `false` and `containsNull = false` compile identically; this only aligns the two outliers with the file's own dominant idiom.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Stylistic, behavior-identical change. No new tests needed.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58435][SQL] Use named containsNull argument in KLL sketch ArrayType results [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57642:
URL: https://github.com/apache/spark/pull/57642#issuecomment-5181082206
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/496d20f8c05fa93407edefb123134026e259b9fe
- merged into branch-4.x https://github.com/apache/spark/commit/607fcce250d2d604ec437a19a91fb36630fac0aa
- merged into branch-4.3 https://github.com/apache/spark/commit/456e0057d8a6ae7d853808a5372c857a68cf0f9e
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58435][SQL] Use named containsNull argument in KLL sketch ArrayType results [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #57642: [SPARK-58435][SQL] Use named containsNull argument in KLL sketch ArrayType results
URL: https://github.com/apache/spark/pull/57642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org